* [PATCH] drm/i915/icl: MBUS B credit change
@ 2018-10-04 15:18 Rodrigo Vivi
2018-10-04 16:03 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Rodrigo Vivi @ 2018-10-04 15:18 UTC (permalink / raw)
To: intel-gfx; +Cc: Arthur J Runyan, Lucas De Marchi, Paulo Zanoni, Rodrigo Vivi
No functional change. But just a minor change to keep
up with Spec, since it has changed since commit c3cc39c539d4
("drm/i915/icl: program mbus during pipe enable")
The instructions previously said to program pipe's
B credit = 24 / number of pipes, which is 8 for ICL.
Now the spec gives us direct values independent of number
of pipes. Let's keep in sync.
Also just a reorder on fields to make easier to compare
against spec's sequence: A -> BW -> B.
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Mahesh Kumar <mahesh1.kumar@intel.com>
Cc: Arthur J Runyan <arthur.j.runyan@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 36434c5359b1..eb2250a984a8 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -5683,10 +5683,9 @@ static void icl_pipe_mbus_enable(struct intel_crtc *crtc)
enum pipe pipe = crtc->pipe;
uint32_t val;
- val = MBUS_DBOX_BW_CREDIT(1) | MBUS_DBOX_A_CREDIT(2);
-
- /* Program B credit equally to all pipes */
- val |= MBUS_DBOX_B_CREDIT(24 / INTEL_INFO(dev_priv)->num_pipes);
+ val = MBUS_DBOX_A_CREDIT(2);
+ val |= MBUS_DBOX_BW_CREDIT(1);
+ val |= MBUS_DBOX_B_CREDIT(8);
I915_WRITE(PIPE_MBUS_DBOX_CTL(pipe), val);
}
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/icl: MBUS B credit change
2018-10-04 15:18 [PATCH] drm/i915/icl: MBUS B credit change Rodrigo Vivi
@ 2018-10-04 16:03 ` Patchwork
2018-10-04 23:50 ` ✓ Fi.CI.IGT: " Patchwork
2018-10-05 9:10 ` [PATCH] " Kumar, Mahesh
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-10-04 16:03 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/icl: MBUS B credit change
URL : https://patchwork.freedesktop.org/series/50560/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4931 -> Patchwork_10363 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/50560/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_10363 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s3:
fi-bdw-samus: NOTRUN -> INCOMPLETE (fdo#107773)
==== Possible fixes ====
igt@drv_module_reload@basic-reload:
fi-blb-e6850: INCOMPLETE (fdo#107718) -> PASS
igt@gem_ctx_param@basic-default:
fi-pnv-d510: INCOMPLETE (fdo#106007) -> SKIP
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: FAIL (fdo#103167) -> PASS
igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
fi-byt-clapper: FAIL (fdo#103191, fdo#107362) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-a:
fi-byt-clapper: FAIL (fdo#107362) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-cfl-8109u: INCOMPLETE (fdo#108126, fdo#106070) -> PASS
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#106007 https://bugs.freedesktop.org/show_bug.cgi?id=106007
fdo#106070 https://bugs.freedesktop.org/show_bug.cgi?id=106070
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#108126 https://bugs.freedesktop.org/show_bug.cgi?id=108126
== Participating hosts (48 -> 42) ==
Additional (2): fi-icl-u fi-bdw-samus
Missing (8): fi-cnl-u fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-icl-u2 fi-bsw-cyan fi-ctg-p8600 fi-kbl-7560u
== Build changes ==
* Linux: CI_DRM_4931 -> Patchwork_10363
CI_DRM_4931: 826702bf60ae2b37841c051ed769b44af194fbb1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4667: 596f48dcd59fd2f8c16671514f3e69d4a2891374 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10363: 8e4a871c30c1762b4674e3680ccaa8a01cf5a9c9 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
8e4a871c30c1 drm/i915/icl: MBUS B credit change
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10363/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915/icl: MBUS B credit change
2018-10-04 15:18 [PATCH] drm/i915/icl: MBUS B credit change Rodrigo Vivi
2018-10-04 16:03 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-10-04 23:50 ` Patchwork
2018-10-05 9:10 ` [PATCH] " Kumar, Mahesh
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-10-04 23:50 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/icl: MBUS B credit change
URL : https://patchwork.freedesktop.org/series/50560/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4931_full -> Patchwork_10363_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_10363_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_await@wide-contexts:
shard-kbl: PASS -> FAIL (fdo#106680)
igt@gem_exec_flush@basic-batch-kernel-default-wb:
shard-glk: PASS -> INCOMPLETE (fdo#103359, k.org#198133) +1
igt@gem_exec_schedule@pi-ringfull-bsd:
shard-skl: NOTRUN -> FAIL (fdo#103158)
igt@gem_ppgtt@blt-vs-render-ctxn:
shard-skl: NOTRUN -> TIMEOUT (fdo#108039)
igt@kms_busy@extended-modeset-hang-newfb-render-a:
shard-skl: NOTRUN -> DMESG-WARN (fdo#107956)
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
shard-snb: PASS -> DMESG-WARN (fdo#107956)
igt@kms_color@pipe-b-degamma:
shard-apl: PASS -> FAIL (fdo#104782)
igt@kms_cursor_crc@cursor-128x128-random:
shard-apl: PASS -> FAIL (fdo#103232) +2
igt@kms_cursor_crc@cursor-size-change:
shard-glk: PASS -> FAIL (fdo#103232) +2
igt@kms_fbcon_fbt@fbc-suspend:
shard-glk: PASS -> FAIL (fdo#105681, fdo#103833)
shard-skl: PASS -> INCOMPLETE (fdo#104108)
igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
shard-glk: PASS -> FAIL (fdo#105363)
igt@kms_flip@flip-vs-expired-vblank:
shard-skl: PASS -> FAIL (fdo#105363)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
shard-apl: PASS -> FAIL (fdo#103167) +1
igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack:
shard-glk: PASS -> DMESG-WARN (fdo#106538, fdo#105763) +2
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite:
shard-glk: PASS -> FAIL (fdo#103167)
igt@kms_plane@pixel-format-pipe-a-planes:
shard-skl: NOTRUN -> DMESG-WARN (fdo#106885)
igt@kms_plane@plane-position-covered-pipe-b-planes:
shard-glk: PASS -> FAIL (fdo#103166) +3
{igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb}:
shard-skl: NOTRUN -> FAIL (fdo#108145) +1
igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
shard-apl: PASS -> FAIL (fdo#103166) +1
==== Possible fixes ====
igt@kms_cursor_crc@cursor-256x256-sliding:
shard-glk: FAIL (fdo#103232) -> PASS +1
igt@kms_cursor_crc@cursor-256x85-sliding:
shard-apl: FAIL (fdo#103232) -> PASS +1
igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-xtiled:
shard-skl: FAIL (fdo#107791) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
shard-apl: FAIL (fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
shard-glk: FAIL (fdo#103167) -> PASS +1
igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
shard-glk: FAIL (fdo#103166) -> PASS
igt@kms_universal_plane@universal-plane-pipe-c-functional:
shard-apl: FAIL (fdo#103166) -> PASS
igt@pm_rpm@legacy-planes:
shard-skl: INCOMPLETE (fdo#107807, fdo#105959) -> PASS
==== Warnings ====
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
shard-apl: DMESG-WARN (fdo#107956) -> INCOMPLETE (fdo#103927)
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103833 https://bugs.freedesktop.org/show_bug.cgi?id=103833
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105681 https://bugs.freedesktop.org/show_bug.cgi?id=105681
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#105959 https://bugs.freedesktop.org/show_bug.cgi?id=105959
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
fdo#106885 https://bugs.freedesktop.org/show_bug.cgi?id=106885
fdo#107791 https://bugs.freedesktop.org/show_bug.cgi?id=107791
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108039 https://bugs.freedesktop.org/show_bug.cgi?id=108039
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4931 -> Patchwork_10363
CI_DRM_4931: 826702bf60ae2b37841c051ed769b44af194fbb1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4667: 596f48dcd59fd2f8c16671514f3e69d4a2891374 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10363: 8e4a871c30c1762b4674e3680ccaa8a01cf5a9c9 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10363/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/icl: MBUS B credit change
2018-10-04 15:18 [PATCH] drm/i915/icl: MBUS B credit change Rodrigo Vivi
2018-10-04 16:03 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-10-04 23:50 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-10-05 9:10 ` Kumar, Mahesh
2018-10-05 21:01 ` Rodrigo Vivi
2 siblings, 1 reply; 5+ messages in thread
From: Kumar, Mahesh @ 2018-10-05 9:10 UTC (permalink / raw)
To: Rodrigo Vivi, intel-gfx; +Cc: Arthur J Runyan, Lucas De Marchi, Paulo Zanoni
Hi,
LGTM
Reviewed-by: Mahesh Kumar <mahesh1.kumar@intel.com>
On 10/4/2018 8:48 PM, Rodrigo Vivi wrote:
> No functional change. But just a minor change to keep
> up with Spec, since it has changed since commit c3cc39c539d4
> ("drm/i915/icl: program mbus during pipe enable")
>
> The instructions previously said to program pipe's
> B credit = 24 / number of pipes, which is 8 for ICL.
> Now the spec gives us direct values independent of number
> of pipes. Let's keep in sync.
>
> Also just a reorder on fields to make easier to compare
> against spec's sequence: A -> BW -> B.
>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: Mahesh Kumar <mahesh1.kumar@intel.com>
> Cc: Arthur J Runyan <arthur.j.runyan@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 36434c5359b1..eb2250a984a8 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -5683,10 +5683,9 @@ static void icl_pipe_mbus_enable(struct intel_crtc *crtc)
> enum pipe pipe = crtc->pipe;
> uint32_t val;
>
> - val = MBUS_DBOX_BW_CREDIT(1) | MBUS_DBOX_A_CREDIT(2);
> -
> - /* Program B credit equally to all pipes */
> - val |= MBUS_DBOX_B_CREDIT(24 / INTEL_INFO(dev_priv)->num_pipes);
> + val = MBUS_DBOX_A_CREDIT(2);
> + val |= MBUS_DBOX_BW_CREDIT(1);
> + val |= MBUS_DBOX_B_CREDIT(8);
>
> I915_WRITE(PIPE_MBUS_DBOX_CTL(pipe), val);
> }
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/icl: MBUS B credit change
2018-10-05 9:10 ` [PATCH] " Kumar, Mahesh
@ 2018-10-05 21:01 ` Rodrigo Vivi
0 siblings, 0 replies; 5+ messages in thread
From: Rodrigo Vivi @ 2018-10-05 21:01 UTC (permalink / raw)
To: Kumar, Mahesh; +Cc: intel-gfx, Arthur J Runyan, Lucas De Marchi, Paulo Zanoni
On Fri, Oct 05, 2018 at 02:40:01PM +0530, Kumar, Mahesh wrote:
> Hi,
>
> LGTM
>
> Reviewed-by: Mahesh Kumar <mahesh1.kumar@intel.com>
pushed to dinq adding also the rv-b from lucas
I got offline...
>
> On 10/4/2018 8:48 PM, Rodrigo Vivi wrote:
> > No functional change. But just a minor change to keep
> > up with Spec, since it has changed since commit c3cc39c539d4
> > ("drm/i915/icl: program mbus during pipe enable")
> >
> > The instructions previously said to program pipe's
> > B credit = 24 / number of pipes, which is 8 for ICL.
> > Now the spec gives us direct values independent of number
> > of pipes. Let's keep in sync.
> >
> > Also just a reorder on fields to make easier to compare
> > against spec's sequence: A -> BW -> B.
> >
> > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > Cc: Mahesh Kumar <mahesh1.kumar@intel.com>
> > Cc: Arthur J Runyan <arthur.j.runyan@intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 7 +++----
> > 1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index 36434c5359b1..eb2250a984a8 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -5683,10 +5683,9 @@ static void icl_pipe_mbus_enable(struct intel_crtc *crtc)
> > enum pipe pipe = crtc->pipe;
> > uint32_t val;
> > - val = MBUS_DBOX_BW_CREDIT(1) | MBUS_DBOX_A_CREDIT(2);
> > -
> > - /* Program B credit equally to all pipes */
> > - val |= MBUS_DBOX_B_CREDIT(24 / INTEL_INFO(dev_priv)->num_pipes);
> > + val = MBUS_DBOX_A_CREDIT(2);
> > + val |= MBUS_DBOX_BW_CREDIT(1);
> > + val |= MBUS_DBOX_B_CREDIT(8);
> > I915_WRITE(PIPE_MBUS_DBOX_CTL(pipe), val);
> > }
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-05 21:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-04 15:18 [PATCH] drm/i915/icl: MBUS B credit change Rodrigo Vivi
2018-10-04 16:03 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-10-04 23:50 ` ✓ Fi.CI.IGT: " Patchwork
2018-10-05 9:10 ` [PATCH] " Kumar, Mahesh
2018-10-05 21:01 ` Rodrigo Vivi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.