[Outreachy kernel][PATCH v6] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

[Outreachy kernel][PATCH v6] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

[Bhanusree Pola]

Adjust all lines exceeding 75 chars per line to fix checkpatch warning.

Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
---

changes in v6:
-Always commit on the base version.

changes in v5:
-Fixed Change log
-Change in subject line. Do not send as 'Re:'

changes in v4:
-Remove Whitespace in comment section of module_comedi_pci_driver()
 to fix checkpatch Error.

changes in v3:
-Comment section of module_pci_driver() exceeds 75 characters.
 Adjust the chars to 75 per line
-Modified log message.
-Added change log.

changes in v2:
-comedi_pci_auto_config() function prototype is exceeds
 75 characters per line. Adjust to 75 chars to improve
 readability and also adjust the arguments to match open
 parantheses.
-Comment section of module_comedi_pci_driver() exceeds 75
 characters. Modified contents to adjust 75 chars per line.

 drivers/staging/comedi/comedi_pci.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h
index 4e069440cbdc..9d07c9a68f53 100644
--- a/drivers/staging/comedi/comedi_pci.h
+++ b/drivers/staging/comedi/comedi_pci.h
@@ -31,7 +31,8 @@ int comedi_pci_enable(struct comedi_device *dev);
 void comedi_pci_disable(struct comedi_device *dev);
 void comedi_pci_detach(struct comedi_device *dev);
 
-int comedi_pci_auto_config(struct pci_dev *pcidev, struct comedi_driver *driver,
+int comedi_pci_auto_config(struct pci_dev *pcidev,
+			   struct comedi_driver *driver,
 			   unsigned long context);
 void comedi_pci_auto_unconfig(struct pci_dev *pcidev);
 
@@ -41,7 +42,8 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver,
 				  struct pci_driver *pci_driver);
 
 /**
- * module_comedi_pci_driver() - Helper macro for registering a comedi PCI driver
+ * module_comedi_pci_driver() - Helper macro for registering a comedi PCI
+ * driver
  * @__comedi_driver: comedi_driver struct
  * @__pci_driver: pci_driver struct
  *
-- 
2.17.1

Re: [Outreachy kernel][PATCH v6] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

[Greg KH]

On Sun, Oct 07, 2018 at 04:07:17PM +0530, Bhanusree Pola wrote:
> @@ -41,7 +42,8 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver,
>  				  struct pci_driver *pci_driver);
>  
>  /**
> - * module_comedi_pci_driver() - Helper macro for registering a comedi PCI driver
> + * module_comedi_pci_driver() - Helper macro for registering a comedi PCI
> + * driver

I do not think that kerneldoc can handle wrapped lines like this, so it
is fine to just leave this as-is.

checkpatch is just a hint, not a hard rule, sometimes it gets things
wrong.

thanks,

greg k-h