From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
Subject: [PATCH v2] staging: erofs: add SPDX identifer
Date: Mon, 8 Oct 2018 16:22:28 +0200 [thread overview]
Message-ID: <20181008142228.GB13359@kroah.com> (raw)
In-Reply-To: <20181008141409.2624-1-loic.tourlonias.lkml@gmail.com>
On Mon, Oct 08, 2018@04:14:09PM +0200, Loic Tourlonias wrote:
> Add SPDX identifier to simplify header and remove whole license text
>
> v1 -> v2:
>
> Move SPDX identifier to first line and change comment delimiter
The "changes" need to go below the --- line.
>
> Signed-off-by: Loic Tourlonias <loic.tourlonias.lkml at gmail.com>
> ---
> drivers/staging/erofs/lz4defs.h | 24 ++----------------------
> 1 file changed, 2 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/staging/erofs/lz4defs.h b/drivers/staging/erofs/lz4defs.h
> index 00a0b58a0871..cdacc57e6a08 100644
> --- a/drivers/staging/erofs/lz4defs.h
> +++ b/drivers/staging/erofs/lz4defs.h
> @@ -1,32 +1,12 @@
> +/* SPDX-License-Identifier: BSD-2-Clause*/
> #ifndef __LZ4DEFS_H__
> #define __LZ4DEFS_H__
> -
> /*
Why delete that line?
But wait, why do we even have this file at all? What's wrong with the
lib/lz4/ code that we have in the kernel today? Shouldn't the code
using these files be moved over to use the lib/ code instead and this
file be deleted?
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Loic Tourlonias <loic.tourlonias.lkml@gmail.com>
Cc: Gao Xiang <gaoxiang25@huawei.com>, Chao Yu <yuchao0@huawei.com>,
devel@driverdev.osuosl.org, linux-erofs@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: erofs: add SPDX identifer
Date: Mon, 8 Oct 2018 16:22:28 +0200 [thread overview]
Message-ID: <20181008142228.GB13359@kroah.com> (raw)
In-Reply-To: <20181008141409.2624-1-loic.tourlonias.lkml@gmail.com>
On Mon, Oct 08, 2018 at 04:14:09PM +0200, Loic Tourlonias wrote:
> Add SPDX identifier to simplify header and remove whole license text
>
> v1 -> v2:
>
> Move SPDX identifier to first line and change comment delimiter
The "changes" need to go below the --- line.
>
> Signed-off-by: Loic Tourlonias <loic.tourlonias.lkml@gmail.com>
> ---
> drivers/staging/erofs/lz4defs.h | 24 ++----------------------
> 1 file changed, 2 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/staging/erofs/lz4defs.h b/drivers/staging/erofs/lz4defs.h
> index 00a0b58a0871..cdacc57e6a08 100644
> --- a/drivers/staging/erofs/lz4defs.h
> +++ b/drivers/staging/erofs/lz4defs.h
> @@ -1,32 +1,12 @@
> +/* SPDX-License-Identifier: BSD-2-Clause*/
> #ifndef __LZ4DEFS_H__
> #define __LZ4DEFS_H__
> -
> /*
Why delete that line?
But wait, why do we even have this file at all? What's wrong with the
lib/lz4/ code that we have in the kernel today? Shouldn't the code
using these files be moved over to use the lib/ code instead and this
file be deleted?
thanks,
greg k-h
next prev parent reply other threads:[~2018-10-08 14:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 14:14 [PATCH v2] staging: erofs: add SPDX identifer Loic Tourlonias
2018-10-08 14:14 ` Loic Tourlonias
2018-10-08 14:22 ` Greg Kroah-Hartman [this message]
2018-10-08 14:22 ` Greg Kroah-Hartman
2018-10-08 14:36 ` Gao Xiang
2018-10-08 14:36 ` Gao Xiang
2018-10-08 14:41 ` Gao Xiang
2018-10-08 14:41 ` Gao Xiang
2018-10-08 14:43 ` Greg Kroah-Hartman
2018-10-08 14:43 ` Greg Kroah-Hartman
2018-10-08 14:48 ` Gao Xiang
2018-10-08 14:48 ` Gao Xiang
2018-10-08 15:00 ` loïc tourlonias
2018-10-08 15:00 ` loïc tourlonias
2018-10-08 15:02 ` Gao Xiang
2018-10-08 15:02 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008142228.GB13359@kroah.com \
--to=gregkh@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.