All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Bhanusree Pola <bhanusreemahesh@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel][PATCH] staging: mt7621-dma: Fix Spelling
Date: Mon, 8 Oct 2018 16:45:10 +0200	[thread overview]
Message-ID: <20181008144510.GC15968@kroah.com> (raw)
In-Reply-To: <20181008143321.GA12062@veda-VGN-CS3AGH-R>

On Mon, Oct 08, 2018 at 08:03:22PM +0530, Bhanusree Pola wrote:
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> 
> Fix Spelling in #define GDMA_REG_CTRL1_CONTINOUS. Perhaps 'CONTINUOUS'

Changelog goes above the signed-off-by line.

> ---
>  drivers/staging/mt7621-dma/ralink-gdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/mt7621-dma/ralink-gdma.c b/drivers/staging/mt7621-dma/ralink-gdma.c
> index 6d9fe175ea52..a430c8afa3d0 100644
> --- a/drivers/staging/mt7621-dma/ralink-gdma.c
> +++ b/drivers/staging/mt7621-dma/ralink-gdma.c
> @@ -47,7 +47,7 @@
>  #define GDMA_REG_CTRL1_REQ_MASK		0x3f
>  #define GDMA_REG_CTRL1_SRC_REQ_SHIFT	16
>  #define GDMA_REG_CTRL1_DST_REQ_SHIFT	8
> -#define GDMA_REG_CTRL1_CONTINOUS	BIT(14)
> +#define GDMA_REG_CTRL1_CONTINUOUS	BIT(14)

If you changed this, and no code broke, that means this define isn't
used anywhere, so why not just delete it?

thanks,

greg k-h


      reply	other threads:[~2018-10-08 14:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 14:33 [Outreachy kernel][PATCH] staging: mt7621-dma: Fix Spelling Bhanusree Pola
2018-10-08 14:45 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181008144510.GC15968@kroah.com \
    --to=greg@kroah.com \
    --cc=bhanusreemahesh@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.