* [Outreachy kernel][PATCH] staging: mt7621-dma: Fix Spelling
@ 2018-10-08 14:33 Bhanusree Pola
2018-10-08 14:45 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Bhanusree Pola @ 2018-10-08 14:33 UTC (permalink / raw)
To: outreachy-kernel; +Cc: greg
Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
Fix Spelling in #define GDMA_REG_CTRL1_CONTINOUS. Perhaps 'CONTINUOUS'
---
drivers/staging/mt7621-dma/ralink-gdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-dma/ralink-gdma.c b/drivers/staging/mt7621-dma/ralink-gdma.c
index 6d9fe175ea52..a430c8afa3d0 100644
--- a/drivers/staging/mt7621-dma/ralink-gdma.c
+++ b/drivers/staging/mt7621-dma/ralink-gdma.c
@@ -47,7 +47,7 @@
#define GDMA_REG_CTRL1_REQ_MASK 0x3f
#define GDMA_REG_CTRL1_SRC_REQ_SHIFT 16
#define GDMA_REG_CTRL1_DST_REQ_SHIFT 8
-#define GDMA_REG_CTRL1_CONTINOUS BIT(14)
+#define GDMA_REG_CTRL1_CONTINUOUS BIT(14)
#define GDMA_REG_CTRL1_NEXT_MASK 0x1f
#define GDMA_REG_CTRL1_NEXT_SHIFT 3
#define GDMA_REG_CTRL1_COHERENT BIT(2)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel][PATCH] staging: mt7621-dma: Fix Spelling
2018-10-08 14:33 [Outreachy kernel][PATCH] staging: mt7621-dma: Fix Spelling Bhanusree Pola
@ 2018-10-08 14:45 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2018-10-08 14:45 UTC (permalink / raw)
To: Bhanusree Pola; +Cc: outreachy-kernel
On Mon, Oct 08, 2018 at 08:03:22PM +0530, Bhanusree Pola wrote:
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
>
> Fix Spelling in #define GDMA_REG_CTRL1_CONTINOUS. Perhaps 'CONTINUOUS'
Changelog goes above the signed-off-by line.
> ---
> drivers/staging/mt7621-dma/ralink-gdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/mt7621-dma/ralink-gdma.c b/drivers/staging/mt7621-dma/ralink-gdma.c
> index 6d9fe175ea52..a430c8afa3d0 100644
> --- a/drivers/staging/mt7621-dma/ralink-gdma.c
> +++ b/drivers/staging/mt7621-dma/ralink-gdma.c
> @@ -47,7 +47,7 @@
> #define GDMA_REG_CTRL1_REQ_MASK 0x3f
> #define GDMA_REG_CTRL1_SRC_REQ_SHIFT 16
> #define GDMA_REG_CTRL1_DST_REQ_SHIFT 8
> -#define GDMA_REG_CTRL1_CONTINOUS BIT(14)
> +#define GDMA_REG_CTRL1_CONTINUOUS BIT(14)
If you changed this, and no code broke, that means this define isn't
used anywhere, so why not just delete it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-08 14:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-08 14:33 [Outreachy kernel][PATCH] staging: mt7621-dma: Fix Spelling Bhanusree Pola
2018-10-08 14:45 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.