From: Will Deacon <will.deacon@arm.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Keith Busch <keith.busch@intel.com>,
Linux PCI <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Sinan Kaya <okaya@kernel.org>, Thomas Tai <thomas.tai@oracle.com>,
poza@codeaurora.org, Lukas Wunner <lukas@wunner.de>,
Christoph Hellwig <hch@lst.de>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/12] error handling and pciehp maintenance
Date: Tue, 9 Oct 2018 17:03:27 +0100 [thread overview]
Message-ID: <20181009160327.GE9259@arm.com> (raw)
In-Reply-To: <20181005173145.GL120535@bhelgaas-glaptop.roam.corp.google.com>
Hi Bjorn,
On Fri, Oct 05, 2018 at 12:31:45PM -0500, Bjorn Helgaas wrote:
> [+cc arm64 folks, LKML: This conversation is about this patch:
>
> https://lore.kernel.org/linux-pci/20180918235848.26694-3-keith.busch@intel.com
>
> which fixes some PCIe AER error injection bugs, but also makes the error
> injector dependent on DYNAMIC_FTRACE_WITH_REGS, which not all arches
> support. Note that this question is only about the error *injection*
> module used for testing. It doesn't affect AER support itself.]
>
> On Thu, Oct 04, 2018 at 04:11:37PM -0600, Keith Busch wrote:
> > In case this went unnoticed, patch 2's aer_inject using ftrace hooks
> > to pci config accessors is really cool and fixes several kernel crashes
> > I encountered, but it may not work on every architecture. I'm not sure
> > how widely aer_inject is used, so maybe there are no concerns with the
> > DYNAMIC_FTRACE_WITH_REGS dependency, but I just want to reemphasize that
> > dependency in case there are valid objections.
>
> Oh, indeed, I hadn't noticed this arch dependency. AFAICT, the new
> DYNAMIC_FTRACE_WITH_REGS dependency means aer_inject will work only
> on these arches:
>
> arm # if (!XIP_KERNEL) && !CPU_ENDIAN_BE32 && MMU
> powerpc # if PPC64 && CPU_LITTLE_ENDIAN
> riscv # ARCH_RV64I only
> s390
> x86
>
> Notably missing is arm64, which has DYNAMIC_FTRACE but not
> DYNAMIC_FTRACE_WITH_REGS.
Thanks for the heads-up here. This feature is currently in development for
arm64:
http://lkml.kernel.org/r/20181001141648.1DBED68BDF@newverein.lst.de
but the latest review comments suggest that it's a fair way from ready yet,
so I wouldn't hold your breath.
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/12] error handling and pciehp maintenance
Date: Tue, 9 Oct 2018 17:03:27 +0100 [thread overview]
Message-ID: <20181009160327.GE9259@arm.com> (raw)
In-Reply-To: <20181005173145.GL120535@bhelgaas-glaptop.roam.corp.google.com>
Hi Bjorn,
On Fri, Oct 05, 2018 at 12:31:45PM -0500, Bjorn Helgaas wrote:
> [+cc arm64 folks, LKML: This conversation is about this patch:
>
> https://lore.kernel.org/linux-pci/20180918235848.26694-3-keith.busch at intel.com
>
> which fixes some PCIe AER error injection bugs, but also makes the error
> injector dependent on DYNAMIC_FTRACE_WITH_REGS, which not all arches
> support. Note that this question is only about the error *injection*
> module used for testing. It doesn't affect AER support itself.]
>
> On Thu, Oct 04, 2018 at 04:11:37PM -0600, Keith Busch wrote:
> > In case this went unnoticed, patch 2's aer_inject using ftrace hooks
> > to pci config accessors is really cool and fixes several kernel crashes
> > I encountered, but it may not work on every architecture. I'm not sure
> > how widely aer_inject is used, so maybe there are no concerns with the
> > DYNAMIC_FTRACE_WITH_REGS dependency, but I just want to reemphasize that
> > dependency in case there are valid objections.
>
> Oh, indeed, I hadn't noticed this arch dependency. AFAICT, the new
> DYNAMIC_FTRACE_WITH_REGS dependency means aer_inject will work only
> on these arches:
>
> arm # if (!XIP_KERNEL) && !CPU_ENDIAN_BE32 && MMU
> powerpc # if PPC64 && CPU_LITTLE_ENDIAN
> riscv # ARCH_RV64I only
> s390
> x86
>
> Notably missing is arm64, which has DYNAMIC_FTRACE but not
> DYNAMIC_FTRACE_WITH_REGS.
Thanks for the heads-up here. This feature is currently in development for
arm64:
http://lkml.kernel.org/r/20181001141648.1DBED68BDF at newverein.lst.de
but the latest review comments suggest that it's a fair way from ready yet,
so I wouldn't hold your breath.
Will
next prev parent reply other threads:[~2018-10-09 16:03 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 23:58 [PATCH 00/12] error handling and pciehp maintenance Keith Busch
2018-09-18 23:58 ` [PATCH 01/12] PCI: Set PCI bus accessors to noinline Keith Busch
2018-09-18 23:58 ` [PATCH 02/12] PCI/AER: Covertly inject errors Keith Busch
2018-09-18 23:58 ` [PATCH 03/12] PCI/AER: Reuse existing service device lookup Keith Busch
2018-09-18 23:58 ` [PATCH 04/12] PCI/AER: Abstract AER interrupt handling Keith Busch
2018-09-18 23:58 ` [PATCH 05/12] PCI/AER: Remove dead code Keith Busch
2018-09-18 23:58 ` [PATCH 06/12] PCI/AER: Remove error source from aer struct Keith Busch
2018-09-18 23:58 ` [PATCH 07/12] PCI/AER: Use kfifo for tracking events Keith Busch
2018-09-18 23:58 ` [PATCH 08/12] PCI/AER: Use kfifo helper inserting locked elements Keith Busch
2018-09-18 23:58 ` [PATCH 09/12] PCI/AER: Don't read upstream ports below fatal errors Keith Busch
2018-09-18 23:58 ` [PATCH 10/12] PCI/AER: Use threaded IRQ for bottom half Keith Busch
2018-09-18 23:58 ` [PATCH 11/12] PCI/AER: Use managed resource allocations Keith Busch
2018-09-19 16:29 ` Sinan Kaya
2018-09-19 17:25 ` Keith Busch
2018-09-19 17:36 ` Sinan Kaya
2018-09-25 1:13 ` Benjamin Herrenschmidt
2018-09-25 14:17 ` Keith Busch
2018-09-18 23:58 ` [PATCH 12/12] PCI/pciehp: Use device managed allocations Keith Busch
2018-09-19 15:11 ` Sinan Kaya
2018-09-19 16:17 ` Keith Busch
2018-09-22 18:10 ` Lukas Wunner
2018-09-24 23:43 ` Bjorn Helgaas
2018-09-25 7:13 ` Lukas Wunner
2018-10-04 21:40 ` [PATCH 00/12] error handling and pciehp maintenance Bjorn Helgaas
2018-10-04 22:11 ` Keith Busch
2018-10-05 17:31 ` Bjorn Helgaas
2018-10-05 17:31 ` Bjorn Helgaas
2018-10-08 16:18 ` Keith Busch
2018-10-08 16:18 ` Keith Busch
2018-10-08 17:23 ` Bjorn Helgaas
2018-10-08 17:23 ` Bjorn Helgaas
2018-11-06 16:34 ` Lorenzo Pieralisi
2018-11-06 16:34 ` Lorenzo Pieralisi
2018-11-06 16:47 ` Keith Busch
2018-11-06 16:47 ` Keith Busch
2018-11-06 17:21 ` Lorenzo Pieralisi
2018-11-06 17:21 ` Lorenzo Pieralisi
2018-11-06 17:26 ` Keith Busch
2018-11-06 17:26 ` Keith Busch
2018-10-09 16:03 ` Will Deacon [this message]
2018-10-09 16:03 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009160327.GE9259@arm.com \
--to=will.deacon@arm.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=hch@lst.de \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=okaya@kernel.org \
--cc=poza@codeaurora.org \
--cc=thomas.tai@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.