* [PATCH] drm: Fix kernel doc for DRM_MODE_PROP_IMMUTABLE
@ 2018-10-02 21:50 Manasi Navare
2018-10-02 22:17 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Manasi Navare @ 2018-10-02 21:50 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Daniel Vetter
This patch explains the DRM_MODE_PROP_IMMUTABLE flag a bit better
by telling which function to call if kernel wants to update
drm object's immutable properties.
Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
---
include/drm/drm_property.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/drm/drm_property.h b/include/drm/drm_property.h
index 5b9efff35d6d..4a0a80d658c7 100644
--- a/include/drm/drm_property.h
+++ b/include/drm/drm_property.h
@@ -153,7 +153,8 @@ struct drm_property {
* userspace. The kernel is allowed to update the value of these
* properties. This is generally used to expose probe state to
* userspace, e.g. the EDID, or the connector path property on DP
- * MST sinks.
+ * MST sinks. Kernel can update the value of an immutable property
+ * by calling drm_object_property_set_value().
*/
uint32_t flags;
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* ✓ Fi.CI.BAT: success for drm: Fix kernel doc for DRM_MODE_PROP_IMMUTABLE
2018-10-02 21:50 [PATCH] drm: Fix kernel doc for DRM_MODE_PROP_IMMUTABLE Manasi Navare
@ 2018-10-02 22:17 ` Patchwork
2018-10-03 8:38 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-10-03 19:32 ` [PATCH] " Daniel Vetter
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-10-02 22:17 UTC (permalink / raw)
To: Manasi Navare; +Cc: intel-gfx
== Series Details ==
Series: drm: Fix kernel doc for DRM_MODE_PROP_IMMUTABLE
URL : https://patchwork.freedesktop.org/series/50462/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4915 -> Patchwork_10330 =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10330 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10330, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/50462/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10330:
=== IGT changes ===
==== Warnings ====
igt@drv_selftest@live_guc:
fi-glk-j4005: SKIP -> PASS
== Known issues ==
Here are the changes found in Patchwork_10330 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_flip@basic-flip-vs-modeset:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106000, fdo#106097)
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-cfl-8109u: PASS -> DMESG-WARN (fdo#106107)
fi-byt-clapper: PASS -> FAIL (fdo#103191, fdo#107362)
igt@pm_rpm@module-reload:
fi-glk-j4005: PASS -> FAIL (fdo#104767)
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: PASS -> FAIL (fdo#104008)
==== Possible fixes ====
igt@drv_selftest@live_coherency:
fi-gdg-551: DMESG-FAIL (fdo#107164) -> PASS
igt@drv_selftest@live_execlists:
fi-glk-j4005: INCOMPLETE (fdo#103359, k.org#198133) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
fi-byt-clapper: FAIL (fdo#103191, fdo#107362) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-skl-guc: FAIL (fdo#103191) -> PASS
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#104767 https://bugs.freedesktop.org/show_bug.cgi?id=104767
fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
fdo#106107 https://bugs.freedesktop.org/show_bug.cgi?id=106107
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (46 -> 42) ==
Missing (4): fi-bsw-cyan fi-byt-squawks fi-icl-u2 fi-skl-6260u
== Build changes ==
* Linux: CI_DRM_4915 -> Patchwork_10330
CI_DRM_4915: 26e7a7d954a9c28b97af8ca7813f430fd9117232 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4660: d0975646c50568e66e65b44b81d28232d059b94e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10330: 720c2874d3153afc44a0bc82f960ad571ab2b6ce @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
720c2874d315 drm: Fix kernel doc for DRM_MODE_PROP_IMMUTABLE
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10330/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* ✗ Fi.CI.IGT: failure for drm: Fix kernel doc for DRM_MODE_PROP_IMMUTABLE
2018-10-02 21:50 [PATCH] drm: Fix kernel doc for DRM_MODE_PROP_IMMUTABLE Manasi Navare
2018-10-02 22:17 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-10-03 8:38 ` Patchwork
2018-10-03 9:54 ` Martin Peres
2018-10-03 19:32 ` [PATCH] " Daniel Vetter
2 siblings, 1 reply; 6+ messages in thread
From: Patchwork @ 2018-10-03 8:38 UTC (permalink / raw)
To: Manasi Navare; +Cc: intel-gfx
== Series Details ==
Series: drm: Fix kernel doc for DRM_MODE_PROP_IMMUTABLE
URL : https://patchwork.freedesktop.org/series/50462/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4915_full -> Patchwork_10330_full =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_10330_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10330_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10330_full:
=== IGT changes ===
==== Possible regressions ====
igt@drv_selftest@mock_breadcrumbs:
shard-skl: PASS -> INCOMPLETE
igt@kms_color@pipe-a-ctm-max:
shard-apl: PASS -> FAIL +1
{igt@kms_plane_alpha_blend@pipe-b-coverage-7efc}:
shard-skl: NOTRUN -> FAIL
== Known issues ==
Here are the changes found in Patchwork_10330_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_suspend@shrink:
shard-skl: PASS -> INCOMPLETE (fdo#106886)
igt@gem_exec_await@wide-contexts:
shard-apl: PASS -> FAIL (fdo#106680)
igt@gem_exec_schedule@pi-ringfull-bsd:
shard-skl: NOTRUN -> FAIL (fdo#103158)
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
shard-skl: NOTRUN -> DMESG-WARN (fdo#107956)
igt@kms_color@pipe-a-degamma:
shard-apl: PASS -> FAIL (fdo#108145) +1
igt@kms_cursor_crc@cursor-256x85-random:
shard-apl: PASS -> FAIL (fdo#103232) +2
igt@kms_cursor_crc@cursor-64x64-suspend:
shard-skl: PASS -> INCOMPLETE (fdo#104108)
igt@kms_flip@plain-flip-fb-recreate-interruptible:
shard-skl: PASS -> FAIL (fdo#100368)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
shard-apl: PASS -> FAIL (fdo#103167) +2
igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
shard-kbl: PASS -> INCOMPLETE (fdo#103665)
igt@kms_plane@plane-position-covered-pipe-a-planes:
shard-apl: PASS -> FAIL (fdo#103166) +1
igt@kms_setmode@basic:
shard-snb: NOTRUN -> FAIL (fdo#99912)
==== Possible fixes ====
igt@gem_ppgtt@blt-vs-render-ctxn:
shard-kbl: INCOMPLETE (fdo#103665, fdo#106023) -> PASS
igt@gem_userptr_blits@readonly-unsync:
shard-skl: INCOMPLETE (fdo#108074) -> PASS
igt@kms_busy@extended-pageflip-hang-newfb-render-b:
shard-apl: DMESG-WARN (fdo#107956) -> PASS
igt@kms_ccs@pipe-b-missing-ccs-buffer:
shard-kbl: DMESG-WARN (fdo#105602, fdo#103558) -> PASS +14
igt@kms_color@pipe-b-ctm-max:
shard-apl: FAIL -> PASS
igt@kms_cursor_crc@cursor-128x128-suspend:
shard-apl: FAIL (fdo#103232, fdo#103191) -> PASS +1
igt@kms_cursor_crc@cursor-64x64-onscreen:
shard-apl: FAIL (fdo#103232) -> PASS +1
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
shard-apl: FAIL (fdo#103167) -> PASS +1
igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
shard-apl: FAIL (fdo#103166) -> PASS +1
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108074 https://bugs.freedesktop.org/show_bug.cgi?id=108074
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 5) ==
Missing (1): shard-glk
== Build changes ==
* Linux: CI_DRM_4915 -> Patchwork_10330
CI_DRM_4915: 26e7a7d954a9c28b97af8ca7813f430fd9117232 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4660: d0975646c50568e66e65b44b81d28232d059b94e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10330: 720c2874d3153afc44a0bc82f960ad571ab2b6ce @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10330/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: ✗ Fi.CI.IGT: failure for drm: Fix kernel doc for DRM_MODE_PROP_IMMUTABLE
2018-10-03 8:38 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2018-10-03 9:54 ` Martin Peres
0 siblings, 0 replies; 6+ messages in thread
From: Martin Peres @ 2018-10-03 9:54 UTC (permalink / raw)
To: intel-gfx, Patchwork, Manasi Navare
On 03/10/2018 11:38, Patchwork wrote:
> == Series Details ==
>
> Series: drm: Fix kernel doc for DRM_MODE_PROP_IMMUTABLE
> URL : https://patchwork.freedesktop.org/series/50462/
> State : failure
>
> == Summary ==
>
> = CI Bug Log - changes from CI_DRM_4915_full -> Patchwork_10330_full =
>
> == Summary - FAILURE ==
>
> Serious unknown changes coming with Patchwork_10330_full absolutely need to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_10330_full, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
>
>
>
> == Possible new issues ==
>
> Here are the unknown changes that may have been introduced in Patchwork_10330_full:
>
> === IGT changes ===
>
> ==== Possible regressions ====
>
> igt@drv_selftest@mock_breadcrumbs:
> shard-skl: PASS -> INCOMPLETE
>
> igt@kms_color@pipe-a-ctm-max:
> shard-apl: PASS -> FAIL +1
Known issue: https://bugs.freedesktop.org/show_bug.cgi?id=108147
Martin
>
> {igt@kms_plane_alpha_blend@pipe-b-coverage-7efc}:
> shard-skl: NOTRUN -> FAIL
>
>
> == Known issues ==
>
> Here are the changes found in Patchwork_10330_full that come from known issues:
>
> === IGT changes ===
>
> ==== Issues hit ====
>
> igt@drv_suspend@shrink:
> shard-skl: PASS -> INCOMPLETE (fdo#106886)
>
> igt@gem_exec_await@wide-contexts:
> shard-apl: PASS -> FAIL (fdo#106680)
>
> igt@gem_exec_schedule@pi-ringfull-bsd:
> shard-skl: NOTRUN -> FAIL (fdo#103158)
>
> igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
> shard-skl: NOTRUN -> DMESG-WARN (fdo#107956)
>
> igt@kms_color@pipe-a-degamma:
> shard-apl: PASS -> FAIL (fdo#108145) +1
>
> igt@kms_cursor_crc@cursor-256x85-random:
> shard-apl: PASS -> FAIL (fdo#103232) +2
>
> igt@kms_cursor_crc@cursor-64x64-suspend:
> shard-skl: PASS -> INCOMPLETE (fdo#104108)
>
> igt@kms_flip@plain-flip-fb-recreate-interruptible:
> shard-skl: PASS -> FAIL (fdo#100368)
>
> igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
> shard-apl: PASS -> FAIL (fdo#103167) +2
>
> igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
> shard-kbl: PASS -> INCOMPLETE (fdo#103665)
>
> igt@kms_plane@plane-position-covered-pipe-a-planes:
> shard-apl: PASS -> FAIL (fdo#103166) +1
>
> igt@kms_setmode@basic:
> shard-snb: NOTRUN -> FAIL (fdo#99912)
>
>
> ==== Possible fixes ====
>
> igt@gem_ppgtt@blt-vs-render-ctxn:
> shard-kbl: INCOMPLETE (fdo#103665, fdo#106023) -> PASS
>
> igt@gem_userptr_blits@readonly-unsync:
> shard-skl: INCOMPLETE (fdo#108074) -> PASS
>
> igt@kms_busy@extended-pageflip-hang-newfb-render-b:
> shard-apl: DMESG-WARN (fdo#107956) -> PASS
>
> igt@kms_ccs@pipe-b-missing-ccs-buffer:
> shard-kbl: DMESG-WARN (fdo#105602, fdo#103558) -> PASS +14
>
> igt@kms_color@pipe-b-ctm-max:
> shard-apl: FAIL -> PASS
>
> igt@kms_cursor_crc@cursor-128x128-suspend:
> shard-apl: FAIL (fdo#103232, fdo#103191) -> PASS +1
>
> igt@kms_cursor_crc@cursor-64x64-onscreen:
> shard-apl: FAIL (fdo#103232) -> PASS +1
>
> igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
> shard-apl: FAIL (fdo#103167) -> PASS +1
>
> igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
> shard-apl: FAIL (fdo#103166) -> PASS +1
>
>
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
> fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
> fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
> fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
> fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
> fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
> fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
> fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
> fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
> fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
> fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
> fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
> fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
> fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
> fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
> fdo#108074 https://bugs.freedesktop.org/show_bug.cgi?id=108074
> fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
> fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
>
>
> == Participating hosts (6 -> 5) ==
>
> Missing (1): shard-glk
>
>
> == Build changes ==
>
> * Linux: CI_DRM_4915 -> Patchwork_10330
>
> CI_DRM_4915: 26e7a7d954a9c28b97af8ca7813f430fd9117232 @ git://anongit.freedesktop.org/gfx-ci/linux
> IGT_4660: d0975646c50568e66e65b44b81d28232d059b94e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_10330: 720c2874d3153afc44a0bc82f960ad571ab2b6ce @ git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10330/shards.html
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: Fix kernel doc for DRM_MODE_PROP_IMMUTABLE
2018-10-02 21:50 [PATCH] drm: Fix kernel doc for DRM_MODE_PROP_IMMUTABLE Manasi Navare
2018-10-02 22:17 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-10-03 8:38 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2018-10-03 19:32 ` Daniel Vetter
2018-10-09 19:27 ` Manasi Navare
2 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2018-10-03 19:32 UTC (permalink / raw)
To: Manasi Navare; +Cc: Daniel Vetter, intel-gfx, dri-devel
On Tue, Oct 02, 2018 at 02:50:55PM -0700, Manasi Navare wrote:
> This patch explains the DRM_MODE_PROP_IMMUTABLE flag a bit better
> by telling which function to call if kernel wants to update
> drm object's immutable properties.
>
> Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> include/drm/drm_property.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_property.h b/include/drm/drm_property.h
> index 5b9efff35d6d..4a0a80d658c7 100644
> --- a/include/drm/drm_property.h
> +++ b/include/drm/drm_property.h
> @@ -153,7 +153,8 @@ struct drm_property {
> * userspace. The kernel is allowed to update the value of these
> * properties. This is generally used to expose probe state to
> * userspace, e.g. the EDID, or the connector path property on DP
> - * MST sinks.
> + * MST sinks. Kernel can update the value of an immutable property
> + * by calling drm_object_property_set_value().
> */
> uint32_t flags;
>
> --
> 2.18.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm: Fix kernel doc for DRM_MODE_PROP_IMMUTABLE
2018-10-03 19:32 ` [PATCH] " Daniel Vetter
@ 2018-10-09 19:27 ` Manasi Navare
0 siblings, 0 replies; 6+ messages in thread
From: Manasi Navare @ 2018-10-09 19:27 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, intel-gfx, dri-devel
Thanks for the review.
Pushed to drm-misc.
Manasi
On Wed, Oct 03, 2018 at 09:32:49PM +0200, Daniel Vetter wrote:
> On Tue, Oct 02, 2018 at 02:50:55PM -0700, Manasi Navare wrote:
> > This patch explains the DRM_MODE_PROP_IMMUTABLE flag a bit better
> > by telling which function to call if kernel wants to update
> > drm object's immutable properties.
> >
> > Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> > ---
> > include/drm/drm_property.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/drm/drm_property.h b/include/drm/drm_property.h
> > index 5b9efff35d6d..4a0a80d658c7 100644
> > --- a/include/drm/drm_property.h
> > +++ b/include/drm/drm_property.h
> > @@ -153,7 +153,8 @@ struct drm_property {
> > * userspace. The kernel is allowed to update the value of these
> > * properties. This is generally used to expose probe state to
> > * userspace, e.g. the EDID, or the connector path property on DP
> > - * MST sinks.
> > + * MST sinks. Kernel can update the value of an immutable property
> > + * by calling drm_object_property_set_value().
> > */
> > uint32_t flags;
> >
> > --
> > 2.18.0
> >
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-09 19:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-02 21:50 [PATCH] drm: Fix kernel doc for DRM_MODE_PROP_IMMUTABLE Manasi Navare
2018-10-02 22:17 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-10-03 8:38 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-10-03 9:54 ` Martin Peres
2018-10-03 19:32 ` [PATCH] " Daniel Vetter
2018-10-09 19:27 ` Manasi Navare
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.