From: Emil Renner Berthing <kernel@esmil.dk>
To: linux-rockchip@lists.infradead.org
Cc: Emil Renner Berthing <kernel@esmil.dk>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Heiko Stuebner <heiko@sntech.de>, Mark Brown <broonie@kernel.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Brian Norris <briannorris@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Shunqian Zheng <zhengsq@rock-chips.com>,
Nickey Yang <nickey.yang@rock-chips.com>,
Klaus Goger <klaus.goger@theobroma-systems.com>,
Randy Li <ayaka@soulik.info>, Chris Zhong <zyw@rock-chips.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: [PATCH 5/7] spi: rockchip: mark use_dma as bool
Date: Wed, 10 Oct 2018 11:00:36 +0200 [thread overview]
Message-ID: <20181010090038.20834-6-kernel@esmil.dk> (raw)
In-Reply-To: <20181010090038.20834-1-kernel@esmil.dk>
The driver data has a u32 field use_dma which is
only ever used as a boolean, so change its type
to reflect that.
Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
---
drivers/spi/spi-rockchip.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index 85358f96f78f..1d8bf45304a5 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -202,7 +202,7 @@ struct rockchip_spi {
bool cs_asserted[ROCKCHIP_SPI_MAX_CS_NUM];
- u32 use_dma;
+ bool use_dma;
struct sg_table tx_sg;
struct sg_table rx_sg;
struct rockchip_spi_dma_data dma_rx;
@@ -631,9 +631,9 @@ static int rockchip_spi_transfer_one(
/* we need prepare dma before spi was enabled */
if (master->can_dma && master->can_dma(master, spi, xfer))
- rs->use_dma = 1;
+ rs->use_dma = true;
else
- rs->use_dma = 0;
+ rs->use_dma = false;
rockchip_spi_config(rs);
--
2.19.1
WARNING: multiple messages have this Message-ID (diff)
From: kernel@esmil.dk (Emil Renner Berthing)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/7] spi: rockchip: mark use_dma as bool
Date: Wed, 10 Oct 2018 11:00:36 +0200 [thread overview]
Message-ID: <20181010090038.20834-6-kernel@esmil.dk> (raw)
In-Reply-To: <20181010090038.20834-1-kernel@esmil.dk>
The driver data has a u32 field use_dma which is
only ever used as a boolean, so change its type
to reflect that.
Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
---
drivers/spi/spi-rockchip.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index 85358f96f78f..1d8bf45304a5 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -202,7 +202,7 @@ struct rockchip_spi {
bool cs_asserted[ROCKCHIP_SPI_MAX_CS_NUM];
- u32 use_dma;
+ bool use_dma;
struct sg_table tx_sg;
struct sg_table rx_sg;
struct rockchip_spi_dma_data dma_rx;
@@ -631,9 +631,9 @@ static int rockchip_spi_transfer_one(
/* we need prepare dma before spi was enabled */
if (master->can_dma && master->can_dma(master, spi, xfer))
- rs->use_dma = 1;
+ rs->use_dma = true;
else
- rs->use_dma = 0;
+ rs->use_dma = false;
rockchip_spi_config(rs);
--
2.19.1
next prev parent reply other threads:[~2018-10-10 9:00 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 9:00 [PATCH 0/7] Enable spi dma on Rockchip RK3399 Emil Renner Berthing
2018-10-10 9:00 ` Emil Renner Berthing
2018-10-10 9:00 ` [PATCH 1/7] spi: rockchip: initialize dma_slave_config properly Emil Renner Berthing
2018-10-10 9:00 ` Emil Renner Berthing
2018-10-11 14:56 ` Applied "spi: rockchip: initialize dma_slave_config properly" to the spi tree Mark Brown
2018-10-11 14:56 ` Mark Brown
2018-10-11 14:56 ` Mark Brown
2018-10-11 14:56 ` Mark Brown
2018-10-11 14:56 ` Mark Brown
2018-10-10 9:00 ` [PATCH 2/7] spi: rockchip: adjust dma watermark and burstlen Emil Renner Berthing
2018-10-10 9:00 ` Emil Renner Berthing
2018-10-11 14:56 ` Applied "spi: rockchip: adjust dma watermark and burstlen" to the spi tree Mark Brown
2018-10-11 14:56 ` Mark Brown
2018-10-11 14:56 ` Mark Brown
2018-10-11 14:56 ` Mark Brown
2018-10-11 14:56 ` Mark Brown
2018-10-10 9:00 ` [PATCH 3/7] arm64: dts: rockchip: add rk3399 SPI DMAs Emil Renner Berthing
2018-10-10 9:00 ` Emil Renner Berthing
2018-10-12 9:16 ` Enric Balletbo Serra
2018-10-16 12:32 ` Heiko Stuebner
2018-10-16 12:32 ` Heiko Stuebner
2018-10-10 9:00 ` [PATCH 4/7] spi: rockchip: remove unneeded dma_caps Emil Renner Berthing
2018-10-10 9:00 ` Emil Renner Berthing
2018-10-11 14:56 ` Applied "spi: rockchip: remove unneeded dma_caps" to the spi tree Mark Brown
2018-10-11 14:56 ` Mark Brown
2018-10-11 14:56 ` Mark Brown
2018-10-11 14:56 ` Mark Brown
2018-10-11 14:56 ` Mark Brown
2018-10-10 9:00 ` Emil Renner Berthing [this message]
2018-10-10 9:00 ` [PATCH 5/7] spi: rockchip: mark use_dma as bool Emil Renner Berthing
2018-10-11 14:56 ` Applied "spi: rockchip: mark use_dma as bool" to the spi tree Mark Brown
2018-10-11 14:56 ` Mark Brown
2018-10-11 14:56 ` Mark Brown
2018-10-11 14:56 ` Mark Brown
2018-10-11 14:56 ` Mark Brown
2018-10-10 9:00 ` [PATCH 6/7] spi: rockchip: directly use direction constants Emil Renner Berthing
2018-10-10 9:00 ` Emil Renner Berthing
2018-10-11 14:55 ` Applied "spi: rockchip: directly use direction constants" to the spi tree Mark Brown
2018-10-11 14:55 ` Mark Brown
2018-10-11 14:55 ` Mark Brown
2018-10-11 14:55 ` Mark Brown
2018-10-11 14:55 ` Mark Brown
2018-10-10 9:00 ` [PATCH 7/7] spi: rockchip: simplify spi enable logic Emil Renner Berthing
2018-10-10 9:00 ` Emil Renner Berthing
2018-10-11 14:55 ` Applied "spi: rockchip: simplify spi enable logic" to the spi tree Mark Brown
2018-10-11 14:55 ` Mark Brown
2018-10-11 14:55 ` Mark Brown
2018-10-11 14:55 ` Mark Brown
2018-10-11 14:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010090038.20834-6-kernel@esmil.dk \
--to=kernel@esmil.dk \
--cc=ayaka@soulik.info \
--cc=briannorris@chromium.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=heiko@sntech.de \
--cc=klaus.goger@theobroma-systems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nickey.yang@rock-chips.com \
--cc=robh+dt@kernel.org \
--cc=zhengsq@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.