From: Cornelia Huck <cohuck@redhat.com>
To: Halil Pasic <pasic@linux.ibm.com>
Cc: Tony Krowiak <akrowiak@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, peter.maydell@linaro.org,
david@redhat.com, pmorel@linux.vnet.ibm.com,
fiuczy@linux.ibm.com, eskultet@redhat.com, agraf@suse.de,
borntraeger@de.ibm.com, jjherne@linux.vnet.ibm.com,
mimu@linux.ibm.com, Tony Krowiak <akrowiak@linux.ibm.com>,
heiko.carstens@de.ibm.com, eric.auger@redhat.com,
alex.williamson@redhat.com, bjsdjshi@linux.vnet.ibm.com,
rth@twiddle.net, mjrosato@linux.vnet.ibm.com,
pasic@linux.vnet.ibm.com, berrange@redhat.com,
alifm@linux.vnet.ibm.com, qemu-s390x@nongnu.org,
schwidefsky@de.ibm.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v10 3/6] s390x/kvm: enable AP instruction interpretation for guest
Date: Wed, 10 Oct 2018 13:53:42 +0200 [thread overview]
Message-ID: <20181010135342.28e756d6.cohuck@redhat.com> (raw)
In-Reply-To: <1bad0d3d-4c6e-4330-b0f1-90a411edb27f@linux.ibm.com>
On Wed, 10 Oct 2018 13:38:51 +0200
Halil Pasic <pasic@linux.ibm.com> wrote:
> On 10/09/2018 07:52 PM, Tony Krowiak wrote:
> > +static void kvm_s390_configure_apie(bool interpret)
> > +{
> > + uint64_t attr = interpret ? KVM_S390_VM_CRYPTO_ENABLE_APIE :
> > + KVM_S390_VM_CRYPTO_DISABLE_APIE;
> > +
> > + if (kvm_vm_check_attr(kvm_state, KVM_S390_VM_CRYPTO, attr)) {
>
> Not sure this check is necessary, and that the behavior if it fails
> is intuitive, but whatever.
It's not an uncommon pattern, and this is not a call where performance
matters, so it's fine with me.
>
> > + kvm_s390_set_attr(attr);
> > + }
> > +}
> > +
next prev parent reply other threads:[~2018-10-10 11:54 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 17:52 [Qemu-devel] [PATCH v10 0/6] s390x: vfio-ap: guest dedicated crypto adapters Tony Krowiak
2018-10-09 17:52 ` [Qemu-devel] [PATCH v10 1/6] linux-headers: linux header updates for AP support Tony Krowiak
2018-10-10 8:01 ` Cornelia Huck
2018-10-09 17:52 ` [Qemu-devel] [PATCH v10 2/6] s390x/cpumodel: Set up CPU model for AP device support Tony Krowiak
2018-10-09 19:14 ` Christian Borntraeger
2018-10-09 19:48 ` David Hildenbrand
2018-10-10 13:50 ` Tony Krowiak
2018-10-10 8:11 ` Cornelia Huck
2018-10-10 8:12 ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
2018-10-10 11:31 ` [Qemu-devel] " Halil Pasic
2018-10-09 17:52 ` [Qemu-devel] [PATCH v10 3/6] s390x/kvm: enable AP instruction interpretation for guest Tony Krowiak
2018-10-09 19:48 ` David Hildenbrand
2018-10-10 7:19 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-10-10 8:12 ` Christian Borntraeger
2018-10-10 11:38 ` Halil Pasic
2018-10-10 11:53 ` Cornelia Huck [this message]
2018-10-09 17:52 ` [Qemu-devel] [PATCH v10 4/6] s390x/ap: base Adjunct Processor (AP) object model Tony Krowiak
2018-10-10 7:28 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-10-10 8:14 ` [Qemu-devel] " Cornelia Huck
2018-10-10 13:59 ` Tony Krowiak
2018-10-10 14:16 ` Cornelia Huck
2018-10-10 11:45 ` [Qemu-devel] [qemu-s390x] " Halil Pasic
2018-10-09 17:52 ` [Qemu-devel] [PATCH v10 5/6] s390x/vfio: ap: Introduce VFIO AP device Tony Krowiak
2018-10-09 19:51 ` David Hildenbrand
2018-10-10 7:29 ` Pierre Morel
2018-10-10 7:55 ` Cornelia Huck
2018-10-10 14:04 ` Tony Krowiak
2018-10-10 8:25 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-10-10 8:52 ` Cornelia Huck
2018-10-10 14:13 ` Tony Krowiak
2018-10-10 14:12 ` Tony Krowiak
2018-10-10 9:21 ` [Qemu-devel] " Cornelia Huck
2018-10-10 15:49 ` Tony Krowiak
2018-10-10 11:52 ` Halil Pasic
2018-10-10 12:33 ` Pierre Morel
2018-10-10 12:37 ` Pierre Morel
2018-10-10 12:49 ` Christian Borntraeger
2018-10-10 14:20 ` Tony Krowiak
2018-10-09 17:52 ` [Qemu-devel] [PATCH v10 6/6] s390: doc: detailed specifications for AP virtualization Tony Krowiak
2018-10-10 8:14 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-10-10 14:23 ` Tony Krowiak
2018-10-10 9:23 ` [Qemu-devel] " Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010135342.28e756d6.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=akrowiak@linux.ibm.com \
--cc=akrowiak@linux.vnet.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=alifm@linux.vnet.ibm.com \
--cc=berrange@redhat.com \
--cc=bjsdjshi@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=eric.auger@redhat.com \
--cc=eskultet@redhat.com \
--cc=fiuczy@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=mimu@linux.ibm.com \
--cc=mjrosato@linux.vnet.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pmorel@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.