* [PATCH] staging: vboxvideo: unlock on error in vbox_cursor_atomic_update()
@ 2018-10-11 7:59 Dan Carpenter
2018-10-11 8:53 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2018-10-11 7:59 UTC (permalink / raw)
To: kernel-janitors
We need to unlock before returning on this error path.
Fixes: 35f3288c453e ("staging: vboxvideo: Atomic phase 1: convert cursor to universal plane")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c
index 042e4f384df9..78a9c9b13ff6 100644
--- a/drivers/staging/vboxvideo/vbox_mode.c
+++ b/drivers/staging/vboxvideo/vbox_mode.c
@@ -424,6 +424,7 @@ static void vbox_cursor_atomic_update(struct drm_plane *plane,
/* pinning is done in prepare/cleanup framebuffer */
src = vbox_bo_kmap(bo);
if (IS_ERR(src)) {
+ mutex_unlock(&vbox->hw_mutex);
DRM_WARN("Could not kmap cursor bo, skipping update\n");
return;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: vboxvideo: unlock on error in vbox_cursor_atomic_update()
2018-10-11 7:59 [PATCH] staging: vboxvideo: unlock on error in vbox_cursor_atomic_update() Dan Carpenter
@ 2018-10-11 8:53 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2018-10-11 8:53 UTC (permalink / raw)
To: kernel-janitors
Hi,
On 11-10-18 09:59, Dan Carpenter wrote:
> We need to unlock before returning on this error path.
>
> Fixes: 35f3288c453e ("staging: vboxvideo: Atomic phase 1: convert cursor to universal plane")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, the kbuild test robot had already notified me about this
but I did not get around to fixing it yet.
Fix looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
>
> diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c
> index 042e4f384df9..78a9c9b13ff6 100644
> --- a/drivers/staging/vboxvideo/vbox_mode.c
> +++ b/drivers/staging/vboxvideo/vbox_mode.c
> @@ -424,6 +424,7 @@ static void vbox_cursor_atomic_update(struct drm_plane *plane,
> /* pinning is done in prepare/cleanup framebuffer */
> src = vbox_bo_kmap(bo);
> if (IS_ERR(src)) {
> + mutex_unlock(&vbox->hw_mutex);
> DRM_WARN("Could not kmap cursor bo, skipping update\n");
> return;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-11 8:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-11 7:59 [PATCH] staging: vboxvideo: unlock on error in vbox_cursor_atomic_update() Dan Carpenter
2018-10-11 8:53 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.