All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [PATCH 08/12] xenstore.h: Put ( ) around XS_* define shifts
Date: Fri, 12 Oct 2018 16:12:11 +0100	[thread overview]
Message-ID: <20181012151215.32455-9-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <20181012151215.32455-1-ian.jackson@eu.citrix.com>

These definitions were not properly protected from unwanted operator
precedence interactions.

Existing use sites in-tree all use & or |, so this does not change any
actual behaviour in-tree.

The same seems likely to be true in external callers.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
v2: New in this version of the series
---
 tools/xenstore/include/xenstore.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/xenstore/include/xenstore.h b/tools/xenstore/include/xenstore.h
index 0d95bb0e5c..996b75ab0d 100644
--- a/tools/xenstore/include/xenstore.h
+++ b/tools/xenstore/include/xenstore.h
@@ -23,8 +23,8 @@
 
 #define XBT_NULL 0
 
-#define XS_OPEN_READONLY	1UL<<0
-#define XS_OPEN_SOCKETONLY      1UL<<1
+#define XS_OPEN_READONLY	(1UL<<0)
+#define XS_OPEN_SOCKETONLY      (1UL<<1)
 
 /*
  * Setting XS_UNWATCH_FILTER arranges that after xs_unwatch, no
@@ -45,7 +45,7 @@
  *                                  xs_unwatch for the first watch
  *                                  has returned.
  */
-#define XS_UNWATCH_FILTER     1UL<<2
+#define XS_UNWATCH_FILTER     (1UL<<2)
 
 struct xs_handle;
 typedef uint32_t xs_transaction_t;
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2018-10-12 15:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-12 15:12 [PATCH v2 00/12] Miscellaneous fixes from Debian Ian Jackson
2018-10-12 15:12 ` [PATCH 01/12] tools/Rules.mk: Honour PREPEND_LDFLAGS_XEN_TOOLS Ian Jackson
2018-10-12 15:38   ` Wei Liu
2018-10-12 15:12 ` [PATCH 02/12] INSTALL: Mention kconfig Ian Jackson
2018-10-12 15:12 ` [PATCH 03/12] gdbsx: Honour LDFLAGS when linking Ian Jackson
2018-10-12 15:38   ` Wei Liu
2018-10-12 17:15   ` Elena Ufimtseva
2018-10-12 15:12 ` [PATCH 04/12] pygrub fsimage.so: Honour LDFLAGS when building Ian Jackson
2018-10-12 15:38   ` Wei Liu
2018-10-12 15:12 ` [PATCH 05/12] xenmon: Install as xenmon, not xenmon.py Ian Jackson
2018-10-12 15:12 ` [PATCH 06/12] tools/debugger/kdd: Install as `xen-kdd', not just `kdd' Ian Jackson
2018-10-12 15:12 ` [PATCH 07/12] tools/xenstore: Re-introduce (fake) xs_restrict call to preserve ABI Ian Jackson
2018-10-12 15:38   ` Wei Liu
2018-10-12 21:47   ` Hans van Kranenburg
2018-10-15 13:47     ` Ian Jackson
2018-10-12 15:12 ` Ian Jackson [this message]
2018-10-12 15:38   ` [PATCH 08/12] xenstore.h: Put ( ) around XS_* define shifts Wei Liu
2018-10-12 15:12 ` [PATCH 09/12] tools/libfsimage: Bump soname to 4.12 Ian Jackson
2018-10-12 15:35   ` Wei Liu
2018-10-12 15:12 ` [PATCH 10/12] tools/libfsimage: Add `xen' to .h names and principal .so name Ian Jackson
2018-10-12 15:38   ` Wei Liu
2018-10-12 16:34     ` Ian Jackson
2018-10-12 15:12 ` [PATCH 11/12] tools/pygrub: Add `xen' to fsimage python module name Ian Jackson
2018-10-12 15:39   ` Wei Liu
2018-10-12 15:12 ` [PATCH 12/12] tools/libfsimage: Rename /usr/lib/fs to /usr/lib/xenfsimage Ian Jackson
2018-10-12 15:40   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181012151215.32455-9-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.