All of lore.kernel.org
 help / color / mirror / Atom feed
From: Elena Ufimtseva <elena.ufimtseva@oracle.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>,
	Ian Jackson <ian.jackson@citrix.com>
Subject: Re: [PATCH 03/12] gdbsx: Honour LDFLAGS when linking
Date: Fri, 12 Oct 2018 10:15:23 -0700	[thread overview]
Message-ID: <20181012171523.GA6800@localhost.localdomain> (raw)
In-Reply-To: <20181012151215.32455-4-ian.jackson@eu.citrix.com>

On Fri, Oct 12, 2018 at 04:12:06PM +0100, Ian Jackson wrote:
> From: Ian Jackson <ian.jackson@citrix.com>
> 
> This command does the link, so it needs LDFLAGS.
> 
> Signed-off-by: Ian Jackson <ian.jackson@citrix.com>

Acked-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>

> ---
>  tools/debugger/gdbsx/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/debugger/gdbsx/Makefile b/tools/debugger/gdbsx/Makefile
> index 723a2743cc..8d7cd94a31 100644
> --- a/tools/debugger/gdbsx/Makefile
> +++ b/tools/debugger/gdbsx/Makefile
> @@ -26,7 +26,7 @@ uninstall:
>  	rm -f $(DESTDIR)$(sbindir)/gdbsx
>  
>  gdbsx: gx/gx_all.a xg/xg_all.a 
> -	$(CC) -o $@ $^
> +	$(CC) $(LDFLAGS) -o $@ $^
>  
>  xg/xg_all.a:
>  	$(MAKE) -C xg
> -- 
> 2.11.0
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2018-10-12 17:15 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-12 15:12 [PATCH v2 00/12] Miscellaneous fixes from Debian Ian Jackson
2018-10-12 15:12 ` [PATCH 01/12] tools/Rules.mk: Honour PREPEND_LDFLAGS_XEN_TOOLS Ian Jackson
2018-10-12 15:38   ` Wei Liu
2018-10-12 15:12 ` [PATCH 02/12] INSTALL: Mention kconfig Ian Jackson
2018-10-12 15:12 ` [PATCH 03/12] gdbsx: Honour LDFLAGS when linking Ian Jackson
2018-10-12 15:38   ` Wei Liu
2018-10-12 17:15   ` Elena Ufimtseva [this message]
2018-10-12 15:12 ` [PATCH 04/12] pygrub fsimage.so: Honour LDFLAGS when building Ian Jackson
2018-10-12 15:38   ` Wei Liu
2018-10-12 15:12 ` [PATCH 05/12] xenmon: Install as xenmon, not xenmon.py Ian Jackson
2018-10-12 15:12 ` [PATCH 06/12] tools/debugger/kdd: Install as `xen-kdd', not just `kdd' Ian Jackson
2018-10-12 15:12 ` [PATCH 07/12] tools/xenstore: Re-introduce (fake) xs_restrict call to preserve ABI Ian Jackson
2018-10-12 15:38   ` Wei Liu
2018-10-12 21:47   ` Hans van Kranenburg
2018-10-15 13:47     ` Ian Jackson
2018-10-12 15:12 ` [PATCH 08/12] xenstore.h: Put ( ) around XS_* define shifts Ian Jackson
2018-10-12 15:38   ` Wei Liu
2018-10-12 15:12 ` [PATCH 09/12] tools/libfsimage: Bump soname to 4.12 Ian Jackson
2018-10-12 15:35   ` Wei Liu
2018-10-12 15:12 ` [PATCH 10/12] tools/libfsimage: Add `xen' to .h names and principal .so name Ian Jackson
2018-10-12 15:38   ` Wei Liu
2018-10-12 16:34     ` Ian Jackson
2018-10-12 15:12 ` [PATCH 11/12] tools/pygrub: Add `xen' to fsimage python module name Ian Jackson
2018-10-12 15:39   ` Wei Liu
2018-10-12 15:12 ` [PATCH 12/12] tools/libfsimage: Rename /usr/lib/fs to /usr/lib/xenfsimage Ian Jackson
2018-10-12 15:40   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181012171523.GA6800@localhost.localdomain \
    --to=elena.ufimtseva@oracle.com \
    --cc=ian.jackson@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.