All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Richard Weinberger <richard@nod.at>,
	Marek Vasut <marek.vasut@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-mtd@lists.infradead.org, Kumar Gala <galak@codeaurora.org>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 12/14] mtd: maps: Merge gpio-addr-flash.c into physmap-core.c
Date: Sun, 14 Oct 2018 09:06:06 +0200	[thread overview]
Message-ID: <20181014090606.12c9baac@bbrezillon> (raw)
In-Reply-To: <20181009091106.7f25a314@bbrezillon>

On Tue, 9 Oct 2018 09:11:06 +0200
Boris Brezillon <boris.brezillon@bootlin.com> wrote:

> On Tue, 9 Oct 2018 09:04:51 +0200
> Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> wrote:
> 
> > Hi Boris
> > 
> > Maybe we want to leave the pdata example.
> > 
> > /**
> >  * The platform resource layout expected looks something like:
> >  * struct mtd_partition partitions[] = { ... };
> >  * struct physmap_flash_data flash_data =
> > .....  
> 
> Sure, I'll add it back.

Actually I changed my mind on that one. The physmap driver did not
document that in the first place, so, if we want to add this example,
we should do it in a separate patch, and maybe place it next to the
physmap_flash_data struct definition. This being said, I don't see a
lot of drivers documenting this sort of things and I doubt new
platforms will use pdata to describe their device anyway.

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Richard Weinberger <richard@nod.at>,
	Marek Vasut <marek.vasut@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-mtd@lists.infradead.org, Kumar Gala <galak@codeaurora.org>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 12/14] mtd: maps: Merge gpio-addr-flash.c into physmap-core.c
Date: Sun, 14 Oct 2018 09:06:06 +0200	[thread overview]
Message-ID: <20181014090606.12c9baac@bbrezillon> (raw)
In-Reply-To: <20181009091106.7f25a314@bbrezillon>

On Tue, 9 Oct 2018 09:11:06 +0200
Boris Brezillon <boris.brezillon@bootlin.com> wrote:

> On Tue, 9 Oct 2018 09:04:51 +0200
> Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> wrote:
> 
> > Hi Boris
> > 
> > Maybe we want to leave the pdata example.
> > 
> > /**
> >  * The platform resource layout expected looks something like:
> >  * struct mtd_partition partitions[] = { ... };
> >  * struct physmap_flash_data flash_data =
> > .....  
> 
> Sure, I'll add it back.

Actually I changed my mind on that one. The physmap driver did not
document that in the first place, so, if we want to add this example,
we should do it in a separate patch, and maybe place it next to the
physmap_flash_data struct definition. This being said, I don't see a
lot of drivers documenting this sort of things and I doubt new
platforms will use pdata to describe their device anyway.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2018-10-14  7:06 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 20:10 [PATCH 00/14] mtd: maps: physmap cleanups Boris Brezillon
2018-10-08 20:10 ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 01/14] mtd: maps: physmap: Add SPDX header Boris Brezillon
2018-10-08 20:10   ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 02/14] mtd: maps: physmap: Rename ->map and ->mtd into ->maps and ->mtds Boris Brezillon
2018-10-08 20:10   ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 03/14] mtd: maps: physmap: Use platform_get_resource() to retrieve iomem resources Boris Brezillon
2018-10-08 20:10   ` Boris Brezillon
2018-10-09  7:16   ` Ricardo Ribalda Delgado
2018-10-09  7:16     ` Ricardo Ribalda Delgado
2018-10-09  7:54     ` Boris Brezillon
2018-10-09  7:54       ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 04/14] mtd: maps: physmap: Use dev_notice() and a %pR specifier Boris Brezillon
2018-10-08 20:10   ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 05/14] mtd: maps: physmap: Use devm_ioremap_resource() Boris Brezillon
2018-10-08 20:10   ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 06/14] mtd: maps: physmap: Remove the MAX_RESOURCES limitation Boris Brezillon
2018-10-08 20:10   ` Boris Brezillon
2018-10-09  7:31   ` Ricardo Ribalda Delgado
2018-10-09  7:31     ` Ricardo Ribalda Delgado
2018-10-09  7:53     ` Boris Brezillon
2018-10-09  7:53       ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 07/14] mtd: maps: physmap: Check mtd_device_{parse_register, unregister}() ret code Boris Brezillon
2018-10-08 20:10   ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 08/14] mtd: maps: physmap: Return -ENOMEM directly when info allocation fails Boris Brezillon
2018-10-08 20:10   ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 09/14] mtd: maps: physmap: Fix coding style issues reported by checkpatch Boris Brezillon
2018-10-08 20:10   ` Boris Brezillon
2018-10-09  7:37   ` Ricardo Ribalda Delgado
2018-10-09  7:37     ` Ricardo Ribalda Delgado
2018-10-09  7:52     ` Boris Brezillon
2018-10-09  7:52       ` Boris Brezillon
2018-10-14  7:26       ` Boris Brezillon
2018-10-14  7:26         ` Boris Brezillon
2018-10-15  8:52         ` [PATCH] mtd: maps: code style: Invert logic on if/else branch Ricardo Ribalda Delgado
2018-10-08 20:10 ` [PATCH 10/14] mtd: maps: Prepare merging of physmap and physmap_of Boris Brezillon
2018-10-08 20:10   ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 11/14] mtd: maps: Merge physmap_of.c into physmap-core.c Boris Brezillon
2018-10-08 20:10   ` Boris Brezillon
2018-10-09  6:58   ` Ricardo Ribalda Delgado
2018-10-09  6:58     ` Ricardo Ribalda Delgado
2018-10-09  7:06     ` Boris Brezillon
2018-10-09  7:06       ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 12/14] mtd: maps: Merge gpio-addr-flash.c " Boris Brezillon
2018-10-08 20:10   ` Boris Brezillon
2018-10-09  7:04   ` Ricardo Ribalda Delgado
2018-10-09  7:04     ` Ricardo Ribalda Delgado
2018-10-09  7:11     ` Boris Brezillon
2018-10-09  7:11       ` Boris Brezillon
2018-10-14  7:06       ` Boris Brezillon [this message]
2018-10-14  7:06         ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 13/14] mtd: maps: Rename physmap_of_{versatile, gemini} into physmap-{versatile, gemini} Boris Brezillon
2018-10-08 20:10   ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 14/14] dt-binding: mtd: physmap: Document the addr-gpios property Boris Brezillon
2018-10-08 20:10   ` Boris Brezillon
2018-10-09  7:43   ` Ricardo Ribalda Delgado
2018-10-09  7:43     ` Ricardo Ribalda Delgado
2018-10-09  7:56     ` Boris Brezillon
2018-10-09  7:56       ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181014090606.12c9baac@bbrezillon \
    --to=boris.brezillon@bootlin.com \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=ricardo.ribalda@gmail.com \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.