* [PATCH] drm/i915: Hold rpm wakeref for debugfs/i915_drop_caches_set
@ 2018-10-15 11:58 Chris Wilson
2018-10-15 13:22 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Chris Wilson @ 2018-10-15 11:58 UTC (permalink / raw)
To: intel-gfx
Since we peek into HW state and poke around, it behoves us to acquire a
runtime pm wakeref beforehand.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108364
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i915_debugfs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 7b7f844d325b..80dec5740de0 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -4187,6 +4187,7 @@ i915_drop_caches_set(void *data, u64 val)
DRM_DEBUG("Dropping caches: 0x%08llx [0x%08llx]\n",
val, val & DROP_ALL);
+ intel_runtime_pm_get(i915);
if (val & DROP_RESET_ACTIVE && !intel_engines_are_idle(i915))
i915_gem_set_wedged(i915);
@@ -4246,6 +4247,8 @@ i915_drop_caches_set(void *data, u64 val)
if (val & DROP_FREED)
i915_gem_drain_freed_objects(i915);
+ intel_runtime_pm_put(i915);
+
return ret;
}
--
2.19.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Hold rpm wakeref for debugfs/i915_drop_caches_set
2018-10-15 11:58 [PATCH] drm/i915: Hold rpm wakeref for debugfs/i915_drop_caches_set Chris Wilson
@ 2018-10-15 13:22 ` Patchwork
2018-10-15 14:01 ` [PATCH] " Ville Syrjälä
2018-10-15 17:09 ` ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-10-15 13:22 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Hold rpm wakeref for debugfs/i915_drop_caches_set
URL : https://patchwork.freedesktop.org/series/51001/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4980 -> Patchwork_10457 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/51001/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_10457 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-reload:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106248, fdo#106725)
igt@gem_exec_suspend@basic-s3:
fi-icl-u: PASS -> INCOMPLETE (fdo#107713)
igt@gem_exec_suspend@basic-s4-devices:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
fi-byt-clapper: PASS -> FAIL (fdo#103191, fdo#107362)
==== Possible fixes ====
igt@drv_selftest@live_evict:
fi-bsw-kefka: DMESG-WARN (fdo#107709) -> PASS
igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#103191, fdo#107362) -> PASS
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107709 https://bugs.freedesktop.org/show_bug.cgi?id=107709
fdo#107713 https://bugs.freedesktop.org/show_bug.cgi?id=107713
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
== Participating hosts (53 -> 48) ==
Additional (1): fi-kbl-8809g
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-kbl-7560u
== Build changes ==
* Linux: CI_DRM_4980 -> Patchwork_10457
CI_DRM_4980: 0ab590190a211799af40693064ceace077dbd082 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4676: 7e7e0c4ce267c40024012079c18168d47ae78eef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10457: fd0000adf73479bf49ebf6e9c9a09cbf89a7b0e1 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
fd0000adf734 drm/i915: Hold rpm wakeref for debugfs/i915_drop_caches_set
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10457/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Hold rpm wakeref for debugfs/i915_drop_caches_set
2018-10-15 11:58 [PATCH] drm/i915: Hold rpm wakeref for debugfs/i915_drop_caches_set Chris Wilson
2018-10-15 13:22 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-10-15 14:01 ` Ville Syrjälä
2018-10-15 14:06 ` Chris Wilson
2018-10-15 17:09 ` ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Ville Syrjälä @ 2018-10-15 14:01 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Mon, Oct 15, 2018 at 12:58:56PM +0100, Chris Wilson wrote:
> Since we peek into HW state and poke around, it behoves us to acquire a
> runtime pm wakeref beforehand.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108364
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 7b7f844d325b..80dec5740de0 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -4187,6 +4187,7 @@ i915_drop_caches_set(void *data, u64 val)
>
> DRM_DEBUG("Dropping caches: 0x%08llx [0x%08llx]\n",
> val, val & DROP_ALL);
> + intel_runtime_pm_get(i915);
>
> if (val & DROP_RESET_ACTIVE && !intel_engines_are_idle(i915))
> i915_gem_set_wedged(i915);
> @@ -4246,6 +4247,8 @@ i915_drop_caches_set(void *data, u64 val)
> if (val & DROP_FREED)
> i915_gem_drain_freed_objects(i915);
>
> + intel_runtime_pm_put(i915);
> +
I see some other rpm get/put calls inside this function. Drop those?
Either way
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> return ret;
> }
>
> --
> 2.19.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Hold rpm wakeref for debugfs/i915_drop_caches_set
2018-10-15 14:01 ` [PATCH] " Ville Syrjälä
@ 2018-10-15 14:06 ` Chris Wilson
0 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2018-10-15 14:06 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
Quoting Ville Syrjälä (2018-10-15 15:01:25)
> On Mon, Oct 15, 2018 at 12:58:56PM +0100, Chris Wilson wrote:
> > Since we peek into HW state and poke around, it behoves us to acquire a
> > runtime pm wakeref beforehand.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108364
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> > drivers/gpu/drm/i915/i915_debugfs.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> > index 7b7f844d325b..80dec5740de0 100644
> > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > @@ -4187,6 +4187,7 @@ i915_drop_caches_set(void *data, u64 val)
> >
> > DRM_DEBUG("Dropping caches: 0x%08llx [0x%08llx]\n",
> > val, val & DROP_ALL);
> > + intel_runtime_pm_get(i915);
> >
> > if (val & DROP_RESET_ACTIVE && !intel_engines_are_idle(i915))
> > i915_gem_set_wedged(i915);
> > @@ -4246,6 +4247,8 @@ i915_drop_caches_set(void *data, u64 val)
> > if (val & DROP_FREED)
> > i915_gem_drain_freed_objects(i915);
> >
> > + intel_runtime_pm_put(i915);
> > +
>
> I see some other rpm get/put calls inside this function. Drop those?
Yes, they are now redundant. Thanks,
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Hold rpm wakeref for debugfs/i915_drop_caches_set
2018-10-15 11:58 [PATCH] drm/i915: Hold rpm wakeref for debugfs/i915_drop_caches_set Chris Wilson
2018-10-15 13:22 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-10-15 14:01 ` [PATCH] " Ville Syrjälä
@ 2018-10-15 17:09 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-10-15 17:09 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Hold rpm wakeref for debugfs/i915_drop_caches_set
URL : https://patchwork.freedesktop.org/series/51001/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4980_full -> Patchwork_10457_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10457_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10457_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10457_full:
=== IGT changes ===
==== Warnings ====
igt@kms_cursor_crc@cursor-128x128-rapid-movement:
shard-snb: PASS -> SKIP
igt@perf_pmu@rc6:
shard-kbl: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_10457_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_render_linear_blits@basic:
shard-kbl: PASS -> INCOMPLETE (fdo#103665)
igt@gem_softpin@noreloc-s3:
shard-snb: PASS -> DMESG-WARN (fdo#102365)
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
shard-apl: PASS -> DMESG-WARN (fdo#107956)
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
shard-skl: PASS -> DMESG-WARN (fdo#107956)
igt@kms_cursor_crc@cursor-256x256-random:
shard-apl: PASS -> FAIL (fdo#103232) +2
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
shard-glk: PASS -> FAIL (fdo#103167)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
shard-apl: PASS -> FAIL (fdo#103167)
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render:
shard-glk: PASS -> DMESG-FAIL (fdo#106538, fdo#103167)
igt@kms_frontbuffer_tracking@fbc-badstride:
shard-glk: PASS -> DMESG-WARN (fdo#106538, fdo#105763) +1
igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
shard-apl: PASS -> FAIL (fdo#103166) +1
igt@pm_rpm@dpms-lpsp:
shard-skl: PASS -> INCOMPLETE (fdo#107807) +1
==== Possible fixes ====
igt@drv_suspend@shrink:
shard-snb: INCOMPLETE (fdo#105411, fdo#106886) -> PASS
igt@gem_exec_await@wide-contexts:
shard-kbl: FAIL (fdo#106680) -> PASS
igt@kms_busy@extended-pageflip-hang-newfb-render-c:
shard-glk: DMESG-WARN (fdo#107956) -> PASS
igt@kms_cursor_crc@cursor-256x256-random:
shard-glk: FAIL (fdo#103232) -> PASS +2
igt@kms_cursor_crc@cursor-256x85-onscreen:
shard-apl: FAIL (fdo#103232) -> PASS +1
igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled:
shard-skl: FAIL (fdo#103184) -> PASS
igt@kms_flip@2x-flip-vs-expired-vblank:
shard-glk: FAIL (fdo#105363) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
shard-glk: FAIL (fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc:
shard-skl: FAIL (fdo#105682) -> PASS +1
igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-cpu:
shard-skl: FAIL (fdo#103167) -> PASS +1
igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
shard-apl: FAIL (fdo#103166) -> PASS +1
igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
shard-glk: FAIL (fdo#103166) -> PASS +1
igt@pm_rpm@gem-execbuf-stress-extra-wait:
shard-skl: INCOMPLETE (fdo#107807, fdo#107803) -> PASS
==== Warnings ====
igt@kms_cursor_crc@cursor-256x85-onscreen:
shard-glk: FAIL (fdo#103232) -> DMESG-WARN (fdo#106538, fdo#105763)
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite:
shard-glk: FAIL (fdo#103167) -> DMESG-FAIL (fdo#106538, fdo#103167)
fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105682 https://bugs.freedesktop.org/show_bug.cgi?id=105682
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#107803 https://bugs.freedesktop.org/show_bug.cgi?id=107803
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4980 -> Patchwork_10457
CI_DRM_4980: 0ab590190a211799af40693064ceace077dbd082 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4676: 7e7e0c4ce267c40024012079c18168d47ae78eef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10457: fd0000adf73479bf49ebf6e9c9a09cbf89a7b0e1 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10457/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-15 17:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-15 11:58 [PATCH] drm/i915: Hold rpm wakeref for debugfs/i915_drop_caches_set Chris Wilson
2018-10-15 13:22 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-10-15 14:01 ` [PATCH] " Ville Syrjälä
2018-10-15 14:06 ` Chris Wilson
2018-10-15 17:09 ` ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.