From: Pavel Machek <pavel@ucw.cz>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
robh+dt@kernel.org, heiko@sntech.de, ezequiel@collabora.com,
xuwei5@hisilicon.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
daniel.thompson@linaro.org, amit.kucheria@linaro.org,
linus.walleij@linaro.org, koen.kooi@linaro.org
Subject: Re: [PATCH 6/6] arm64: dts: xilinx: ultra96: Standardize LED labels and triggers
Date: Mon, 15 Oct 2018 21:56:01 +0200 [thread overview]
Message-ID: <20181015185147.GA29649@amd> (raw)
In-Reply-To: <7b94c09d-ecbd-e48e-6583-127566715a76@xilinx.com>
[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]
On Wed 2018-10-10 09:25:24, Michal Simek wrote:
> On 9.10.2018 16:05, Manivannan Sadhasivam wrote:
> > For all 96Boards, the following standard is used for onboard LEDs.
> >
> > device-name:green:user1 default-trigger: heartbeat
> > device-name:green:user2 default-trigger: mmc0/disk-activity
> > (onboard-storage)
> > device-name:green:user3 default-trigger: mmc1 (SD-card)
> > device-name:green:user4 default-trigger: none, panic-indicator
Actually, having one LED as heartbeat and second as panic indicator
only... Could those be merged and remaining LED used to something
useful?
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > index eb5e8bddb610..565ceb390f99 100644
> > --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> > +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> > @@ -57,29 +57,30 @@
> > leds {
> > compatible = "gpio-leds";
> > ds2 {
> > - label = "ds2";
> > + label = "zynqmp-zcu100-revC:green:user1";
>
> The purpose of this series should be standardize Led labels that's why I
> would expect that leds will be called in the same way on all these
> boards that's why I am not getting why there is board name.
>
> green:user1 or just user1 should be enough.
green:user1 is better. Also... I guess this should go to the LEDs
list... and if you want to make names standard, maybe there's better
naming than user1..user4?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] arm64: dts: xilinx: ultra96: Standardize LED labels and triggers
Date: Mon, 15 Oct 2018 21:56:01 +0200 [thread overview]
Message-ID: <20181015185147.GA29649@amd> (raw)
In-Reply-To: <7b94c09d-ecbd-e48e-6583-127566715a76@xilinx.com>
On Wed 2018-10-10 09:25:24, Michal Simek wrote:
> On 9.10.2018 16:05, Manivannan Sadhasivam wrote:
> > For all 96Boards, the following standard is used for onboard LEDs.
> >
> > device-name:green:user1 default-trigger: heartbeat
> > device-name:green:user2 default-trigger: mmc0/disk-activity
> > (onboard-storage)
> > device-name:green:user3 default-trigger: mmc1 (SD-card)
> > device-name:green:user4 default-trigger: none, panic-indicator
Actually, having one LED as heartbeat and second as panic indicator
only... Could those be merged and remaining LED used to something
useful?
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > index eb5e8bddb610..565ceb390f99 100644
> > --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> > +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> > @@ -57,29 +57,30 @@
> > leds {
> > compatible = "gpio-leds";
> > ds2 {
> > - label = "ds2";
> > + label = "zynqmp-zcu100-revC:green:user1";
>
> The purpose of this series should be standardize Led labels that's why I
> would expect that leds will be called in the same way on all these
> boards that's why I am not getting why there is board name.
>
> green:user1 or just user1 should be enough.
green:user1 is better. Also... I guess this should go to the LEDs
list... and if you want to make names standard, maybe there's better
naming than user1..user4?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20181015/9fc335bc/attachment.sig>
next prev parent reply other threads:[~2018-10-15 19:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 14:05 [PATCH 0/6] Standardize onboard LED support for 96Boards Manivannan Sadhasivam
2018-10-09 14:05 ` Manivannan Sadhasivam
2018-10-09 14:05 ` [PATCH 1/6] arm64: dts: rockchip: ficus: Add on-board LED support Manivannan Sadhasivam
2018-10-09 14:05 ` Manivannan Sadhasivam
2018-10-09 14:05 ` [PATCH 2/6] arm64: dts: rockchip: rock960: " Manivannan Sadhasivam
2018-10-09 14:05 ` Manivannan Sadhasivam
2018-10-09 14:05 ` [PATCH 3/6] arm64: dts: hisilicon: hikey: Standardize LED labels and triggers Manivannan Sadhasivam
2018-10-09 14:05 ` Manivannan Sadhasivam
2018-10-09 14:05 ` [PATCH 4/6] arm64: dts: hisilicon: hikey960: " Manivannan Sadhasivam
2018-10-09 14:05 ` Manivannan Sadhasivam
2018-10-09 14:05 ` [PATCH 5/6] arm64: dts: hisilicon: poplar: " Manivannan Sadhasivam
2018-10-09 14:05 ` Manivannan Sadhasivam
2018-10-09 14:05 ` [PATCH 6/6] arm64: dts: xilinx: ultra96: " Manivannan Sadhasivam
2018-10-09 14:05 ` Manivannan Sadhasivam
2018-10-10 7:25 ` Michal Simek
2018-10-10 7:25 ` Michal Simek
2018-10-10 7:25 ` Michal Simek
2018-10-10 7:35 ` Manivannan Sadhasivam
2018-10-10 7:35 ` Manivannan Sadhasivam
2018-10-10 7:40 ` Michal Simek
2018-10-10 7:40 ` Michal Simek
2018-10-10 7:40 ` Michal Simek
2018-10-10 7:46 ` Manivannan Sadhasivam
2018-10-10 7:46 ` Manivannan Sadhasivam
2018-10-15 19:56 ` Pavel Machek [this message]
2018-10-15 19:56 ` Pavel Machek
2018-10-22 6:50 ` Manivannan Sadhasivam
2018-10-22 6:50 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015185147.GA29649@amd \
--to=pavel@ucw.cz \
--cc=amit.kucheria@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=koen.kooi@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.