Re: [PATCH] opencl-headers: Initial recipe for OpenCL headers

[Denys Dmytriyenko <denis@denix.org>]

On Mon, Oct 15, 2018 at 11:19:37AM -0700, Khem Raj wrote:
> On Mon, Oct 15, 2018 at 11:14 AM Denys Dmytriyenko <denis@denix.org> wrote:
> >
> > On Mon, Oct 15, 2018 at 04:13:03PM +0530, Ankit Navik wrote:
> > > Hi Denis,
> > > On Mon, Oct 15, 2018 at 8:42 AM Denys Dmytriyenko <denis@denix.org> wrote:
> > > >
> > > > On Sun, Oct 14, 2018 at 11:29:26AM -0700, Khem Raj wrote:
> > > > > On Sat, Oct 6, 2018 at 1:49 AM Ankit Navik <ankit.tarot@gmail.com> wrote:
> > > > > >
> > > > > > Hi Armin,
> > > > > >
> > > > > > On Thu, Oct 4, 2018 at 4:40 AM akuster808 <akuster808@gmail.com> wrote:
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On 10/03/2018 08:40 AM, Ankit Navik wrote:
> > > > > > > > Add generic recipe for OpenCL API headers.
> > > > > > > >
> > > > > > > > Signed-off-by: Ankit Navik <ankit.tarot@gmail.com>
> > > > > > > > ---
> > > > > > > >  .../recipes-core/opencl-headers/opencl-headers_git.bb | 19 +++++++++++++++++++
> > > > > > > >  1 file changed, 19 insertions(+)
> > > > > > > >  create mode 100644 meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb
> > > > > > > >
> > > > > > > > diff --git a/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb
> > > > > > > > new file mode 100644
> > > > > > > > index 0000000..16bc247
> > > > > > > > --- /dev/null
> > > > > > > > +++ b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb
> > > > > > > > @@ -0,0 +1,19 @@
> > > > > > > > +SUMMARY  = "OpenCL API Headers"
> > > > > > > > +DESCRIPTION = "OpenCL compute API headers from Khronos Group"
> > > > > > > > +LICENSE  = "CLOSED"
> > > > > > > There is a license file at the repo. Would adding a "Khronos" license be
> > > > > > > more appropriate?
> > > > > > >
> > > > > > > https://github.com/KhronosGroup/OpenCL-Headers/blob/master/LICENSE
> > > > > > >
> > > > > > > - armin
> > > > > >
> > > > > > I have tried adding "Khronos", but it was throwing QA error for
> > > > > > license. Hence kept it as closed.
> > > > > > Any other suggestion for license ?
> > > > > >
> > > > >
> > > > > Please add a template for this license into meta-oe/licenses and then
> > > > > reference it in relevant recipes.
> > > > >
> > > > > > Regards, Ankit
> > > > > > >
> > > > > > > > +LIC_FILES_CHKSUM = "file://CL/opencl.h;beginline=1;endline=27;md5=687394644e8c4ec4fd3d77f2f86bc042"
> > > > > > > > +SECTION = "base"
> > > > > > > > +
> > > > > > > > +S = "${WORKDIR}/git"
> > > > > > > > +SRCREV = "40c5d226c7c0706f0176884e9b94b3886679c983"
> > > > > > > > +SRC_URI = "git://github.com/KhronosGroup/OpenCL-Headers.git"
> > > > > > > > +
> > > > > > > > +do_configure[noexec] = "1"
> > > > > > > > +do_compile[noexec] = "1"
> > > > > > > > +
> > > > > > > > +do_install () {
> > > > > > > > +     install -d ${D}${includedir}/CL/
> > > > > > > > +     for f in ${S}/CL/*.h; do
> > > > > > > > +             install -m 0644 $f ${D}${includedir}/CL/
> > > >
> > > > Single file install? Not very optimized...
> >
> > > Its not a single file, Installing all the header files.
> >
> > It's a single file install in a for loop, hence my comment about being
> > unoptimal. Why not use "cp *.h"?
> 
>  I agree its suboptimal use here. May be
> 
> install [OPTION]... -t DIRECTORY SOURCE
> 
> could be tamed to make it better.
> however cp messes the file permissions up if not used with right opts.
> So I would not prefer it unless used with right
> options to respect the file perms. Install does it correctly,

Agree, cp would require passing correct options, but there are plenty of 
examples alreay.

-- 
Denys