* [PATCH] opencl-headers: Initial recipe for OpenCL headers @ 2018-10-03 15:40 Ankit Navik 2018-10-03 23:10 ` akuster808 0 siblings, 1 reply; 13+ messages in thread From: Ankit Navik @ 2018-10-03 15:40 UTC (permalink / raw) To: openembedded-devel Add generic recipe for OpenCL API headers. Signed-off-by: Ankit Navik <ankit.tarot@gmail.com> --- .../recipes-core/opencl-headers/opencl-headers_git.bb | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb diff --git a/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb new file mode 100644 index 0000000..16bc247 --- /dev/null +++ b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb @@ -0,0 +1,19 @@ +SUMMARY = "OpenCL API Headers" +DESCRIPTION = "OpenCL compute API headers from Khronos Group" +LICENSE = "CLOSED" +LIC_FILES_CHKSUM = "file://CL/opencl.h;beginline=1;endline=27;md5=687394644e8c4ec4fd3d77f2f86bc042" +SECTION = "base" + +S = "${WORKDIR}/git" +SRCREV = "40c5d226c7c0706f0176884e9b94b3886679c983" +SRC_URI = "git://github.com/KhronosGroup/OpenCL-Headers.git" + +do_configure[noexec] = "1" +do_compile[noexec] = "1" + +do_install () { + install -d ${D}${includedir}/CL/ + for f in ${S}/CL/*.h; do + install -m 0644 $f ${D}${includedir}/CL/ + done +} -- 1.9.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] opencl-headers: Initial recipe for OpenCL headers 2018-10-03 15:40 [PATCH] opencl-headers: Initial recipe for OpenCL headers Ankit Navik @ 2018-10-03 23:10 ` akuster808 2018-10-06 8:49 ` Ankit Navik 0 siblings, 1 reply; 13+ messages in thread From: akuster808 @ 2018-10-03 23:10 UTC (permalink / raw) To: Ankit Navik, openembedded-devel On 10/03/2018 08:40 AM, Ankit Navik wrote: > Add generic recipe for OpenCL API headers. > > Signed-off-by: Ankit Navik <ankit.tarot@gmail.com> > --- > .../recipes-core/opencl-headers/opencl-headers_git.bb | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > diff --git a/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > new file mode 100644 > index 0000000..16bc247 > --- /dev/null > +++ b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > @@ -0,0 +1,19 @@ > +SUMMARY = "OpenCL API Headers" > +DESCRIPTION = "OpenCL compute API headers from Khronos Group" > +LICENSE = "CLOSED" There is a license file at the repo. Would adding a "Khronos" license be more appropriate? https://github.com/KhronosGroup/OpenCL-Headers/blob/master/LICENSE - armin > +LIC_FILES_CHKSUM = "file://CL/opencl.h;beginline=1;endline=27;md5=687394644e8c4ec4fd3d77f2f86bc042" > +SECTION = "base" > + > +S = "${WORKDIR}/git" > +SRCREV = "40c5d226c7c0706f0176884e9b94b3886679c983" > +SRC_URI = "git://github.com/KhronosGroup/OpenCL-Headers.git" > + > +do_configure[noexec] = "1" > +do_compile[noexec] = "1" > + > +do_install () { > + install -d ${D}${includedir}/CL/ > + for f in ${S}/CL/*.h; do > + install -m 0644 $f ${D}${includedir}/CL/ > + done > +} ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] opencl-headers: Initial recipe for OpenCL headers 2018-10-03 23:10 ` akuster808 @ 2018-10-06 8:49 ` Ankit Navik 2018-10-14 18:29 ` Khem Raj 0 siblings, 1 reply; 13+ messages in thread From: Ankit Navik @ 2018-10-06 8:49 UTC (permalink / raw) To: Armin Kuster; +Cc: openembedded-devel Hi Armin, On Thu, Oct 4, 2018 at 4:40 AM akuster808 <akuster808@gmail.com> wrote: > > > > On 10/03/2018 08:40 AM, Ankit Navik wrote: > > Add generic recipe for OpenCL API headers. > > > > Signed-off-by: Ankit Navik <ankit.tarot@gmail.com> > > --- > > .../recipes-core/opencl-headers/opencl-headers_git.bb | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > create mode 100644 meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > diff --git a/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > new file mode 100644 > > index 0000000..16bc247 > > --- /dev/null > > +++ b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > @@ -0,0 +1,19 @@ > > +SUMMARY = "OpenCL API Headers" > > +DESCRIPTION = "OpenCL compute API headers from Khronos Group" > > +LICENSE = "CLOSED" > There is a license file at the repo. Would adding a "Khronos" license be > more appropriate? > > https://github.com/KhronosGroup/OpenCL-Headers/blob/master/LICENSE > > - armin I have tried adding "Khronos", but it was throwing QA error for license. Hence kept it as closed. Any other suggestion for license ? Regards, Ankit > > > +LIC_FILES_CHKSUM = "file://CL/opencl.h;beginline=1;endline=27;md5=687394644e8c4ec4fd3d77f2f86bc042" > > +SECTION = "base" > > + > > +S = "${WORKDIR}/git" > > +SRCREV = "40c5d226c7c0706f0176884e9b94b3886679c983" > > +SRC_URI = "git://github.com/KhronosGroup/OpenCL-Headers.git" > > + > > +do_configure[noexec] = "1" > > +do_compile[noexec] = "1" > > + > > +do_install () { > > + install -d ${D}${includedir}/CL/ > > + for f in ${S}/CL/*.h; do > > + install -m 0644 $f ${D}${includedir}/CL/ > > + done > > +} > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] opencl-headers: Initial recipe for OpenCL headers 2018-10-06 8:49 ` Ankit Navik @ 2018-10-14 18:29 ` Khem Raj 2018-10-15 3:12 ` Denys Dmytriyenko 2018-10-15 10:41 ` Ankit Navik 0 siblings, 2 replies; 13+ messages in thread From: Khem Raj @ 2018-10-14 18:29 UTC (permalink / raw) To: Ankit Navik; +Cc: openembeded-devel On Sat, Oct 6, 2018 at 1:49 AM Ankit Navik <ankit.tarot@gmail.com> wrote: > > Hi Armin, > > On Thu, Oct 4, 2018 at 4:40 AM akuster808 <akuster808@gmail.com> wrote: > > > > > > > > On 10/03/2018 08:40 AM, Ankit Navik wrote: > > > Add generic recipe for OpenCL API headers. > > > > > > Signed-off-by: Ankit Navik <ankit.tarot@gmail.com> > > > --- > > > .../recipes-core/opencl-headers/opencl-headers_git.bb | 19 +++++++++++++++++++ > > > 1 file changed, 19 insertions(+) > > > create mode 100644 meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > > > diff --git a/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > new file mode 100644 > > > index 0000000..16bc247 > > > --- /dev/null > > > +++ b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > @@ -0,0 +1,19 @@ > > > +SUMMARY = "OpenCL API Headers" > > > +DESCRIPTION = "OpenCL compute API headers from Khronos Group" > > > +LICENSE = "CLOSED" > > There is a license file at the repo. Would adding a "Khronos" license be > > more appropriate? > > > > https://github.com/KhronosGroup/OpenCL-Headers/blob/master/LICENSE > > > > - armin > > I have tried adding "Khronos", but it was throwing QA error for > license. Hence kept it as closed. > Any other suggestion for license ? > Please add a template for this license into meta-oe/licenses and then reference it in relevant recipes. > Regards, Ankit > > > > > +LIC_FILES_CHKSUM = "file://CL/opencl.h;beginline=1;endline=27;md5=687394644e8c4ec4fd3d77f2f86bc042" > > > +SECTION = "base" > > > + > > > +S = "${WORKDIR}/git" > > > +SRCREV = "40c5d226c7c0706f0176884e9b94b3886679c983" > > > +SRC_URI = "git://github.com/KhronosGroup/OpenCL-Headers.git" > > > + > > > +do_configure[noexec] = "1" > > > +do_compile[noexec] = "1" > > > + > > > +do_install () { > > > + install -d ${D}${includedir}/CL/ > > > + for f in ${S}/CL/*.h; do > > > + install -m 0644 $f ${D}${includedir}/CL/ > > > + done > > > +} > > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] opencl-headers: Initial recipe for OpenCL headers 2018-10-14 18:29 ` Khem Raj @ 2018-10-15 3:12 ` Denys Dmytriyenko 2018-10-15 10:43 ` Ankit Navik 2018-10-15 10:41 ` Ankit Navik 1 sibling, 1 reply; 13+ messages in thread From: Denys Dmytriyenko @ 2018-10-15 3:12 UTC (permalink / raw) To: Khem Raj; +Cc: openembeded-devel On Sun, Oct 14, 2018 at 11:29:26AM -0700, Khem Raj wrote: > On Sat, Oct 6, 2018 at 1:49 AM Ankit Navik <ankit.tarot@gmail.com> wrote: > > > > Hi Armin, > > > > On Thu, Oct 4, 2018 at 4:40 AM akuster808 <akuster808@gmail.com> wrote: > > > > > > > > > > > > On 10/03/2018 08:40 AM, Ankit Navik wrote: > > > > Add generic recipe for OpenCL API headers. > > > > > > > > Signed-off-by: Ankit Navik <ankit.tarot@gmail.com> > > > > --- > > > > .../recipes-core/opencl-headers/opencl-headers_git.bb | 19 +++++++++++++++++++ > > > > 1 file changed, 19 insertions(+) > > > > create mode 100644 meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > > > > > diff --git a/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > new file mode 100644 > > > > index 0000000..16bc247 > > > > --- /dev/null > > > > +++ b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > @@ -0,0 +1,19 @@ > > > > +SUMMARY = "OpenCL API Headers" > > > > +DESCRIPTION = "OpenCL compute API headers from Khronos Group" > > > > +LICENSE = "CLOSED" > > > There is a license file at the repo. Would adding a "Khronos" license be > > > more appropriate? > > > > > > https://github.com/KhronosGroup/OpenCL-Headers/blob/master/LICENSE > > > > > > - armin > > > > I have tried adding "Khronos", but it was throwing QA error for > > license. Hence kept it as closed. > > Any other suggestion for license ? > > > > Please add a template for this license into meta-oe/licenses and then > reference it in relevant recipes. > > > Regards, Ankit > > > > > > > +LIC_FILES_CHKSUM = "file://CL/opencl.h;beginline=1;endline=27;md5=687394644e8c4ec4fd3d77f2f86bc042" > > > > +SECTION = "base" > > > > + > > > > +S = "${WORKDIR}/git" > > > > +SRCREV = "40c5d226c7c0706f0176884e9b94b3886679c983" > > > > +SRC_URI = "git://github.com/KhronosGroup/OpenCL-Headers.git" > > > > + > > > > +do_configure[noexec] = "1" > > > > +do_compile[noexec] = "1" > > > > + > > > > +do_install () { > > > > + install -d ${D}${includedir}/CL/ > > > > + for f in ${S}/CL/*.h; do > > > > + install -m 0644 $f ${D}${includedir}/CL/ Single file install? Not very optimized... > > > > + done > > > > +} > > > > > -- > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] opencl-headers: Initial recipe for OpenCL headers 2018-10-15 3:12 ` Denys Dmytriyenko @ 2018-10-15 10:43 ` Ankit Navik 2018-10-15 18:14 ` Denys Dmytriyenko 0 siblings, 1 reply; 13+ messages in thread From: Ankit Navik @ 2018-10-15 10:43 UTC (permalink / raw) To: denis; +Cc: openembedded-devel Hi Denis, On Mon, Oct 15, 2018 at 8:42 AM Denys Dmytriyenko <denis@denix.org> wrote: > > On Sun, Oct 14, 2018 at 11:29:26AM -0700, Khem Raj wrote: > > On Sat, Oct 6, 2018 at 1:49 AM Ankit Navik <ankit.tarot@gmail.com> wrote: > > > > > > Hi Armin, > > > > > > On Thu, Oct 4, 2018 at 4:40 AM akuster808 <akuster808@gmail.com> wrote: > > > > > > > > > > > > > > > > On 10/03/2018 08:40 AM, Ankit Navik wrote: > > > > > Add generic recipe for OpenCL API headers. > > > > > > > > > > Signed-off-by: Ankit Navik <ankit.tarot@gmail.com> > > > > > --- > > > > > .../recipes-core/opencl-headers/opencl-headers_git.bb | 19 +++++++++++++++++++ > > > > > 1 file changed, 19 insertions(+) > > > > > create mode 100644 meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > > > > > > > diff --git a/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > > new file mode 100644 > > > > > index 0000000..16bc247 > > > > > --- /dev/null > > > > > +++ b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > > @@ -0,0 +1,19 @@ > > > > > +SUMMARY = "OpenCL API Headers" > > > > > +DESCRIPTION = "OpenCL compute API headers from Khronos Group" > > > > > +LICENSE = "CLOSED" > > > > There is a license file at the repo. Would adding a "Khronos" license be > > > > more appropriate? > > > > > > > > https://github.com/KhronosGroup/OpenCL-Headers/blob/master/LICENSE > > > > > > > > - armin > > > > > > I have tried adding "Khronos", but it was throwing QA error for > > > license. Hence kept it as closed. > > > Any other suggestion for license ? > > > > > > > Please add a template for this license into meta-oe/licenses and then > > reference it in relevant recipes. > > > > > Regards, Ankit > > > > > > > > > +LIC_FILES_CHKSUM = "file://CL/opencl.h;beginline=1;endline=27;md5=687394644e8c4ec4fd3d77f2f86bc042" > > > > > +SECTION = "base" > > > > > + > > > > > +S = "${WORKDIR}/git" > > > > > +SRCREV = "40c5d226c7c0706f0176884e9b94b3886679c983" > > > > > +SRC_URI = "git://github.com/KhronosGroup/OpenCL-Headers.git" > > > > > + > > > > > +do_configure[noexec] = "1" > > > > > +do_compile[noexec] = "1" > > > > > + > > > > > +do_install () { > > > > > + install -d ${D}${includedir}/CL/ > > > > > + for f in ${S}/CL/*.h; do > > > > > + install -m 0644 $f ${D}${includedir}/CL/ > > Single file install? Not very optimized... Its not a single file, Installing all the header files. Regards, Ankit > > > > > > > + done > > > > > +} > > > > > > > -- > > > _______________________________________________ > > > Openembedded-devel mailing list > > > Openembedded-devel@lists.openembedded.org > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > -- > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] opencl-headers: Initial recipe for OpenCL headers 2018-10-15 10:43 ` Ankit Navik @ 2018-10-15 18:14 ` Denys Dmytriyenko 2018-10-15 18:19 ` Khem Raj 0 siblings, 1 reply; 13+ messages in thread From: Denys Dmytriyenko @ 2018-10-15 18:14 UTC (permalink / raw) To: Ankit Navik; +Cc: openembedded-devel On Mon, Oct 15, 2018 at 04:13:03PM +0530, Ankit Navik wrote: > Hi Denis, > On Mon, Oct 15, 2018 at 8:42 AM Denys Dmytriyenko <denis@denix.org> wrote: > > > > On Sun, Oct 14, 2018 at 11:29:26AM -0700, Khem Raj wrote: > > > On Sat, Oct 6, 2018 at 1:49 AM Ankit Navik <ankit.tarot@gmail.com> wrote: > > > > > > > > Hi Armin, > > > > > > > > On Thu, Oct 4, 2018 at 4:40 AM akuster808 <akuster808@gmail.com> wrote: > > > > > > > > > > > > > > > > > > > > On 10/03/2018 08:40 AM, Ankit Navik wrote: > > > > > > Add generic recipe for OpenCL API headers. > > > > > > > > > > > > Signed-off-by: Ankit Navik <ankit.tarot@gmail.com> > > > > > > --- > > > > > > .../recipes-core/opencl-headers/opencl-headers_git.bb | 19 +++++++++++++++++++ > > > > > > 1 file changed, 19 insertions(+) > > > > > > create mode 100644 meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > > > > > > > > > diff --git a/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > > > new file mode 100644 > > > > > > index 0000000..16bc247 > > > > > > --- /dev/null > > > > > > +++ b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > > > @@ -0,0 +1,19 @@ > > > > > > +SUMMARY = "OpenCL API Headers" > > > > > > +DESCRIPTION = "OpenCL compute API headers from Khronos Group" > > > > > > +LICENSE = "CLOSED" > > > > > There is a license file at the repo. Would adding a "Khronos" license be > > > > > more appropriate? > > > > > > > > > > https://github.com/KhronosGroup/OpenCL-Headers/blob/master/LICENSE > > > > > > > > > > - armin > > > > > > > > I have tried adding "Khronos", but it was throwing QA error for > > > > license. Hence kept it as closed. > > > > Any other suggestion for license ? > > > > > > > > > > Please add a template for this license into meta-oe/licenses and then > > > reference it in relevant recipes. > > > > > > > Regards, Ankit > > > > > > > > > > > +LIC_FILES_CHKSUM = "file://CL/opencl.h;beginline=1;endline=27;md5=687394644e8c4ec4fd3d77f2f86bc042" > > > > > > +SECTION = "base" > > > > > > + > > > > > > +S = "${WORKDIR}/git" > > > > > > +SRCREV = "40c5d226c7c0706f0176884e9b94b3886679c983" > > > > > > +SRC_URI = "git://github.com/KhronosGroup/OpenCL-Headers.git" > > > > > > + > > > > > > +do_configure[noexec] = "1" > > > > > > +do_compile[noexec] = "1" > > > > > > + > > > > > > +do_install () { > > > > > > + install -d ${D}${includedir}/CL/ > > > > > > + for f in ${S}/CL/*.h; do > > > > > > + install -m 0644 $f ${D}${includedir}/CL/ > > > > Single file install? Not very optimized... > Its not a single file, Installing all the header files. It's a single file install in a for loop, hence my comment about being unoptimal. Why not use "cp *.h"? > > > > > > + done > > > > > > +} > > > > > > > > > -- > > > > _______________________________________________ > > > > Openembedded-devel mailing list > > > > Openembedded-devel@lists.openembedded.org > > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > > -- > > > _______________________________________________ > > > Openembedded-devel mailing list > > > Openembedded-devel@lists.openembedded.org > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] opencl-headers: Initial recipe for OpenCL headers 2018-10-15 18:14 ` Denys Dmytriyenko @ 2018-10-15 18:19 ` Khem Raj 2018-10-15 19:00 ` Denys Dmytriyenko 0 siblings, 1 reply; 13+ messages in thread From: Khem Raj @ 2018-10-15 18:19 UTC (permalink / raw) To: Denys Dmytriyenko; +Cc: openembeded-devel On Mon, Oct 15, 2018 at 11:14 AM Denys Dmytriyenko <denis@denix.org> wrote: > > On Mon, Oct 15, 2018 at 04:13:03PM +0530, Ankit Navik wrote: > > Hi Denis, > > On Mon, Oct 15, 2018 at 8:42 AM Denys Dmytriyenko <denis@denix.org> wrote: > > > > > > On Sun, Oct 14, 2018 at 11:29:26AM -0700, Khem Raj wrote: > > > > On Sat, Oct 6, 2018 at 1:49 AM Ankit Navik <ankit.tarot@gmail.com> wrote: > > > > > > > > > > Hi Armin, > > > > > > > > > > On Thu, Oct 4, 2018 at 4:40 AM akuster808 <akuster808@gmail.com> wrote: > > > > > > > > > > > > > > > > > > > > > > > > On 10/03/2018 08:40 AM, Ankit Navik wrote: > > > > > > > Add generic recipe for OpenCL API headers. > > > > > > > > > > > > > > Signed-off-by: Ankit Navik <ankit.tarot@gmail.com> > > > > > > > --- > > > > > > > .../recipes-core/opencl-headers/opencl-headers_git.bb | 19 +++++++++++++++++++ > > > > > > > 1 file changed, 19 insertions(+) > > > > > > > create mode 100644 meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > > > > > > > > > > > diff --git a/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > > > > new file mode 100644 > > > > > > > index 0000000..16bc247 > > > > > > > --- /dev/null > > > > > > > +++ b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > > > > @@ -0,0 +1,19 @@ > > > > > > > +SUMMARY = "OpenCL API Headers" > > > > > > > +DESCRIPTION = "OpenCL compute API headers from Khronos Group" > > > > > > > +LICENSE = "CLOSED" > > > > > > There is a license file at the repo. Would adding a "Khronos" license be > > > > > > more appropriate? > > > > > > > > > > > > https://github.com/KhronosGroup/OpenCL-Headers/blob/master/LICENSE > > > > > > > > > > > > - armin > > > > > > > > > > I have tried adding "Khronos", but it was throwing QA error for > > > > > license. Hence kept it as closed. > > > > > Any other suggestion for license ? > > > > > > > > > > > > > Please add a template for this license into meta-oe/licenses and then > > > > reference it in relevant recipes. > > > > > > > > > Regards, Ankit > > > > > > > > > > > > > +LIC_FILES_CHKSUM = "file://CL/opencl.h;beginline=1;endline=27;md5=687394644e8c4ec4fd3d77f2f86bc042" > > > > > > > +SECTION = "base" > > > > > > > + > > > > > > > +S = "${WORKDIR}/git" > > > > > > > +SRCREV = "40c5d226c7c0706f0176884e9b94b3886679c983" > > > > > > > +SRC_URI = "git://github.com/KhronosGroup/OpenCL-Headers.git" > > > > > > > + > > > > > > > +do_configure[noexec] = "1" > > > > > > > +do_compile[noexec] = "1" > > > > > > > + > > > > > > > +do_install () { > > > > > > > + install -d ${D}${includedir}/CL/ > > > > > > > + for f in ${S}/CL/*.h; do > > > > > > > + install -m 0644 $f ${D}${includedir}/CL/ > > > > > > Single file install? Not very optimized... > > > Its not a single file, Installing all the header files. > > It's a single file install in a for loop, hence my comment about being > unoptimal. Why not use "cp *.h"? I agree its suboptimal use here. May be install [OPTION]... -t DIRECTORY SOURCE could be tamed to make it better. however cp messes the file permissions up if not used with right opts. So I would not prefer it unless used with right options to respect the file perms. Install does it correctly, ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] opencl-headers: Initial recipe for OpenCL headers 2018-10-15 18:19 ` Khem Raj @ 2018-10-15 19:00 ` Denys Dmytriyenko 2018-10-15 19:07 ` Burton, Ross 0 siblings, 1 reply; 13+ messages in thread From: Denys Dmytriyenko @ 2018-10-15 19:00 UTC (permalink / raw) To: Khem Raj; +Cc: openembeded-devel On Mon, Oct 15, 2018 at 11:19:37AM -0700, Khem Raj wrote: > On Mon, Oct 15, 2018 at 11:14 AM Denys Dmytriyenko <denis@denix.org> wrote: > > > > On Mon, Oct 15, 2018 at 04:13:03PM +0530, Ankit Navik wrote: > > > Hi Denis, > > > On Mon, Oct 15, 2018 at 8:42 AM Denys Dmytriyenko <denis@denix.org> wrote: > > > > > > > > On Sun, Oct 14, 2018 at 11:29:26AM -0700, Khem Raj wrote: > > > > > On Sat, Oct 6, 2018 at 1:49 AM Ankit Navik <ankit.tarot@gmail.com> wrote: > > > > > > > > > > > > Hi Armin, > > > > > > > > > > > > On Thu, Oct 4, 2018 at 4:40 AM akuster808 <akuster808@gmail.com> wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 10/03/2018 08:40 AM, Ankit Navik wrote: > > > > > > > > Add generic recipe for OpenCL API headers. > > > > > > > > > > > > > > > > Signed-off-by: Ankit Navik <ankit.tarot@gmail.com> > > > > > > > > --- > > > > > > > > .../recipes-core/opencl-headers/opencl-headers_git.bb | 19 +++++++++++++++++++ > > > > > > > > 1 file changed, 19 insertions(+) > > > > > > > > create mode 100644 meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > > > > > > > > > > > > > diff --git a/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > > > > > new file mode 100644 > > > > > > > > index 0000000..16bc247 > > > > > > > > --- /dev/null > > > > > > > > +++ b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > > > > > @@ -0,0 +1,19 @@ > > > > > > > > +SUMMARY = "OpenCL API Headers" > > > > > > > > +DESCRIPTION = "OpenCL compute API headers from Khronos Group" > > > > > > > > +LICENSE = "CLOSED" > > > > > > > There is a license file at the repo. Would adding a "Khronos" license be > > > > > > > more appropriate? > > > > > > > > > > > > > > https://github.com/KhronosGroup/OpenCL-Headers/blob/master/LICENSE > > > > > > > > > > > > > > - armin > > > > > > > > > > > > I have tried adding "Khronos", but it was throwing QA error for > > > > > > license. Hence kept it as closed. > > > > > > Any other suggestion for license ? > > > > > > > > > > > > > > > > Please add a template for this license into meta-oe/licenses and then > > > > > reference it in relevant recipes. > > > > > > > > > > > Regards, Ankit > > > > > > > > > > > > > > > +LIC_FILES_CHKSUM = "file://CL/opencl.h;beginline=1;endline=27;md5=687394644e8c4ec4fd3d77f2f86bc042" > > > > > > > > +SECTION = "base" > > > > > > > > + > > > > > > > > +S = "${WORKDIR}/git" > > > > > > > > +SRCREV = "40c5d226c7c0706f0176884e9b94b3886679c983" > > > > > > > > +SRC_URI = "git://github.com/KhronosGroup/OpenCL-Headers.git" > > > > > > > > + > > > > > > > > +do_configure[noexec] = "1" > > > > > > > > +do_compile[noexec] = "1" > > > > > > > > + > > > > > > > > +do_install () { > > > > > > > > + install -d ${D}${includedir}/CL/ > > > > > > > > + for f in ${S}/CL/*.h; do > > > > > > > > + install -m 0644 $f ${D}${includedir}/CL/ > > > > > > > > Single file install? Not very optimized... > > > > > Its not a single file, Installing all the header files. > > > > It's a single file install in a for loop, hence my comment about being > > unoptimal. Why not use "cp *.h"? > > I agree its suboptimal use here. May be > > install [OPTION]... -t DIRECTORY SOURCE > > could be tamed to make it better. > however cp messes the file permissions up if not used with right opts. > So I would not prefer it unless used with right > options to respect the file perms. Install does it correctly, Agree, cp would require passing correct options, but there are plenty of examples alreay. -- Denys ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] opencl-headers: Initial recipe for OpenCL headers 2018-10-15 19:00 ` Denys Dmytriyenko @ 2018-10-15 19:07 ` Burton, Ross 2018-10-15 19:34 ` Denys Dmytriyenko 2018-10-16 4:40 ` Ankit Navik 0 siblings, 2 replies; 13+ messages in thread From: Burton, Ross @ 2018-10-15 19:07 UTC (permalink / raw) To: Denys Dmytriyenko; +Cc: OpenEmbedded Devel List On Mon, 15 Oct 2018 at 20:01, Denys Dmytriyenko <denis@denix.org> wrote: > > > > > > > > > +do_install () { > > > > > > > > > + install -d ${D}${includedir}/CL/ > > > > > > > > > + for f in ${S}/CL/*.h; do > > > > > > > > > + install -m 0644 $f ${D}${includedir}/CL/ > > > > > > > > > > Single file install? Not very optimized... > > > > > > > Its not a single file, Installing all the header files. > > > > > > It's a single file install in a for loop, hence my comment about being > > > unoptimal. Why not use "cp *.h"? > > > > I agree its suboptimal use here. May be > > > > install [OPTION]... -t DIRECTORY SOURCE > > > > could be tamed to make it better. > > however cp messes the file permissions up if not used with right opts. > > So I would not prefer it unless used with right > > options to respect the file perms. Install does it correctly, > > Agree, cp would require passing correct options, but there are plenty of > examples alreay. If we're bikeshedding a micro-optimisation then surely this is optimal: install -m 0644 -D -t ${D}${includedir}/CL ${S}/CL/*.h That combines the mkdir and cp in one command. Ross ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] opencl-headers: Initial recipe for OpenCL headers 2018-10-15 19:07 ` Burton, Ross @ 2018-10-15 19:34 ` Denys Dmytriyenko 2018-10-16 4:40 ` Ankit Navik 1 sibling, 0 replies; 13+ messages in thread From: Denys Dmytriyenko @ 2018-10-15 19:34 UTC (permalink / raw) To: Burton, Ross; +Cc: OpenEmbedded Devel List On Mon, Oct 15, 2018 at 08:07:06PM +0100, Burton, Ross wrote: > On Mon, 15 Oct 2018 at 20:01, Denys Dmytriyenko <denis@denix.org> wrote: > > > > > > > > > > +do_install () { > > > > > > > > > > + install -d ${D}${includedir}/CL/ > > > > > > > > > > + for f in ${S}/CL/*.h; do > > > > > > > > > > + install -m 0644 $f ${D}${includedir}/CL/ > > > > > > > > > > > > Single file install? Not very optimized... > > > > > > > > > Its not a single file, Installing all the header files. > > > > > > > > It's a single file install in a for loop, hence my comment about being > > > > unoptimal. Why not use "cp *.h"? > > > > > > I agree its suboptimal use here. May be > > > > > > install [OPTION]... -t DIRECTORY SOURCE > > > > > > could be tamed to make it better. > > > however cp messes the file permissions up if not used with right opts. > > > So I would not prefer it unless used with right > > > options to respect the file perms. Install does it correctly, > > > > Agree, cp would require passing correct options, but there are plenty of > > examples alreay. > > If we're bikeshedding a micro-optimisation then surely this is optimal: > > install -m 0644 -D -t ${D}${includedir}/CL ${S}/CL/*.h > > That combines the mkdir and cp in one command. +1 And who said bikeshedding is a waste of time? :) -- Denys ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] opencl-headers: Initial recipe for OpenCL headers 2018-10-15 19:07 ` Burton, Ross 2018-10-15 19:34 ` Denys Dmytriyenko @ 2018-10-16 4:40 ` Ankit Navik 1 sibling, 0 replies; 13+ messages in thread From: Ankit Navik @ 2018-10-16 4:40 UTC (permalink / raw) To: Burton, Ross; +Cc: openembedded-devel Hi Ross, On Tue, Oct 16, 2018 at 12:37 AM Burton, Ross <ross.burton@intel.com> wrote: > > On Mon, 15 Oct 2018 at 20:01, Denys Dmytriyenko <denis@denix.org> wrote: > > > > > > > > > > +do_install () { > > > > > > > > > > + install -d ${D}${includedir}/CL/ > > > > > > > > > > + for f in ${S}/CL/*.h; do > > > > > > > > > > + install -m 0644 $f ${D}${includedir}/CL/ > > > > > > > > > > > > Single file install? Not very optimized... > > > > > > > > > Its not a single file, Installing all the header files. > > > > > > > > It's a single file install in a for loop, hence my comment about being > > > > unoptimal. Why not use "cp *.h"? > > > > > > I agree its suboptimal use here. May be > > > > > > install [OPTION]... -t DIRECTORY SOURCE > > > > > > could be tamed to make it better. > > > however cp messes the file permissions up if not used with right opts. > > > So I would not prefer it unless used with right > > > options to respect the file perms. Install does it correctly, > > > > Agree, cp would require passing correct options, but there are plenty of > > examples alreay. > > If we're bikeshedding a micro-optimisation then surely this is optimal: > > install -m 0644 -D -t ${D}${includedir}/CL ${S}/CL/*.h > > That combines the mkdir and cp in one command. Thank you for your suggestion, but this one line command still throws error of No such file or directory. Following line will solve: install -d ${D}${includedir}/CL/ install -m 0644 -t ${D}${includedir}/CL ${S}/CL/*.h I'll send this patch in v3. Regards, Ankit > > Ross > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] opencl-headers: Initial recipe for OpenCL headers 2018-10-14 18:29 ` Khem Raj 2018-10-15 3:12 ` Denys Dmytriyenko @ 2018-10-15 10:41 ` Ankit Navik 1 sibling, 0 replies; 13+ messages in thread From: Ankit Navik @ 2018-10-15 10:41 UTC (permalink / raw) To: Khem Raj; +Cc: openembedded-devel Hi Raj, On Sun, Oct 14, 2018 at 11:59 PM Khem Raj <raj.khem@gmail.com> wrote: > > On Sat, Oct 6, 2018 at 1:49 AM Ankit Navik <ankit.tarot@gmail.com> wrote: > > > > Hi Armin, > > > > On Thu, Oct 4, 2018 at 4:40 AM akuster808 <akuster808@gmail.com> wrote: > > > > > > > > > > > > On 10/03/2018 08:40 AM, Ankit Navik wrote: > > > > Add generic recipe for OpenCL API headers. > > > > > > > > Signed-off-by: Ankit Navik <ankit.tarot@gmail.com> > > > > --- > > > > .../recipes-core/opencl-headers/opencl-headers_git.bb | 19 +++++++++++++++++++ > > > > 1 file changed, 19 insertions(+) > > > > create mode 100644 meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > > > > > diff --git a/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > new file mode 100644 > > > > index 0000000..16bc247 > > > > --- /dev/null > > > > +++ b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > @@ -0,0 +1,19 @@ > > > > +SUMMARY = "OpenCL API Headers" > > > > +DESCRIPTION = "OpenCL compute API headers from Khronos Group" > > > > +LICENSE = "CLOSED" > > > There is a license file at the repo. Would adding a "Khronos" license be > > > more appropriate? > > > > > > https://github.com/KhronosGroup/OpenCL-Headers/blob/master/LICENSE > > > > > > - armin > > > > I have tried adding "Khronos", but it was throwing QA error for > > license. Hence kept it as closed. > > Any other suggestion for license ? > > > > Please add a template for this license into meta-oe/licenses and then > reference it in relevant recipes. Thanks for your suggestion, will incorporate in v2 patch. > > > Regards, Ankit > > > > > > > +LIC_FILES_CHKSUM = "file://CL/opencl.h;beginline=1;endline=27;md5=687394644e8c4ec4fd3d77f2f86bc042" > > > > +SECTION = "base" > > > > + > > > > +S = "${WORKDIR}/git" > > > > +SRCREV = "40c5d226c7c0706f0176884e9b94b3886679c983" > > > > +SRC_URI = "git://github.com/KhronosGroup/OpenCL-Headers.git" > > > > + > > > > +do_configure[noexec] = "1" > > > > +do_compile[noexec] = "1" > > > > + > > > > +do_install () { > > > > + install -d ${D}${includedir}/CL/ > > > > + for f in ${S}/CL/*.h; do > > > > + install -m 0644 $f ${D}${includedir}/CL/ > > > > + done > > > > +} > > > > > -- > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2018-10-16 4:40 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-10-03 15:40 [PATCH] opencl-headers: Initial recipe for OpenCL headers Ankit Navik 2018-10-03 23:10 ` akuster808 2018-10-06 8:49 ` Ankit Navik 2018-10-14 18:29 ` Khem Raj 2018-10-15 3:12 ` Denys Dmytriyenko 2018-10-15 10:43 ` Ankit Navik 2018-10-15 18:14 ` Denys Dmytriyenko 2018-10-15 18:19 ` Khem Raj 2018-10-15 19:00 ` Denys Dmytriyenko 2018-10-15 19:07 ` Burton, Ross 2018-10-15 19:34 ` Denys Dmytriyenko 2018-10-16 4:40 ` Ankit Navik 2018-10-15 10:41 ` Ankit Navik
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.