From: Denys Dmytriyenko <denys@ti.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: meta-ti@yoctoproject.org
Subject: Re: [PATCH 4/5] beaglebone.conf: Package kernel and devicetree
Date: Wed, 17 Oct 2018 15:46:23 -0400 [thread overview]
Message-ID: <20181017194623.GJ4031@beryl> (raw)
In-Reply-To: <20181017192853.42942-4-raj.khem@gmail.com>
On Wed, Oct 17, 2018 at 12:28:52PM -0700, Khem Raj wrote:
> Use variables from upstream u-boot, makes it easy to switch to
> mainline u-boot from oe-core if someone wants to
Actually, those vars are not unique to upstream u-boot:
http://arago-project.org/git/?p=meta-ti.git;a=blob;f=recipes-bsp/u-boot/u-boot-ti.inc;hb=HEAD
Lines #13 and #54.
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> conf/machine/beaglebone.conf | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/conf/machine/beaglebone.conf b/conf/machine/beaglebone.conf
> index 25147926..9b656d01 100644
> --- a/conf/machine/beaglebone.conf
> +++ b/conf/machine/beaglebone.conf
> @@ -1,6 +1,6 @@
> #@TYPE: Machine
> #@NAME: BeagleBone machine
> -#@DESCRIPTION: Machine configuration for the http://beagleboard.org/bone board
> +#@DESCRIPTION: Machine configuration for the http://beagleboard.org/bone board
>
> require conf/machine/include/ti33x.inc
>
> @@ -17,10 +17,16 @@ SERIAL_CONSOLE = "115200 ttyS0"
> #UBOOT_MACHINE = "am335x_boneblack_config"
>
> WKS_FILE = "sdimage-bootpart.wks"
> -IMAGE_BOOT_FILES = "MLO u-boot.img"
> -IMAGE_FSTYPES += "tar.xz wic.xz"
>
> do_image_wic[depends] += "mtools-native:do_populate_sysroot dosfstools-native:do_populate_sysroot"
> +IMAGE_BOOT_FILES ?= "u-boot.${UBOOT_SUFFIX} MLO"
> +
> +IMAGE_FSTYPES += "tar.xz wic.xz"
>
> # Refine the list of device targets for ti-pdk class recipes
> TI_PDK_LIMIT_BOARDS = "bbbAM335x"
> +
> +SPL_BINARY = "MLO"
> +UBOOT_SUFFIX = "img"
Well, I see your point defining these 2 vars here, but then you don't use MLO
above for IMAGE_BOOT_FILES...
Also, it would make sense to start moving those vars into machine configs for
other machines. And make them conditional in u-boot recipe...
> +IMAGE_INSTALL_append = " kernel-devicetree kernel-image-zimage"
> --
> 2.19.1
>
> --
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
next prev parent reply other threads:[~2018-10-17 19:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 19:28 [PATCH 1/5] recipes: Limit ti specific recipes under ti-soc override Khem Raj
2018-10-17 19:28 ` [PATCH 2/5] recips: Mark more recipes to be ti-soc specific Khem Raj
2018-10-17 20:11 ` Denys Dmytriyenko
2018-10-17 22:21 ` Khem Raj
2018-10-17 22:30 ` Denys Dmytriyenko
2018-10-17 19:28 ` [PATCH 3/5] u-boot: reduce the SPL `.rodata' size Khem Raj
2018-10-17 22:34 ` Denys Dmytriyenko
2018-10-17 22:50 ` Khem Raj
2018-10-17 19:28 ` [PATCH 4/5] beaglebone.conf: Package kernel and devicetree Khem Raj
2018-10-17 19:46 ` Denys Dmytriyenko [this message]
2018-10-17 19:50 ` Denys Dmytriyenko
2018-10-17 19:28 ` [PATCH 5/5] beaglebone.conf: SERIAL_CONSOLE has been deprecated Khem Raj
2018-10-17 19:37 ` Denys Dmytriyenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017194623.GJ4031@beryl \
--to=denys@ti.com \
--cc=meta-ti@yoctoproject.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.