[PATCH] staging: wlan-ng: Replace long int with long

[PATCH] staging: wlan-ng: Replace long int with long

[Maya Nakamura]

Replace long int with long as int is unnecessary. Issue found by
checkpatch.pl.

Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
---
 drivers/staging/wlan-ng/p80211conv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c
index 91debcf20646..0ff5fda81b05 100644
--- a/drivers/staging/wlan-ng/p80211conv.c
+++ b/drivers/staging/wlan-ng/p80211conv.c
@@ -430,7 +430,7 @@ int skb_p80211_to_ether(struct wlandevice *wlandev, u32 ethconv,
 			/* A bogus length ethfrm has been sent. */
 			/* Is someone trying an oflow attack? */
 			netdev_err(netdev, "DIXII frame too large (%ld > %d)\n",
-				   (long int)(payload_length -
+				   (long)(payload_length -
 				   sizeof(struct wlan_llc) -
 				   sizeof(struct wlan_snap)), netdev->mtu);
 			return 1;
-- 
2.17.1

Re: [Outreachy kernel] [PATCH] staging: wlan-ng: Replace long int with long

[Vaishali Thakkar]

On Thu, Oct 18, 2018 at 10:08 AM Maya Nakamura
<m.maya.nakamura@gmail.com> wrote:
>
> Replace long int with long as int is unnecessary. Issue found by
> checkpatch.pl.

It'll be good to explain why do you think 'long int' is unnecessary
here.

> Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
> ---
>  drivers/staging/wlan-ng/p80211conv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c
> index 91debcf20646..0ff5fda81b05 100644
> --- a/drivers/staging/wlan-ng/p80211conv.c
> +++ b/drivers/staging/wlan-ng/p80211conv.c
> @@ -430,7 +430,7 @@ int skb_p80211_to_ether(struct wlandevice *wlandev, u32 ethconv,
>                         /* A bogus length ethfrm has been sent. */
>                         /* Is someone trying an oflow attack? */
>                         netdev_err(netdev, "DIXII frame too large (%ld > %d)\n",
> -                                  (long int)(payload_length -
> +                                  (long)(payload_length -
>                                    sizeof(struct wlan_llc) -
>                                    sizeof(struct wlan_snap)), netdev->mtu);
>                         return 1;
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181018043801.GA4248%40k-vBox.
> For more options, visit https://groups.google.com/d/optout.