All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Maya Nakamura <m.maya.nakamura@gmail.com>
Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
	gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: speakup: Add a pair of braces
Date: Thu, 18 Oct 2018 08:44:06 +0200	[thread overview]
Message-ID: <20181018064406.dtrl5vih72nim3j5@function> (raw)
In-Reply-To: <20181018011558.GA2255@k-vBox>

Maya Nakamura, le mer. 17 oct. 2018 18:16:00 -0700, a ecrit:
> Add a pair of braces to make all arms of the if statement consistent.
> Issue found by checkpatch.pl.
> 
> Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>

Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  drivers/staging/speakup/spk_ttyio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/speakup/spk_ttyio.c b/drivers/staging/speakup/spk_ttyio.c
> index eac63aab8162..979e3ae249c1 100644
> --- a/drivers/staging/speakup/spk_ttyio.c
> +++ b/drivers/staging/speakup/spk_ttyio.c
> @@ -227,9 +227,9 @@ static int spk_ttyio_out_unicode(struct spk_synth *in_synth, u16 ch)
>  {
>  	int ret;
>  
> -	if (ch < 0x80)
> +	if (ch < 0x80) {
>  		ret = spk_ttyio_out(in_synth, ch);
> -	else if (ch < 0x800) {
> +	} else if (ch < 0x800) {
>  		ret  = spk_ttyio_out(in_synth, 0xc0 | (ch >> 6));
>  		ret &= spk_ttyio_out(in_synth, 0x80 | (ch & 0x3f));
>  	} else {
> -- 
> 2.17.1
> 

-- 
Samuel
 je n ai cité aucun message et sur irc on parle effectivement comme des
 enfants de 5 ans na!
 > 3. Quand tu cite un message, répond _après_ ce que tu cites !
 -+- Yota in : Guide du Neuneu d'Usenet - A un Yota près c'était bon -+-


      reply	other threads:[~2018-10-18  6:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-18  1:16 [PATCH] staging: speakup: Add a pair of braces Maya Nakamura
2018-10-18  6:44 ` Samuel Thibault [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181018064406.dtrl5vih72nim3j5@function \
    --to=samuel.thibault@ens-lyon.org \
    --cc=chris@the-brannons.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kirk@reisers.ca \
    --cc=m.maya.nakamura@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=w.d.hubbs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.