* [PATCH] staging: speakup: Add a pair of braces
@ 2018-10-18 1:16 Maya Nakamura
2018-10-18 6:44 ` Samuel Thibault
0 siblings, 1 reply; 2+ messages in thread
From: Maya Nakamura @ 2018-10-18 1:16 UTC (permalink / raw)
To: w.d.hubbs, chris, kirk, samuel.thibault, gregkh, outreachy-kernel
Add a pair of braces to make all arms of the if statement consistent.
Issue found by checkpatch.pl.
Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
---
drivers/staging/speakup/spk_ttyio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/speakup/spk_ttyio.c b/drivers/staging/speakup/spk_ttyio.c
index eac63aab8162..979e3ae249c1 100644
--- a/drivers/staging/speakup/spk_ttyio.c
+++ b/drivers/staging/speakup/spk_ttyio.c
@@ -227,9 +227,9 @@ static int spk_ttyio_out_unicode(struct spk_synth *in_synth, u16 ch)
{
int ret;
- if (ch < 0x80)
+ if (ch < 0x80) {
ret = spk_ttyio_out(in_synth, ch);
- else if (ch < 0x800) {
+ } else if (ch < 0x800) {
ret = spk_ttyio_out(in_synth, 0xc0 | (ch >> 6));
ret &= spk_ttyio_out(in_synth, 0x80 | (ch & 0x3f));
} else {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: speakup: Add a pair of braces
2018-10-18 1:16 [PATCH] staging: speakup: Add a pair of braces Maya Nakamura
@ 2018-10-18 6:44 ` Samuel Thibault
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Thibault @ 2018-10-18 6:44 UTC (permalink / raw)
To: Maya Nakamura; +Cc: w.d.hubbs, chris, kirk, gregkh, outreachy-kernel
Maya Nakamura, le mer. 17 oct. 2018 18:16:00 -0700, a ecrit:
> Add a pair of braces to make all arms of the if statement consistent.
> Issue found by checkpatch.pl.
>
> Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> drivers/staging/speakup/spk_ttyio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/speakup/spk_ttyio.c b/drivers/staging/speakup/spk_ttyio.c
> index eac63aab8162..979e3ae249c1 100644
> --- a/drivers/staging/speakup/spk_ttyio.c
> +++ b/drivers/staging/speakup/spk_ttyio.c
> @@ -227,9 +227,9 @@ static int spk_ttyio_out_unicode(struct spk_synth *in_synth, u16 ch)
> {
> int ret;
>
> - if (ch < 0x80)
> + if (ch < 0x80) {
> ret = spk_ttyio_out(in_synth, ch);
> - else if (ch < 0x800) {
> + } else if (ch < 0x800) {
> ret = spk_ttyio_out(in_synth, 0xc0 | (ch >> 6));
> ret &= spk_ttyio_out(in_synth, 0x80 | (ch & 0x3f));
> } else {
> --
> 2.17.1
>
--
Samuel
je n ai cité aucun message et sur irc on parle effectivement comme des
enfants de 5 ans na!
> 3. Quand tu cite un message, répond _après_ ce que tu cites !
-+- Yota in : Guide du Neuneu d'Usenet - A un Yota près c'était bon -+-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-18 6:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-18 1:16 [PATCH] staging: speakup: Add a pair of braces Maya Nakamura
2018-10-18 6:44 ` Samuel Thibault
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.