From: gregkh@linuxfoundation.org (gregkh@linuxfoundation.org)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH] ARC: Get rid of toolchain check
Date: Thu, 18 Oct 2018 14:44:09 +0200 [thread overview]
Message-ID: <20181018124409.GC1451@kroah.com> (raw)
In-Reply-To: <4881796E12491D4BB15146FE0209CE6468174FE0@DE02WEMBXB.internal.synopsys.com>
On Wed, Oct 17, 2018@02:28:41PM +0000, Alexey Brodkin wrote:
> Hello,
>
> > -----Original Message-----
> > From: Rob Herring [mailto:robh at kernel.org]
> > Sent: Friday, September 14, 2018 12:04 AM
> > To: Alexey.Brodkin at synopsys.com
> > Cc: linux-snps-arc at lists.infradead.org; Linux Kernel Mailing List <linux-kernel at vger.kernel.org>; Vineet.Gupta1 at synopsys.com
> > Subject: Re: [PATCH] ARC: Get rid of toolchain check
> >
> > On Thu, Sep 13, 2018 at 3:24 PM Alexey Brodkin
> > <Alexey.Brodkin@synopsys.com> wrote:
> > >
> > > This check is very naive: we simply test if GCC invoked without
> > > "-mcpu=XXX" has ARC700 define set. In that case we think that GCC
> > > was built with "--with-cpu=arc700" and has libgcc built for ARC700.
> > >
> > > Otherwise if ARC700 is not defined we think that everythng was built
> > > for ARCv2.
> > >
> > > But in reality our life is much more interesting.
> > >
> > > 1. Regardless of GCC configuration (i.e. what we pass in "--with-cpu"
> > > it may generate code for any ARC core).
> > >
> > > 2. libgcc might be built with explicitly specified "--mcpu=YYY"
> > >
> > > That's exactly what happens in case of multilibbed toolchains:
> > > - GCC is configured with default settings
> > > - All the libs built for many different CPU flavors
> > >
> > > I.e. that check gets in the way of usage of multilibbed
> > > toolchains. And even non-multilibbed toolchains are affected.
> > > OpenEmbedded also builds GCC without "--with-cpu" because
> > > each and every target component later is compiled with explicitly
> > > set "-mcpu=ZZZ".
> > >
> > > Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
> > > ---
> > > arch/arc/Makefile | 14 --------------
> > > 1 file changed, 14 deletions(-)
> >
> > +1 for this. Removing it also helps with my work to be able to build
> > all the .dts files with only a host compiler. That also needs the hunk
> > setting CROSS_COMPILE removed and not having a built-in dtb by
> > default, but this is a step in the right direction.
> >
> > Acked-by: Rob Herring <robh at kernel.org>
>
> May we get this one back-ported to stable trees?
>
> Upstream commit in Linus' tree is
> 615f64458ad8 ("ARC: build: Get rid of toolchain check").
>
> This fixes kernel configuration for ARC in case of missing
> ARC cross-tools in current PATH.
Now queued up, thanks.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Alexey Brodkin <alexey.brodkin@synopsys.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh@kernel.org>,
Vineet Gupta <vineet.gupta1@synopsys.com>
Subject: Re: [PATCH] ARC: Get rid of toolchain check
Date: Thu, 18 Oct 2018 14:44:09 +0200 [thread overview]
Message-ID: <20181018124409.GC1451@kroah.com> (raw)
In-Reply-To: <4881796E12491D4BB15146FE0209CE6468174FE0@DE02WEMBXB.internal.synopsys.com>
On Wed, Oct 17, 2018 at 02:28:41PM +0000, Alexey Brodkin wrote:
> Hello,
>
> > -----Original Message-----
> > From: Rob Herring [mailto:robh@kernel.org]
> > Sent: Friday, September 14, 2018 12:04 AM
> > To: Alexey.Brodkin@synopsys.com
> > Cc: linux-snps-arc@lists.infradead.org; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Vineet.Gupta1@synopsys.com
> > Subject: Re: [PATCH] ARC: Get rid of toolchain check
> >
> > On Thu, Sep 13, 2018 at 3:24 PM Alexey Brodkin
> > <Alexey.Brodkin@synopsys.com> wrote:
> > >
> > > This check is very naive: we simply test if GCC invoked without
> > > "-mcpu=XXX" has ARC700 define set. In that case we think that GCC
> > > was built with "--with-cpu=arc700" and has libgcc built for ARC700.
> > >
> > > Otherwise if ARC700 is not defined we think that everythng was built
> > > for ARCv2.
> > >
> > > But in reality our life is much more interesting.
> > >
> > > 1. Regardless of GCC configuration (i.e. what we pass in "--with-cpu"
> > > it may generate code for any ARC core).
> > >
> > > 2. libgcc might be built with explicitly specified "--mcpu=YYY"
> > >
> > > That's exactly what happens in case of multilibbed toolchains:
> > > - GCC is configured with default settings
> > > - All the libs built for many different CPU flavors
> > >
> > > I.e. that check gets in the way of usage of multilibbed
> > > toolchains. And even non-multilibbed toolchains are affected.
> > > OpenEmbedded also builds GCC without "--with-cpu" because
> > > each and every target component later is compiled with explicitly
> > > set "-mcpu=ZZZ".
> > >
> > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > > ---
> > > arch/arc/Makefile | 14 --------------
> > > 1 file changed, 14 deletions(-)
> >
> > +1 for this. Removing it also helps with my work to be able to build
> > all the .dts files with only a host compiler. That also needs the hunk
> > setting CROSS_COMPILE removed and not having a built-in dtb by
> > default, but this is a step in the right direction.
> >
> > Acked-by: Rob Herring <robh@kernel.org>
>
> May we get this one back-ported to stable trees?
>
> Upstream commit in Linus' tree is
> 615f64458ad8 ("ARC: build: Get rid of toolchain check").
>
> This fixes kernel configuration for ARC in case of missing
> ARC cross-tools in current PATH.
Now queued up, thanks.
greg k-h
next prev parent reply other threads:[~2018-10-18 12:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 20:24 [PATCH] ARC: Get rid of toolchain check Alexey Brodkin
2018-09-13 20:24 ` Alexey Brodkin
2018-09-13 21:04 ` Rob Herring
2018-09-13 21:04 ` Rob Herring
2018-10-17 14:28 ` Alexey Brodkin
2018-10-17 14:28 ` Alexey Brodkin
2018-10-18 12:44 ` gregkh [this message]
2018-10-18 12:44 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018124409.GC1451@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.