From: Rob Herring <robh@kernel.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: hannah@marvell.com, catalin.marinas@arm.com, will.deacon@arm.com,
corbet@lwn.net, joro@8bytes.org, gregory.clement@bootlin.com,
mark.rutland@arm.com, jason@lakedaemon.net, andrew@lunn.ch,
sebastian.hesselbarth@gmail.com, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, omrii@marvell.com,
linux-kernel@vger.kernel.org, nadavh@marvell.com,
iommu@lists.linux-foundation.org, thomas.petazzoni@bootlin.com,
linux-arm-kernel@lists.infradead.org, nd@arm.com
Subject: Re: [PATCH 3/4] dt-bindings: iommu/arm, smmu: add compatible string for Marvell
Date: Thu, 18 Oct 2018 15:48:01 -0500 [thread overview]
Message-ID: <20181018204801.GA2009@bogus> (raw)
In-Reply-To: <3ce1d67a-4e3c-e8d8-f7fc-79649f1def68@arm.com>
On Mon, Oct 15, 2018 at 02:11:52PM +0100, Robin Murphy wrote:
> On 15/10/18 13:00, hannah@marvell.com wrote:
> > From: Hanna Hawa <hannah@marvell.com>
> >
> > Add specific compatible string for Marvell usage due errata of
> > accessing 64bit registers of ARM SMMU, in AP806.
> >
> > AP806 SOC use the generic ARM-MMU500, and there's no specific
> > implementation of Marvell, this compatible is used for errata only.
>
> Given that, I think something more specific like:
>
> "marvell,ap806-smmu", "arm,mmu-500";
>
> would be most appropriate. Otherwise, if some future Marvell SoC were to
> ever come out with a *different* MMU-500 integration problem, you'd already
> have painted yourself into a corner.
>
> Alternatively (or additionally), we could perhaps consider a separate
> property like "marvell,32bit-config-access", to mirror the existing handling
> of the secure integration bug.
The former please. We have learned our lesson there (though for some
reason, that was the *only* SMMU problem in Calxeda Midway ;) ).
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: hannah@marvell.com, catalin.marinas@arm.com, will.deacon@arm.com,
corbet@lwn.net, joro@8bytes.org, gregory.clement@bootlin.com,
mark.rutland@arm.com, jason@lakedaemon.net, andrew@lunn.ch,
sebastian.hesselbarth@gmail.com, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, omrii@marvell.com,
linux-kernel@vger.kernel.org, nadavh@marvell.com,
iommu@lists.linux-foundation.org, thomas.petazzoni@bootlin.com,
linux-arm-kernel@lists.infradead.orgnd@arm.com
Subject: Re: [PATCH 3/4] dt-bindings: iommu/arm, smmu: add compatible string for Marvell
Date: Thu, 18 Oct 2018 15:48:01 -0500 [thread overview]
Message-ID: <20181018204801.GA2009@bogus> (raw)
In-Reply-To: <3ce1d67a-4e3c-e8d8-f7fc-79649f1def68@arm.com>
On Mon, Oct 15, 2018 at 02:11:52PM +0100, Robin Murphy wrote:
> On 15/10/18 13:00, hannah@marvell.com wrote:
> > From: Hanna Hawa <hannah@marvell.com>
> >
> > Add specific compatible string for Marvell usage due errata of
> > accessing 64bit registers of ARM SMMU, in AP806.
> >
> > AP806 SOC use the generic ARM-MMU500, and there's no specific
> > implementation of Marvell, this compatible is used for errata only.
>
> Given that, I think something more specific like:
>
> "marvell,ap806-smmu", "arm,mmu-500";
>
> would be most appropriate. Otherwise, if some future Marvell SoC were to
> ever come out with a *different* MMU-500 integration problem, you'd already
> have painted yourself into a corner.
>
> Alternatively (or additionally), we could perhaps consider a separate
> property like "marvell,32bit-config-access", to mirror the existing handling
> of the secure integration bug.
The former please. We have learned our lesson there (though for some
reason, that was the *only* SMMU problem in Calxeda Midway ;) ).
Rob
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] dt-bindings: iommu/arm, smmu: add compatible string for Marvell
Date: Thu, 18 Oct 2018 15:48:01 -0500 [thread overview]
Message-ID: <20181018204801.GA2009@bogus> (raw)
In-Reply-To: <3ce1d67a-4e3c-e8d8-f7fc-79649f1def68@arm.com>
On Mon, Oct 15, 2018 at 02:11:52PM +0100, Robin Murphy wrote:
> On 15/10/18 13:00, hannah at marvell.com wrote:
> > From: Hanna Hawa <hannah@marvell.com>
> >
> > Add specific compatible string for Marvell usage due errata of
> > accessing 64bit registers of ARM SMMU, in AP806.
> >
> > AP806 SOC use the generic ARM-MMU500, and there's no specific
> > implementation of Marvell, this compatible is used for errata only.
>
> Given that, I think something more specific like:
>
> "marvell,ap806-smmu", "arm,mmu-500";
>
> would be most appropriate. Otherwise, if some future Marvell SoC were to
> ever come out with a *different* MMU-500 integration problem, you'd already
> have painted yourself into a corner.
>
> Alternatively (or additionally), we could perhaps consider a separate
> property like "marvell,32bit-config-access", to mirror the existing handling
> of the secure integration bug.
The former please. We have learned our lesson there (though for some
reason, that was the *only* SMMU problem in Calxeda Midway ;) ).
Rob
next prev parent reply other threads:[~2018-10-18 20:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 12:00 [PATCH 0/4] Add system mmu support for Armada-806 hannah
2018-10-15 12:00 ` hannah at marvell.com
2018-10-15 12:00 ` hannah
2018-10-15 12:00 ` [PATCH 1/4] iommu/arm-smmu: introduce wrapper for writeq/readq hannah
2018-10-15 12:00 ` hannah at marvell.com
2018-10-15 12:00 ` hannah
2018-10-15 12:00 ` [PATCH 2/4] iommu/arm-smmu: Workaround for Marvell Armada-AP806 SoC erratum #582743 hannah
2018-10-15 12:00 ` hannah at marvell.com
2018-10-15 12:00 ` hannah
2018-10-15 13:00 ` Robin Murphy
2018-10-15 13:00 ` Robin Murphy
2018-10-15 13:00 ` Robin Murphy
2018-10-16 8:25 ` Hanna Hawa
2018-10-16 8:25 ` Hanna Hawa
2018-10-16 8:25 ` Hanna Hawa
2018-10-18 16:08 ` Robin Murphy
2018-10-18 16:08 ` Robin Murphy
2018-10-15 12:00 ` [PATCH 3/4] dt-bindings: iommu/arm,smmu: add compatible string for Marvell hannah
2018-10-15 12:00 ` [PATCH 3/4] dt-bindings: iommu/arm, smmu: " hannah at marvell.com
2018-10-15 12:00 ` hannah
2018-10-15 13:11 ` Robin Murphy
2018-10-15 13:11 ` Robin Murphy
2018-10-18 20:48 ` Rob Herring [this message]
2018-10-18 20:48 ` Rob Herring
2018-10-18 20:48 ` Rob Herring
2018-10-15 12:00 ` [PATCH 4/4] arm64: dts: marvell: add smmu node for Armada-AP806 hannah
2018-10-15 12:00 ` hannah at marvell.com
2018-10-15 12:00 ` hannah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018204801.GA2009@bogus \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=hannah@marvell.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jason@lakedaemon.net \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nadavh@marvell.com \
--cc=nd@arm.com \
--cc=omrii@marvell.com \
--cc=robin.murphy@arm.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.