From: Kimberly Brown <kimbrownkd@gmail.com>
To: outreachy-kernel@googlegroups.com
Cc: Steve Longerbeam <slongerbeam@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH] media: imx: capture: Remove unneeded variable
Date: Thu, 18 Oct 2018 21:40:41 -0400 [thread overview]
Message-ID: <20181019014041.GA9250@v> (raw)
Remove local variable 'ret', which is used to store the return value.
It is not changed during function execution. Return the variable's
initial value, 0. Issue found by coccicheck.
Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>
---
drivers/staging/media/imx/imx-media-capture.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/imx/imx-media-capture.c b/drivers/staging/media/imx/imx-media-capture.c
index 256039ce561e..f50f34b59694 100644
--- a/drivers/staging/media/imx/imx-media-capture.c
+++ b/drivers/staging/media/imx/imx-media-capture.c
@@ -536,7 +536,6 @@ static int capture_release(struct file *file)
struct capture_priv *priv = video_drvdata(file);
struct video_device *vfd = priv->vdev.vfd;
struct vb2_queue *vq = &priv->q;
- int ret = 0;
mutex_lock(&priv->mutex);
@@ -549,7 +548,7 @@ static int capture_release(struct file *file)
v4l2_fh_release(file);
mutex_unlock(&priv->mutex);
- return ret;
+ return 0;
}
static const struct v4l2_file_operations capture_fops = {
--
2.17.1
next reply other threads:[~2018-10-19 1:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 1:40 Kimberly Brown [this message]
2018-10-19 7:04 ` [Outreachy kernel] [PATCH] media: imx: capture: Remove unneeded variable Julia Lawall
2018-10-19 9:55 ` Philipp Zabel
2018-10-19 15:57 ` Steve Longerbeam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181019014041.GA9250@v \
--to=kimbrownkd@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=p.zabel@pengutronix.de \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.