[PATCH] media: imx: capture: Remove unneeded variable

[PATCH] media: imx: capture: Remove unneeded variable

[Kimberly Brown]

Remove local variable 'ret', which is used to store the return value.
It is not changed during function execution. Return the variable's
initial value, 0. Issue found by coccicheck.

Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>
---
 drivers/staging/media/imx/imx-media-capture.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/media/imx/imx-media-capture.c b/drivers/staging/media/imx/imx-media-capture.c
index 256039ce561e..f50f34b59694 100644
--- a/drivers/staging/media/imx/imx-media-capture.c
+++ b/drivers/staging/media/imx/imx-media-capture.c
@@ -536,7 +536,6 @@ static int capture_release(struct file *file)
 	struct capture_priv *priv = video_drvdata(file);
 	struct video_device *vfd = priv->vdev.vfd;
 	struct vb2_queue *vq = &priv->q;
-	int ret = 0;
 
 	mutex_lock(&priv->mutex);
 
@@ -549,7 +548,7 @@ static int capture_release(struct file *file)
 
 	v4l2_fh_release(file);
 	mutex_unlock(&priv->mutex);
-	return ret;
+	return 0;
 }
 
 static const struct v4l2_file_operations capture_fops = {
-- 
2.17.1

Re: [Outreachy kernel] [PATCH] media: imx: capture: Remove unneeded variable

[Julia Lawall]

On Thu, 18 Oct 2018, Kimberly Brown wrote:

> Remove local variable 'ret', which is used to store the return value.
> It is not changed during function execution. Return the variable's
> initial value, 0. Issue found by coccicheck.
>
> Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>


> ---
>  drivers/staging/media/imx/imx-media-capture.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-capture.c b/drivers/staging/media/imx/imx-media-capture.c
> index 256039ce561e..f50f34b59694 100644
> --- a/drivers/staging/media/imx/imx-media-capture.c
> +++ b/drivers/staging/media/imx/imx-media-capture.c
> @@ -536,7 +536,6 @@ static int capture_release(struct file *file)
>  	struct capture_priv *priv = video_drvdata(file);
>  	struct video_device *vfd = priv->vdev.vfd;
>  	struct vb2_queue *vq = &priv->q;
> -	int ret = 0;
>
>  	mutex_lock(&priv->mutex);
>
> @@ -549,7 +548,7 @@ static int capture_release(struct file *file)
>
>  	v4l2_fh_release(file);
>  	mutex_unlock(&priv->mutex);
> -	return ret;
> +	return 0;
>  }
>
>  static const struct v4l2_file_operations capture_fops = {
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181019014041.GA9250%40v.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [PATCH] media: imx: capture: Remove unneeded variable

[Philipp Zabel]

Hi Kimberly,

On Thu, 2018-10-18 at 21:40 -0400, Kimberly Brown wrote:
> Remove local variable 'ret', which is used to store the return value.
> It is not changed during function execution. Return the variable's
> initial value, 0. Issue found by coccicheck.
> 
> Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>
> ---
>  drivers/staging/media/imx/imx-media-capture.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/imx/imx-media-capture.c b/drivers/staging/media/imx/imx-media-capture.c
> index 256039ce561e..f50f34b59694 100644
> --- a/drivers/staging/media/imx/imx-media-capture.c
> +++ b/drivers/staging/media/imx/imx-media-capture.c
> @@ -536,7 +536,6 @@ static int capture_release(struct file *file)
>  	struct capture_priv *priv = video_drvdata(file);
>  	struct video_device *vfd = priv->vdev.vfd;
>  	struct vb2_queue *vq = &priv->q;
> -	int ret = 0;
>  
>  	mutex_lock(&priv->mutex);
>  
> @@ -549,7 +548,7 @@ static int capture_release(struct file *file)
>  
>  	v4l2_fh_release(file);
>  	mutex_unlock(&priv->mutex);
> -	return ret;
> +	return 0;
>  }
>  
>  static const struct v4l2_file_operations capture_fops = {

Thank you for the patch,

Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

Re: [PATCH] media: imx: capture: Remove unneeded variable

[Steve Longerbeam]

Acked-by: Steve Longerbeam <slongerbeam@gmail.com>


On 10/18/18 6:40 PM, Kimberly Brown wrote:
> Remove local variable 'ret', which is used to store the return value.
> It is not changed during function execution. Return the variable's
> initial value, 0. Issue found by coccicheck.
>
> Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>
> ---
>   drivers/staging/media/imx/imx-media-capture.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-capture.c b/drivers/staging/media/imx/imx-media-capture.c
> index 256039ce561e..f50f34b59694 100644
> --- a/drivers/staging/media/imx/imx-media-capture.c
> +++ b/drivers/staging/media/imx/imx-media-capture.c
> @@ -536,7 +536,6 @@ static int capture_release(struct file *file)
>   	struct capture_priv *priv = video_drvdata(file);
>   	struct video_device *vfd = priv->vdev.vfd;
>   	struct vb2_queue *vq = &priv->q;
> -	int ret = 0;
>   
>   	mutex_lock(&priv->mutex);
>   
> @@ -549,7 +548,7 @@ static int capture_release(struct file *file)
>   
>   	v4l2_fh_release(file);
>   	mutex_unlock(&priv->mutex);
> -	return ret;
> +	return 0;
>   }
>   
>   static const struct v4l2_file_operations capture_fops = {