From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Mark Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Subject: Re: [PATCH v2 00/15] mtd: maps: physmap cleanups
Date: Mon, 22 Oct 2018 15:41:10 +0200 [thread overview]
Message-ID: <20181022154110.62c0e178@bbrezillon> (raw)
In-Reply-To: <CACRpkdbHDTcz_X_ijV+B-DkahsTWDyW2+h0n4W5o9GU3f6kmrA@mail.gmail.com>
Hi Linus,
On Mon, 22 Oct 2018 13:45:49 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:
> On Fri, Oct 19, 2018 at 9:49 AM Boris Brezillon
> <boris.brezillon@bootlin.com> wrote:
>
> > This is an attempt at merging physmap_of.c, gpio-addr-flash.c and
> > physmap.c. The rational behind this decision is code sharing and
> > consistency with what's done in other parts of the kernel:
> >
> > - physmap_of is just adding OF/DT support to the physmap logic, and we
> > usually put that code in the pre-existing driver instead of creating
> > a new one
> >
> > - gpio-addr-flash is just an extension of the physmap logic which is
> > needed when the platform does not have enough native ADDR lines
> > to address the whole flash. Again, I think this core belongs in the
> > physmap driver
> >
> > Patches 1 to 9 are just cleanups, and are not really related to the
> > merging of physmap_of and gpio-addr-flash into physmap.c.
> >
> > Patch 10 to 13 are doing the actual merging work, and patch 14 is
> > documenting the addr-gpios property that has been added to support
> > the gpio-addr-flash on DT platforms.
> >
> > Patch 15 is a cosmetic change proposed by Ricardo.
>
> This series:
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> I expect to test the result when rebasing my patches for Gemini,
> so hope for this to hit your devel branch after v4.20-rc1.
>
I already have a topic branch [1] in case you want to start working on
it before 4.20-rc1.
Regards,
Boris
[1]https://github.com/bbrezillon/linux-0day/tree/mtd/physmap-cleanup
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Richard Weinberger <richard@nod.at>,
Mark Vasut <marek.vasut@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mtd@lists.infradead.org, Kumar Gala <galak@codeaurora.org>,
Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v2 00/15] mtd: maps: physmap cleanups
Date: Mon, 22 Oct 2018 15:41:10 +0200 [thread overview]
Message-ID: <20181022154110.62c0e178@bbrezillon> (raw)
In-Reply-To: <CACRpkdbHDTcz_X_ijV+B-DkahsTWDyW2+h0n4W5o9GU3f6kmrA@mail.gmail.com>
Hi Linus,
On Mon, 22 Oct 2018 13:45:49 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:
> On Fri, Oct 19, 2018 at 9:49 AM Boris Brezillon
> <boris.brezillon@bootlin.com> wrote:
>
> > This is an attempt at merging physmap_of.c, gpio-addr-flash.c and
> > physmap.c. The rational behind this decision is code sharing and
> > consistency with what's done in other parts of the kernel:
> >
> > - physmap_of is just adding OF/DT support to the physmap logic, and we
> > usually put that code in the pre-existing driver instead of creating
> > a new one
> >
> > - gpio-addr-flash is just an extension of the physmap logic which is
> > needed when the platform does not have enough native ADDR lines
> > to address the whole flash. Again, I think this core belongs in the
> > physmap driver
> >
> > Patches 1 to 9 are just cleanups, and are not really related to the
> > merging of physmap_of and gpio-addr-flash into physmap.c.
> >
> > Patch 10 to 13 are doing the actual merging work, and patch 14 is
> > documenting the addr-gpios property that has been added to support
> > the gpio-addr-flash on DT platforms.
> >
> > Patch 15 is a cosmetic change proposed by Ricardo.
>
> This series:
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> I expect to test the result when rebasing my patches for Gemini,
> so hope for this to hit your devel branch after v4.20-rc1.
>
I already have a topic branch [1] in case you want to start working on
it before 4.20-rc1.
Regards,
Boris
[1]https://github.com/bbrezillon/linux-0day/tree/mtd/physmap-cleanup
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2018-10-22 13:41 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 7:48 [PATCH v2 00/15] mtd: maps: physmap cleanups Boris Brezillon
2018-10-19 7:48 ` Boris Brezillon
2018-10-19 7:48 ` [PATCH v2 01/15] mtd: maps: physmap: Add SPDX header Boris Brezillon
2018-10-19 7:48 ` Boris Brezillon
2018-10-19 7:48 ` [PATCH v2 02/15] mtd: maps: physmap: Rename ->map and ->mtd into ->maps and ->mtds Boris Brezillon
2018-10-19 7:48 ` Boris Brezillon
2018-10-19 7:48 ` [PATCH v2 03/15] mtd: maps: physmap: Use platform_get_resource() to retrieve iomem resources Boris Brezillon
2018-10-19 7:48 ` Boris Brezillon
2018-10-19 7:48 ` [PATCH v2 04/15] mtd: maps: physmap: Use dev_notice() and a %pR specifier Boris Brezillon
2018-10-19 7:48 ` Boris Brezillon
2018-10-19 7:48 ` [PATCH v2 05/15] mtd: maps: physmap: Use devm_ioremap_resource() Boris Brezillon
2018-10-19 7:48 ` Boris Brezillon
2018-10-19 7:48 ` [PATCH v2 06/15] mtd: maps: physmap: Remove the MAX_RESOURCES limitation Boris Brezillon
2018-10-19 7:48 ` Boris Brezillon
2018-10-19 7:49 ` [PATCH v2 07/15] mtd: maps: physmap: Check mtd_device_{parse_register, unregister}() ret code Boris Brezillon
2018-10-19 7:49 ` Boris Brezillon
2018-10-19 7:49 ` [PATCH v2 08/15] mtd: maps: physmap: Return -ENOMEM directly when info allocation fails Boris Brezillon
2018-10-19 7:49 ` Boris Brezillon
2018-10-19 7:49 ` [PATCH v2 09/15] mtd: maps: physmap: Fix coding style issues reported by checkpatch Boris Brezillon
2018-10-19 7:49 ` Boris Brezillon
2018-10-19 7:49 ` [PATCH v2 10/15] mtd: maps: Prepare merging of physmap and physmap_of Boris Brezillon
2018-10-19 7:49 ` Boris Brezillon
2018-10-19 7:49 ` [PATCH v2 11/15] mtd: maps: Merge physmap_of.c into physmap-core.c Boris Brezillon
2018-10-19 7:49 ` Boris Brezillon
2019-04-02 23:44 ` [v2,11/15] " Chris Packham
2019-04-03 2:02 ` [PATCH] mtd: maps: Allow MTD_PHYSMAP with MTD_RAM Chris Packham
2019-04-03 2:02 ` Chris Packham
2019-05-01 18:02 ` [v2,11/15] mtd: maps: Merge physmap_of.c into physmap-core.c Li Yang
2018-10-19 7:49 ` [PATCH v2 12/15] mtd: maps: Rename physmap_of_{versatile, gemini} into physmap-{versatile, gemini} Boris Brezillon
2018-10-19 7:49 ` Boris Brezillon
2018-10-19 7:49 ` [PATCH v2 13/15] dt-binding: mtd: physmap: Document the addr-gpios property Boris Brezillon
2018-10-19 7:49 ` Boris Brezillon
2018-10-24 18:38 ` Rob Herring
2018-10-24 18:38 ` Rob Herring
2018-10-31 10:49 ` Linus Walleij
2018-10-31 10:49 ` Linus Walleij
2018-10-19 7:49 ` [PATCH v2 14/15] mtd: maps: Merge gpio-addr-flash.c into physmap-core.c Boris Brezillon
2018-10-19 7:49 ` Boris Brezillon
2018-10-19 7:49 ` [PATCH v2 15/15] mtd: maps: physmap: Invert logic on if/else branch Boris Brezillon
2018-10-19 7:49 ` Boris Brezillon
2018-10-22 11:45 ` [PATCH v2 00/15] mtd: maps: physmap cleanups Linus Walleij
2018-10-22 11:45 ` Linus Walleij
2018-10-22 13:41 ` Boris Brezillon [this message]
2018-10-22 13:41 ` Boris Brezillon
2018-11-05 21:27 ` Boris Brezillon
2018-11-05 21:27 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181022154110.62c0e178@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=ricardo.ribalda@gmail.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.