From: robh@kernel.org (Rob Herring)
To: linux-riscv@lists.infradead.org
Subject: [PATCH v2] OF: Handle CMDLINE when /chosen node is not present
Date: Mon, 22 Oct 2018 17:42:13 -0500 [thread overview]
Message-ID: <20181022224213.GA25145@bogus> (raw)
In-Reply-To: <20181015142010.13401-1-mick@ics.forth.gr>
On Mon, Oct 15, 2018 at 05:20:10PM +0300, Nick Kossifidis wrote:
> The /chosen node is optional so we should handle CMDLINE regardless
> the presence of /chosen/bootargs. Move handling of CMDLINE in
> early_init_dt_scan() instead.
I looked at this a while back. I'm not sure this behavior can be changed
without breaking some MIPS platforms that could be relying on the
current behavior. But trying to make sense of the MIPS code is a
challenge and they have some other issues in this area.
Can't this be fixed by making /chosen manditory? I'd expect ultimately
you are always going to need it.
I'd rather not resort to making this per arch. There's also some effort
to consolidate cmd line handling[1].
Rob
[1] https://lkml.org/lkml/2018/9/27/1099
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Nick Kossifidis <mick@ics.forth.gr>
Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
palmer@sifive.com, frowand.list@gmail.com
Subject: Re: [PATCH v2] OF: Handle CMDLINE when /chosen node is not present
Date: Mon, 22 Oct 2018 17:42:13 -0500 [thread overview]
Message-ID: <20181022224213.GA25145@bogus> (raw)
Message-ID: <20181022224213.CwDWmk4aGpUpRrXEX4TL-KjQSKbvVhzhnT9fksIW38A@z> (raw)
In-Reply-To: <20181015142010.13401-1-mick@ics.forth.gr>
On Mon, Oct 15, 2018 at 05:20:10PM +0300, Nick Kossifidis wrote:
> The /chosen node is optional so we should handle CMDLINE regardless
> the presence of /chosen/bootargs. Move handling of CMDLINE in
> early_init_dt_scan() instead.
I looked at this a while back. I'm not sure this behavior can be changed
without breaking some MIPS platforms that could be relying on the
current behavior. But trying to make sense of the MIPS code is a
challenge and they have some other issues in this area.
Can't this be fixed by making /chosen manditory? I'd expect ultimately
you are always going to need it.
I'd rather not resort to making this per arch. There's also some effort
to consolidate cmd line handling[1].
Rob
[1] https://lkml.org/lkml/2018/9/27/1099
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Nick Kossifidis <mick@ics.forth.gr>
Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
palmer@sifive.com, frowand.list@gmail.com
Subject: Re: [PATCH v2] OF: Handle CMDLINE when /chosen node is not present
Date: Mon, 22 Oct 2018 17:42:13 -0500 [thread overview]
Message-ID: <20181022224213.GA25145@bogus> (raw)
In-Reply-To: <20181015142010.13401-1-mick@ics.forth.gr>
On Mon, Oct 15, 2018 at 05:20:10PM +0300, Nick Kossifidis wrote:
> The /chosen node is optional so we should handle CMDLINE regardless
> the presence of /chosen/bootargs. Move handling of CMDLINE in
> early_init_dt_scan() instead.
I looked at this a while back. I'm not sure this behavior can be changed
without breaking some MIPS platforms that could be relying on the
current behavior. But trying to make sense of the MIPS code is a
challenge and they have some other issues in this area.
Can't this be fixed by making /chosen manditory? I'd expect ultimately
you are always going to need it.
I'd rather not resort to making this per arch. There's also some effort
to consolidate cmd line handling[1].
Rob
[1] https://lkml.org/lkml/2018/9/27/1099
next prev parent reply other threads:[~2018-10-22 22:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 14:20 [PATCH v2] OF: Handle CMDLINE when /chosen node is not present Nick Kossifidis
2018-10-15 14:20 ` Nick Kossifidis
2018-10-15 14:20 ` Nick Kossifidis
2018-10-22 22:42 ` Rob Herring [this message]
2018-10-22 22:42 ` Rob Herring
2018-10-22 22:42 ` Rob Herring
2018-10-22 22:55 ` Palmer Dabbelt
2018-10-22 22:55 ` Palmer Dabbelt
2018-10-22 22:55 ` Palmer Dabbelt
2018-10-22 22:55 ` Palmer Dabbelt
2018-10-23 14:30 ` Rob Herring
2018-10-23 14:30 ` Rob Herring
2018-10-23 14:30 ` Rob Herring
2018-10-23 14:30 ` Rob Herring
2018-10-24 13:32 ` Nick Kossifidis
2018-10-24 13:32 ` Nick Kossifidis
2018-10-24 13:32 ` Nick Kossifidis
2018-10-24 21:06 ` Rob Herring
2018-10-24 21:06 ` Rob Herring
2018-10-24 21:06 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181022224213.GA25145@bogus \
--to=robh@kernel.org \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.