From: Kimberly Brown <kimbrownkd@gmail.com>
To: outreachy-kernel@googlegroups.com
Cc: devel@driverdev.osuosl.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
NeilBrown <neil@brown.name>,
linux-mediatek@lists.infradead.org,
"Kimberly Brown" <kimbrownkd@gmail.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Christian Lütke-Stetzkamp" <christian@lkamp.de>,
linux-arm-kernel@lists.infradead.org,
"John Crispin" <blogic@openwrt.org>
Subject: [PATCH v2] staging: mt7621-dma: Add braces around else branches
Date: Wed, 24 Oct 2018 00:56:53 -0400 [thread overview]
Message-ID: <20181024045653.GA2864@v> (raw)
In-Reply-To: <20181023211142.GA2661@v>
Add braces around else branches in conditional statements that include
branches with multiple statements. This style complies with the Linux
kernel coding style and improves consistency and readability. Issues found by
checkpatch.
Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
---
Changes in v2:
- Added people and mailing lists from get_maintainer.pl to the CC list
- Added Reviewed-by line
drivers/staging/mt7621-dma/mtk-hsdma.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
index df6ebf41bdea..35556f024aa1 100644
--- a/drivers/staging/mt7621-dma/mtk-hsdma.c
+++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
@@ -418,8 +418,9 @@ static void mtk_hsdma_chan_done(struct mtk_hsdam_engine *hsdma,
vchan_cookie_complete(&desc->vdesc);
chan_issued = gdma_next_desc(chan);
}
- } else
+ } else {
dev_dbg(hsdma->ddev.dev, "no desc to complete\n");
+ }
if (chan_issued)
set_bit(chan->id, &hsdma->chan_issued);
@@ -456,8 +457,9 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
if (gdma_next_desc(chan)) {
set_bit(chan->id, &hsdma->chan_issued);
tasklet_schedule(&hsdma->task);
- } else
+ } else {
dev_dbg(hsdma->ddev.dev, "no desc to issue\n");
+ }
}
spin_unlock_bh(&chan->vchan.lock);
}
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Kimberly Brown <kimbrownkd@gmail.com>
To: outreachy-kernel@googlegroups.com
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
NeilBrown <neil@brown.name>,
"Christian Lütke-Stetzkamp" <christian@lkamp.de>,
"Kimberly Brown" <kimbrownkd@gmail.com>,
"John Crispin" <blogic@openwrt.org>,
devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: [PATCH v2] staging: mt7621-dma: Add braces around else branches
Date: Wed, 24 Oct 2018 00:56:53 -0400 [thread overview]
Message-ID: <20181024045653.GA2864@v> (raw)
In-Reply-To: <20181023211142.GA2661@v>
Add braces around else branches in conditional statements that include
branches with multiple statements. This style complies with the Linux
kernel coding style and improves consistency and readability. Issues found by
checkpatch.
Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
---
Changes in v2:
- Added people and mailing lists from get_maintainer.pl to the CC list
- Added Reviewed-by line
drivers/staging/mt7621-dma/mtk-hsdma.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
index df6ebf41bdea..35556f024aa1 100644
--- a/drivers/staging/mt7621-dma/mtk-hsdma.c
+++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
@@ -418,8 +418,9 @@ static void mtk_hsdma_chan_done(struct mtk_hsdam_engine *hsdma,
vchan_cookie_complete(&desc->vdesc);
chan_issued = gdma_next_desc(chan);
}
- } else
+ } else {
dev_dbg(hsdma->ddev.dev, "no desc to complete\n");
+ }
if (chan_issued)
set_bit(chan->id, &hsdma->chan_issued);
@@ -456,8 +457,9 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
if (gdma_next_desc(chan)) {
set_bit(chan->id, &hsdma->chan_issued);
tasklet_schedule(&hsdma->task);
- } else
+ } else {
dev_dbg(hsdma->ddev.dev, "no desc to issue\n");
+ }
}
spin_unlock_bh(&chan->vchan.lock);
}
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: kimbrownkd@gmail.com (Kimberly Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] staging: mt7621-dma: Add braces around else branches
Date: Wed, 24 Oct 2018 00:56:53 -0400 [thread overview]
Message-ID: <20181024045653.GA2864@v> (raw)
In-Reply-To: <20181023211142.GA2661@v>
Add braces around else branches in conditional statements that include
branches with multiple statements. This style complies with the Linux
kernel coding style and improves consistency and readability. Issues found by
checkpatch.
Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
---
Changes in v2:
- Added people and mailing lists from get_maintainer.pl to the CC list
- Added Reviewed-by line
drivers/staging/mt7621-dma/mtk-hsdma.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
index df6ebf41bdea..35556f024aa1 100644
--- a/drivers/staging/mt7621-dma/mtk-hsdma.c
+++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
@@ -418,8 +418,9 @@ static void mtk_hsdma_chan_done(struct mtk_hsdam_engine *hsdma,
vchan_cookie_complete(&desc->vdesc);
chan_issued = gdma_next_desc(chan);
}
- } else
+ } else {
dev_dbg(hsdma->ddev.dev, "no desc to complete\n");
+ }
if (chan_issued)
set_bit(chan->id, &hsdma->chan_issued);
@@ -456,8 +457,9 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
if (gdma_next_desc(chan)) {
set_bit(chan->id, &hsdma->chan_issued);
tasklet_schedule(&hsdma->task);
- } else
+ } else {
dev_dbg(hsdma->ddev.dev, "no desc to issue\n");
+ }
}
spin_unlock_bh(&chan->vchan.lock);
}
--
2.17.1
next prev parent reply other threads:[~2018-10-24 4:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 21:11 [PATCH] staging: mt7621-dma: Add braces around else branches Kimberly Brown
2018-10-23 21:22 ` Matthias Brugger
2018-10-23 21:25 ` Matthias Brugger
2018-10-24 4:56 ` Kimberly Brown [this message]
2018-10-24 4:56 ` [PATCH v2] " Kimberly Brown
2018-10-24 4:56 ` Kimberly Brown
2018-10-24 10:45 ` Matthias Brugger
2018-10-24 10:45 ` Matthias Brugger
2018-10-24 10:45 ` Matthias Brugger
2018-10-24 11:07 ` Russell King - ARM Linux
2018-10-24 11:07 ` Russell King - ARM Linux
2018-10-24 11:07 ` Russell King - ARM Linux
2018-10-24 13:06 ` [Outreachy kernel] " Julia Lawall
2018-10-24 13:06 ` Julia Lawall
2018-10-24 13:06 ` Julia Lawall
2018-10-24 13:14 ` Russell King - ARM Linux
2018-10-24 13:14 ` Russell King - ARM Linux
2018-10-24 13:14 ` Russell King - ARM Linux
2018-10-24 11:09 ` Dan Carpenter
2018-10-24 11:09 ` Dan Carpenter
2018-10-24 11:09 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024045653.GA2864@v \
--to=kimbrownkd@gmail.com \
--cc=blogic@openwrt.org \
--cc=christian@lkamp.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=neil@brown.name \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.