* [U-Boot] efi: utf8_utf16_strncpy?
@ 2018-10-24 8:39 AKASHI Takahiro
0 siblings, 0 replies; only message in thread
From: AKASHI Takahiro @ 2018-10-24 8:39 UTC (permalink / raw)
To: u-boot
Hi Heinrich,
Why is the type of the first argument of utf8_utf16_str(n)cpy()
"u16 **", not "u16 *"?
(same issue against utf16_utf8_strncpy())
It's quit confusing, even causing an easy mistake since
it differs from normal strcpy().
What is worse is that we may need additional variable, which is never used,
to avoid unnecessary update of pointer. In all occurrences in current efi
implementation, there is no user of an updated pointer.
Thanks,
-Takahiro Akashi
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-10-24 8:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-24 8:39 [U-Boot] efi: utf8_utf16_strncpy? AKASHI Takahiro
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.