From: Andi Kleen <ak@linux.intel.com>
To: kan.liang@linux.intel.com
Cc: peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com,
acme@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de,
eranian@google.com
Subject: Re: [PATCH 1/2] perf: Add munmap callback
Date: Wed, 24 Oct 2018 09:23:34 -0700 [thread overview]
Message-ID: <20181024162334.GG6218@tassilo.jf.intel.com> (raw)
In-Reply-To: <20181024151116.30935-1-kan.liang@linux.intel.com>
> +void perf_event_munmap(void)
> +{
> + struct perf_cpu_context *cpuctx;
> + unsigned long flags;
> + struct pmu *pmu;
> +
> + local_irq_save(flags);
> + list_for_each_entry(cpuctx, this_cpu_ptr(&sched_cb_list), sched_cb_entry) {
Would be good have a fast path here that checks for the list being empty
without disabling the interrupts. munmap can be somewhat hot. I think
it's ok to make it slower with perf running, but we shouldn't impact
it without perf.
-Andi
next prev parent reply other threads:[~2018-10-24 16:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 15:11 [PATCH 1/2] perf: Add munmap callback kan.liang
2018-10-24 15:11 ` [PATCH 2/2] perf/x86/intel: Fix missing physical address in large PEBS kan.liang
2018-10-24 16:23 ` Andi Kleen [this message]
2018-10-24 16:32 ` [PATCH 1/2] perf: Add munmap callback Arnaldo Carvalho de Melo
2018-10-24 18:12 ` Liang, Kan
2018-10-24 18:28 ` Andi Kleen
2018-10-25 0:31 ` Peter Zijlstra
2018-10-24 19:15 ` Arnaldo Carvalho de Melo
2018-10-24 19:30 ` Stephane Eranian
2018-10-25 0:23 ` Peter Zijlstra
2018-10-25 0:25 ` Stephane Eranian
2018-10-25 0:34 ` Peter Zijlstra
2018-10-25 0:44 ` Stephane Eranian
2018-11-01 14:09 ` Liang, Kan
2018-11-05 10:59 ` Stephane Eranian
2018-11-05 15:43 ` Liang, Kan
2018-11-06 15:00 ` Stephane Eranian
2018-11-06 16:47 ` Liang, Kan
2018-10-25 0:29 ` Peter Zijlstra
2018-10-25 14:00 ` Liang, Kan
2018-10-30 12:51 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024162334.GG6218@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=bp@alien8.de \
--cc=eranian@google.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.