[PATCH 1/2] nvme-cli wdc plugin: Add get pfail dump command.

[keith.busch@intel.com (Keith Busch)]

On Thu, Oct 25, 2018@03:58:00PM +0000, Jeffrey Lien wrote:
> How does this look?   I've verified it on my Ubuntu system, but don't have a Fedora 28 system to verify the warning message has been resolved.
> 
> diff --git a/wdc-nvme.c b/wdc-nvme.c
> index 55b2889..db68d58 100644
> --- a/wdc-nvme.c
> +++ b/wdc-nvme.c
> @@ -1141,16 +1141,16 @@ static int wdc_do_crash_dump(int fd, char *file, int type)
>  static int wdc_crash_dump(int fd, char *file, int type)
>  {
>  	char f[PATH_MAX] = {0};
> -	char dump_type[PATH_MAX] = {0};
> +	char dump_type[12] = {0};
>  
>  	if (file != NULL) {
>  		strncpy(f, file, PATH_MAX - 1);
>  	}
>  
>  	if (type == WDC_NVME_PFAIL_DUMP_TYPE)
> -		strncpy(dump_type, "_pfail_dump", 11);
> +		strcpy(dump_type, "_pfail_dump");
>  	else
> -		strncpy(dump_type, "_crash_dump", 11);
> +		strcpy(dump_type, "_crash_dump");
>  
>  	if (wdc_get_serial_name(fd, f, PATH_MAX, dump_type) == -1) {
>  		fprintf(stderr, "ERROR : WDC : failed to generate file name\n");
> -- 

I just don't see the point in having multiple copies of the string. Why
not just use it directly?

---
diff --git a/plugins/wdc/wdc-nvme.c b/plugins/wdc/wdc-nvme.c
index 8d61fa7..cd12edb 100644
--- a/plugins/wdc/wdc-nvme.c
+++ b/plugins/wdc/wdc-nvme.c
@@ -1141,16 +1141,16 @@ static int wdc_do_crash_dump(int fd, char *file, int type)
 static int wdc_crash_dump(int fd, char *file, int type)
 {
 	char f[PATH_MAX] = {0};
-	char dump_type[PATH_MAX] = {0};
+	char *dump_type;
 
 	if (file != NULL) {
 		strncpy(f, file, PATH_MAX - 1);
 	}
 
 	if (type == WDC_NVME_PFAIL_DUMP_TYPE)
-		strncpy(dump_type, "_pfail_dump", PATH_MAX - 1);
+		dump_type = "_pfail_dump";
 	else
-		strncpy(dump_type, "_crash_dump", PATH_MAX - 1);
+		dump_type = "_crash_dump";
 
 	if (wdc_get_serial_name(fd, f, PATH_MAX, dump_type) == -1) {
 		fprintf(stderr, "ERROR : WDC : failed to generate file name\n");
--