All of lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 1/2] nvme-cli wdc plugin: Add get pfail dump command.
Date: Thu, 25 Oct 2018 12:02:43 -0600	[thread overview]
Message-ID: <20181025180243.GC7035@localhost.localdomain> (raw)
In-Reply-To: <SN1PR04MB1984D99829C68D3A2B8CAA76EAF70@SN1PR04MB1984.namprd04.prod.outlook.com>

On Thu, Oct 25, 2018@05:47:24PM +0000, Jeffrey Lien wrote:
> Keith, 
> Here's an updated patch, or just apply the version you had below.   They are identical.   Sorry for misunderstanding what you were trying to suggest.   

Okay, no problem. I'll go one step further and make this a 'const
char*' and update wdc_get_serial_name to declare the suffix as 'const'
since that is how it is used. My compiler didn't complain either way,
but I suspect some setting might not like casting a string literal to
a non-const pointer.

      reply	other threads:[~2018-10-25 18:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-18 21:06 [PATCH 1/2] nvme-cli wdc plugin: Add get pfail dump command Dong Ho
2018-10-18 21:06 ` [PATCH 2/2] nvme-cli wdc plugin: Add documentation for pfail dump Dong Ho
2018-10-19 17:17 ` [PATCH 1/2] nvme-cli wdc plugin: Add get pfail dump command Keith Busch
2018-10-24 16:10   ` Eyal BenDavid
2018-10-24 16:22     ` Keith Busch
2018-10-24 16:28       ` Eyal BenDavid
2018-10-24 21:42         ` Jeffrey Lien
2018-10-24 21:51           ` Keith Busch
2018-10-24 22:19             ` Chaitanya Kulkarni
2018-10-25 15:58               ` Jeffrey Lien
2018-10-25 16:00                 ` Keith Busch
2018-10-25 17:25                   ` Jeffrey Lien
2018-10-25 17:28                   ` Jeffrey Lien
2018-10-25 17:47                   ` Jeffrey Lien
2018-10-25 18:02                     ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181025180243.GC7035@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.