From: Baoquan He <bhe@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: lijiang <lijiang@redhat.com>, Petr Tesarik <ptesarik@suse.cz>,
x86@kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, mingo@redhat.com,
tglx@linutronix.de, dyoung@redhat.com
Subject: Re: [PATCH] kdump, vmcoreinfo: Export sme_me_mask value to vmcoreinfo
Date: Sat, 27 Oct 2018 19:08:58 +0800 [thread overview]
Message-ID: <20181027110858.GB14493@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20181027101221.GC1046@nazgul.tnic>
On 10/27/18 at 12:12pm, Borislav Petkov wrote:
> On Sat, Oct 27, 2018 at 05:39:17PM +0800, Baoquan He wrote:
> > Not very sure about this, we have arch_crash_save_vmcoreinfo() in
> > arch/x86/kernel/machine_kexec_64.c to export arch-specific stuffs
> > outside. Is there any special reason about a mask in one architecture
> > when expose it out?
>
> Yes, we don't export random arch-specific details to the outside which
> we then cannot change later. So vmcoreinfo needs to define its own.
OK, then it's fine to get the bit number, e.g calling
find_first_bit(sme_me_mask, BITS_PER_LONG), and export it to
vmcoreinfo. Thanks.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Petr Tesarik <ptesarik@suse.cz>, lijiang <lijiang@redhat.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
kexec@lists.infradead.org, mingo@redhat.com, tglx@linutronix.de,
dyoung@redhat.com
Subject: Re: [PATCH] kdump, vmcoreinfo: Export sme_me_mask value to vmcoreinfo
Date: Sat, 27 Oct 2018 19:08:58 +0800 [thread overview]
Message-ID: <20181027110858.GB14493@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20181027101221.GC1046@nazgul.tnic>
On 10/27/18 at 12:12pm, Borislav Petkov wrote:
> On Sat, Oct 27, 2018 at 05:39:17PM +0800, Baoquan He wrote:
> > Not very sure about this, we have arch_crash_save_vmcoreinfo() in
> > arch/x86/kernel/machine_kexec_64.c to export arch-specific stuffs
> > outside. Is there any special reason about a mask in one architecture
> > when expose it out?
>
> Yes, we don't export random arch-specific details to the outside which
> we then cannot change later. So vmcoreinfo needs to define its own.
OK, then it's fine to get the bit number, e.g calling
find_first_bit(sme_me_mask, BITS_PER_LONG), and export it to
vmcoreinfo. Thanks.
next prev parent reply other threads:[~2018-10-27 11:09 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 9:36 [PATCH] kdump, vmcoreinfo: Export sme_me_mask value to vmcoreinfo Lianbo Jiang
2018-10-26 9:36 ` Lianbo Jiang
2018-10-26 9:43 ` Boris Petkov
2018-10-26 9:43 ` Boris Petkov
2018-10-26 12:32 ` lijiang
2018-10-26 12:32 ` lijiang
2018-10-26 16:24 ` Petr Tesarik
2018-10-26 16:24 ` Petr Tesarik
2018-10-26 22:25 ` Borislav Petkov
2018-10-26 22:25 ` Borislav Petkov
2018-10-27 2:57 ` lijiang
2018-10-27 2:57 ` lijiang
2018-10-27 8:13 ` Baoquan He
2018-10-27 8:13 ` Baoquan He
2018-10-27 9:10 ` Borislav Petkov
2018-10-27 9:10 ` Borislav Petkov
2018-10-27 9:39 ` Baoquan He
2018-10-27 9:39 ` Baoquan He
2018-10-27 10:12 ` Borislav Petkov
2018-10-27 10:12 ` Borislav Petkov
2018-10-27 11:08 ` Baoquan He [this message]
2018-10-27 11:08 ` Baoquan He
2018-10-27 13:17 ` Boris Petkov
2018-10-27 13:17 ` Boris Petkov
2018-10-27 14:41 ` lijiang
2018-10-27 14:41 ` lijiang
2018-10-27 14:51 ` Borislav Petkov
2018-10-27 14:51 ` Borislav Petkov
2018-10-29 7:59 ` lijiang
2018-10-29 7:59 ` lijiang
2018-10-29 8:31 ` Baoquan He
2018-10-29 8:31 ` Baoquan He
2018-10-29 9:29 ` lijiang
2018-10-29 9:29 ` lijiang
2018-10-29 9:57 ` Borislav Petkov
2018-10-29 9:57 ` Borislav Petkov
2018-10-29 10:12 ` lijiang
2018-10-29 10:12 ` lijiang
2018-10-29 11:44 ` Baoquan He
2018-10-29 11:44 ` Baoquan He
2018-10-29 13:41 ` lijiang
2018-10-29 13:41 ` lijiang
2018-10-29 13:49 ` Borislav Petkov
2018-10-29 13:49 ` Borislav Petkov
2018-10-30 4:46 ` lijiang
2018-10-30 4:46 ` lijiang
2018-10-30 5:09 ` Dave Young
2018-10-30 5:09 ` Dave Young
2018-10-30 9:15 ` Borislav Petkov
2018-10-30 9:15 ` Borislav Petkov
2018-10-30 9:23 ` Baoquan He
2018-10-30 9:23 ` Baoquan He
2018-10-31 2:26 ` lijiang
2018-10-31 2:26 ` lijiang
2018-10-31 2:47 ` Dave Young
2018-10-31 2:47 ` Dave Young
2018-10-31 7:43 ` lijiang
2018-10-31 7:43 ` lijiang
2018-10-31 10:10 ` Borislav Petkov
2018-10-31 10:10 ` Borislav Petkov
2018-11-01 15:01 ` Kazuhito Hagio
2018-11-01 15:01 ` Kazuhito Hagio
2018-10-26 16:35 ` Borislav Petkov
2018-10-26 16:35 ` Borislav Petkov
2018-10-27 2:19 ` lijiang
2018-10-27 2:19 ` lijiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181027110858.GB14493@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=lijiang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ptesarik@suse.cz \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.