From: Sasha Levin <sashal@kernel.org>
To: Dafna Hirschfeld <dafna3@gmail.com>
Cc: helen.koike@collabora.com, hverkuil@xs4all.nl,
mchehab@kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH vicodec 1/1] media: vicodec: Add empty callbacks to prepare for the request API
Date: Sat, 27 Oct 2018 19:41:34 -0400 [thread overview]
Message-ID: <20181027234134.GK2015@sasha-vm> (raw)
In-Reply-To: <fb11134ccd7459f5b88f277f52f40b6a1f901bc7.1540672323.git.dafna3@gmail.com>
On Sat, Oct 27, 2018 at 11:37:19PM +0300, Dafna Hirschfeld wrote:
>Add the callbacks `_req_validate` `_req_queue` of the struct
>`media_device_ops` as empty functions.
>Those will be implemented later.
Hi Dafna,
In general, unless it's a very complicated functionality, we usually
don't add code that doesn't have any users.
It's fine to do it as part of a patchset where the usage comes in later
patches, but in cases such as these where there are no users,
maintainers will usually not take the patch.
--
Thanks,
Sasha
next prev parent reply other threads:[~2018-10-27 23:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 20:37 [PATCH vicodec 1/1] media: vicodec: Add empty callbacks to prepare for the request API Dafna Hirschfeld
2018-10-27 20:42 ` [Outreachy kernel] " Julia Lawall
2018-10-27 23:41 ` Sasha Levin [this message]
2018-10-28 5:25 ` Julia Lawall
2018-10-28 10:23 ` Hans Verkuil
2018-10-29 9:53 ` Hans Verkuil
2018-10-29 12:42 ` [PATCH vicodec v2] " Dafna Hirschfeld
2018-10-29 22:14 ` Helen Koike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181027234134.GK2015@sasha-vm \
--to=sashal@kernel.org \
--cc=dafna3@gmail.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.