[PATCH vicodec 1/1] media: vicodec: Add empty callbacks to prepare for the request API

[PATCH vicodec 1/1] media: vicodec: Add empty callbacks to prepare for the request API

[Dafna Hirschfeld]

Add the callbacks `_req_validate` `_req_queue` of the struct
`media_device_ops` as empty functions.
Those will be implemented later.

Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>
---
 drivers/media/platform/vicodec/vicodec-core.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/media/platform/vicodec/vicodec-core.c b/drivers/media/platform/vicodec/vicodec-core.c
index fdd77441a47b..238a59cdf3d6 100644
--- a/drivers/media/platform/vicodec/vicodec-core.c
+++ b/drivers/media/platform/vicodec/vicodec-core.c
@@ -130,6 +130,20 @@ struct vicodec_ctx {
 	bool			comp_has_next_frame;
 };
 
+static int vicodec_request_validate(struct media_request *req)
+{
+	return 0;
+}
+
+void vicodec_request_queue(struct media_request *req)
+{
+}
+
+static const struct media_device_ops vicodec_m2m_media_ops = {
+	.req_validate   = vicodec_request_validate,
+	.req_queue      = vicodec_request_queue,
+};
+
 static inline struct vicodec_ctx *file2ctx(struct file *file)
 {
 	return container_of(file->private_data, struct vicodec_ctx, fh);
-- 
2.17.1

Re: [Outreachy kernel] [PATCH vicodec 1/1] media: vicodec: Add empty callbacks to prepare for the request API

[Julia Lawall]

On Sat, 27 Oct 2018, Dafna Hirschfeld wrote:

> Add the callbacks `_req_validate` `_req_queue` of the struct
> `media_device_ops` as empty functions.
> Those will be implemented later.
>
> Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>
> ---
>  drivers/media/platform/vicodec/vicodec-core.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/drivers/media/platform/vicodec/vicodec-core.c b/drivers/media/platform/vicodec/vicodec-core.c
> index fdd77441a47b..238a59cdf3d6 100644
> --- a/drivers/media/platform/vicodec/vicodec-core.c
> +++ b/drivers/media/platform/vicodec/vicodec-core.c
> @@ -130,6 +130,20 @@ struct vicodec_ctx {
>  	bool			comp_has_next_frame;
>  };
>
> +static int vicodec_request_validate(struct media_request *req)
> +{
> +	return 0;
> +}
> +
> +void vicodec_request_queue(struct media_request *req)
> +{
> +}
> +
> +static const struct media_device_ops vicodec_m2m_media_ops = {
> +	.req_validate   = vicodec_request_validate,
> +	.req_queue      = vicodec_request_queue,
> +};
> +

Thanks for making it const :)

julia

>  static inline struct vicodec_ctx *file2ctx(struct file *file)
>  {
>  	return container_of(file->private_data, struct vicodec_ctx, fh);
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/fb11134ccd7459f5b88f277f52f40b6a1f901bc7.1540672323.git.dafna3%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH vicodec 1/1] media: vicodec: Add empty callbacks to prepare for the request API

[Sasha Levin]

On Sat, Oct 27, 2018 at 11:37:19PM +0300, Dafna Hirschfeld wrote:
>Add the callbacks `_req_validate` `_req_queue` of the struct
>`media_device_ops` as empty functions.
>Those will be implemented later.

Hi Dafna,

In general, unless it's a very complicated functionality, we usually
don't add code that doesn't have any users.

It's fine to do it as part of a patchset where the usage comes in later
patches, but in cases such as these where there are no users,
maintainers will usually not take the patch.

--
Thanks,
Sasha

Re: [Outreachy kernel] [PATCH vicodec 1/1] media: vicodec: Add empty callbacks to prepare for the request API

[Julia Lawall]

On Sat, 27 Oct 2018, Sasha Levin wrote:

> On Sat, Oct 27, 2018 at 11:37:19PM +0300, Dafna Hirschfeld wrote:
> > Add the callbacks `_req_validate` `_req_queue` of the struct
> > `media_device_ops` as empty functions.
> > Those will be implemented later.
>
> Hi Dafna,
>
> In general, unless it's a very complicated functionality, we usually
> don't add code that doesn't have any users.
>
> It's fine to do it as part of a patchset where the usage comes in later
> patches, but in cases such as these where there are no users,
> maintainers will usually not take the patch.

I guess she was asked to do this as a small task by the video people?

julia

Re: [Outreachy kernel] [PATCH vicodec 1/1] media: vicodec: Add empty callbacks to prepare for the request API

[Hans Verkuil]

On 10/28/2018 06:25 AM, Julia Lawall wrote:
> 
> 
> On Sat, 27 Oct 2018, Sasha Levin wrote:
> 
>> On Sat, Oct 27, 2018 at 11:37:19PM +0300, Dafna Hirschfeld wrote:
>>> Add the callbacks `_req_validate` `_req_queue` of the struct
>>> `media_device_ops` as empty functions.
>>> Those will be implemented later.
>>
>> Hi Dafna,
>>
>> In general, unless it's a very complicated functionality, we usually
>> don't add code that doesn't have any users.
>>
>> It's fine to do it as part of a patchset where the usage comes in later
>> patches, but in cases such as these where there are no users,
>> maintainers will usually not take the patch.
> 
> I guess she was asked to do this as a small task by the video people?

That's correct. This task is there to learn a bit about the new request API
framework that will be used in the actual project. We won't merge this code,
only review it.

Regards,

	Hans

Re: [PATCH vicodec 1/1] media: vicodec: Add empty callbacks to prepare for the request API

[Hans Verkuil]

On 10/27/2018 10:37 PM, Dafna Hirschfeld wrote:
> Add the callbacks `_req_validate` `_req_queue` of the struct

Where does the '_' prefix come from?

Regards,

	Hans

> `media_device_ops` as empty functions.
> Those will be implemented later.
> 
> Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>
> ---
>  drivers/media/platform/vicodec/vicodec-core.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/media/platform/vicodec/vicodec-core.c b/drivers/media/platform/vicodec/vicodec-core.c
> index fdd77441a47b..238a59cdf3d6 100644
> --- a/drivers/media/platform/vicodec/vicodec-core.c
> +++ b/drivers/media/platform/vicodec/vicodec-core.c
> @@ -130,6 +130,20 @@ struct vicodec_ctx {
>  	bool			comp_has_next_frame;
>  };
>  
> +static int vicodec_request_validate(struct media_request *req)
> +{
> +	return 0;
> +}
> +
> +void vicodec_request_queue(struct media_request *req)
> +{
> +}
> +
> +static const struct media_device_ops vicodec_m2m_media_ops = {
> +	.req_validate   = vicodec_request_validate,
> +	.req_queue      = vicodec_request_queue,
> +};
> +
>  static inline struct vicodec_ctx *file2ctx(struct file *file)
>  {
>  	return container_of(file->private_data, struct vicodec_ctx, fh);
> 

[PATCH vicodec v2] media: vicodec: Add empty callbacks to prepare for the request API

[Dafna Hirschfeld]

Add the callbacks `req_validate` `req_queue` of the struct
`media_device_ops` as empty functions.
Those will be implemented later.

Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>
---
 drivers/media/platform/vicodec/vicodec-core.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/media/platform/vicodec/vicodec-core.c b/drivers/media/platform/vicodec/vicodec-core.c
index fdd77441a47b..238a59cdf3d6 100644
--- a/drivers/media/platform/vicodec/vicodec-core.c
+++ b/drivers/media/platform/vicodec/vicodec-core.c
@@ -130,6 +130,20 @@ struct vicodec_ctx {
 	bool			comp_has_next_frame;
 };
 
+static int vicodec_request_validate(struct media_request *req)
+{
+	return 0;
+}
+
+void vicodec_request_queue(struct media_request *req)
+{
+}
+
+static const struct media_device_ops vicodec_m2m_media_ops = {
+	.req_validate   = vicodec_request_validate,
+	.req_queue      = vicodec_request_queue,
+};
+
 static inline struct vicodec_ctx *file2ctx(struct file *file)
 {
 	return container_of(file->private_data, struct vicodec_ctx, fh);
-- 
2.17.1

Re: [PATCH vicodec v2] media: vicodec: Add empty callbacks to prepare for the request API

[Helen Koike]

On 10/29/18 10:42 AM, Dafna Hirschfeld wrote:
> Add the callbacks `req_validate` `req_queue` of the struct
> `media_device_ops` as empty functions.
> Those will be implemented later.
> 
> Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>
> ---
>  drivers/media/platform/vicodec/vicodec-core.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/media/platform/vicodec/vicodec-core.c b/drivers/media/platform/vicodec/vicodec-core.c
> index fdd77441a47b..238a59cdf3d6 100644
> --- a/drivers/media/platform/vicodec/vicodec-core.c
> +++ b/drivers/media/platform/vicodec/vicodec-core.c
> @@ -130,6 +130,20 @@ struct vicodec_ctx {
>  	bool			comp_has_next_frame;
>  };
>  
> +static int vicodec_request_validate(struct media_request *req)
> +{
> +	return 0;
> +}
> +
> +void vicodec_request_queue(struct media_request *req)
> +{
> +}
> +
> +static const struct media_device_ops vicodec_m2m_media_ops = {
> +	.req_validate   = vicodec_request_validate,
> +	.req_queue      = vicodec_request_queue,
> +};
> +
>  static inline struct vicodec_ctx *file2ctx(struct file *file)
>  {
>  	return container_of(file->private_data, struct vicodec_ctx, fh);
> 

Hi Dafna,

Thanks for your patch.

I believe we won't merge this patch now, this is just the base so we
could know that you are able to find your ways through the code, which
you did :)

Regards,
Helen