[meta-oe][PATCH] libssh: Do not use thumb-1 ISA on armv5

[meta-oe][PATCH] libssh: Do not use thumb-1 ISA on armv5

[Khem Raj]

Fixes
TOPDIR/build/tmpfs/work/armv5te-yoe-linux-gnueabi/libssh/0.8.4-r0/git/src/channels.c:2632:1:
sorry, unimplemented: -fstack-check=specific for Thumb-1

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Cc: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 meta-oe/recipes-support/libssh/libssh_0.8.4.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta-oe/recipes-support/libssh/libssh_0.8.4.bb b/meta-oe/recipes-support/libssh/libssh_0.8.4.bb
index 8566741a3a..6040ec959e 100644
--- a/meta-oe/recipes-support/libssh/libssh_0.8.4.bb
+++ b/meta-oe/recipes-support/libssh/libssh_0.8.4.bb
@@ -16,6 +16,8 @@ inherit cmake
 PACKAGECONFIG ??=""
 PACKAGECONFIG[gssapi] = "-DWITH_GSSAPI=1, -DWITH_GSSAPI=0, krb5, "
 
+ARM_INSTRUCTION_SET_armv5 = "arm"
+
 EXTRA_OECMAKE = " \
     -DWITH_GCRYPT=1 \
     -DWITH_PCAP=1 \
-- 
2.19.1

Re: [meta-oe][PATCH] libssh: Do not use thumb-1 ISA on armv5

[Adrian Bunk]

On Sat, Oct 27, 2018 at 06:30:29PM -0700, Khem Raj wrote:
> Fixes
> TOPDIR/build/tmpfs/work/armv5te-yoe-linux-gnueabi/libssh/0.8.4-r0/git/src/channels.c:2632:1:
> sorry, unimplemented: -fstack-check=specific for Thumb-1
>...
> +ARM_INSTRUCTION_SET_armv5 = "arm"
>...

This is then also required for armv4 and many armv6 CPUs.

The usual pattern for that appears to be:
ARM_INSTRUCTION_SET_armv4 = "arm"
ARM_INSTRUCTION_SET_armv5 = "arm"
ARM_INSTRUCTION_SET_armv6 = "arm"

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed