Re: [PATCH] Staging: rts5208: Shortened lines > 80 chars and aligned function args

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Thu, Oct 25, 2018 at 06:29:52PM +0100, Kim Bradley wrote:
> Reducing lines to < 80 characters and align function arguments
> wherever possible. Most of these issues appear due to the long
> function name 'wait_for_completion_interruptible_timeout' for
> which a TODO is noted.
> 
> Signed-off-by: Kim Bradley <kim.jamie.bradley@gmail.com>
> ---
>  drivers/staging/rts5208/TODO             |  5 ++++-
>  drivers/staging/rts5208/rtsx_transport.c | 28 +++++++++++++-----------
>  2 files changed, 19 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/staging/rts5208/TODO b/drivers/staging/rts5208/TODO
> index 57bcf5834c0c..67f0c8372d96 100644
> --- a/drivers/staging/rts5208/TODO
> +++ b/drivers/staging/rts5208/TODO
> @@ -1,7 +1,10 @@
>  TODO:
>  - use kernel coding style
>  - checkpatch.pl fixes
> +  --> Consider renaming 'wait_for_completion_interruptible_timeout'
> +      function in rtsx_transport as it causes many lines to
> +      overflow past 80 characters and/or alignment issues

This is a core kernel function, you can't fix that up within a single
staging driver, the whole kernel would have to be have the function
renamed.

So I can't take this patch because this isn't a valid TODO item, sorry,

greg k-h