* [PATCH] Staging: rts5208: Shortened lines > 80 chars and aligned function args
@ 2018-10-25 17:29 Kim Bradley
2018-10-30 9:32 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Kim Bradley @ 2018-10-25 17:29 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Greg Kroah-Hartman
Reducing lines to < 80 characters and align function arguments
wherever possible. Most of these issues appear due to the long
function name 'wait_for_completion_interruptible_timeout' for
which a TODO is noted.
Signed-off-by: Kim Bradley <kim.jamie.bradley@gmail.com>
---
drivers/staging/rts5208/TODO | 5 ++++-
drivers/staging/rts5208/rtsx_transport.c | 28 +++++++++++++-----------
2 files changed, 19 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rts5208/TODO b/drivers/staging/rts5208/TODO
index 57bcf5834c0c..67f0c8372d96 100644
--- a/drivers/staging/rts5208/TODO
+++ b/drivers/staging/rts5208/TODO
@@ -1,7 +1,10 @@
TODO:
- use kernel coding style
- checkpatch.pl fixes
+ --> Consider renaming 'wait_for_completion_interruptible_timeout'
+ function in rtsx_transport as it causes many lines to
+ overflow past 80 characters and/or alignment issues
- We will use the stack in drivers/mmc to implement
rts5208/5288 in the future
-Micky Ching <micky_ching@realsil.com.cn>
\ No newline at end of file
+Micky Ching <micky_ching@realsil.com.cn>
diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
index 8277d7895608..de9d9eec963f 100644
--- a/drivers/staging/rts5208/rtsx_transport.c
+++ b/drivers/staging/rts5208/rtsx_transport.c
@@ -257,8 +257,8 @@ int rtsx_send_cmd(struct rtsx_chip *chip, u8 card, int timeout)
spin_unlock_irq(&rtsx->reg_lock);
/* Wait for TRANS_OK_INT */
- timeleft = wait_for_completion_interruptible_timeout(
- &trans_done, msecs_to_jiffies(timeout));
+ timeleft = wait_for_completion_interruptible_timeout(&trans_done,
+ msecs_to_jiffies(timeout));
if (timeleft <= 0) {
dev_dbg(rtsx_dev(chip), "chip->int_reg = 0x%x\n",
chip->int_reg);
@@ -284,8 +284,8 @@ int rtsx_send_cmd(struct rtsx_chip *chip, u8 card, int timeout)
return err;
}
-static inline void rtsx_add_sg_tbl(
- struct rtsx_chip *chip, u32 addr, u32 len, u8 option)
+static inline void rtsx_add_sg_tbl(struct rtsx_chip *chip, u32 addr,
+ u32 len, u8 option)
{
__le64 *sgb = (__le64 *)(chip->host_sg_tbl_ptr);
u64 val = 0;
@@ -394,7 +394,8 @@ static int rtsx_transfer_sglist_adma_partial(struct rtsx_chip *chip, u8 card,
*index = *index + 1;
}
if ((i == (sg_cnt - 1)) || !resid)
- option = RTSX_SG_VALID | RTSX_SG_END | RTSX_SG_TRANS_DATA;
+ option = RTSX_SG_VALID | RTSX_SG_END |
+ RTSX_SG_TRANS_DATA;
else
option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
@@ -420,8 +421,8 @@ static int rtsx_transfer_sglist_adma_partial(struct rtsx_chip *chip, u8 card,
spin_unlock_irq(&rtsx->reg_lock);
- timeleft = wait_for_completion_interruptible_timeout(
- &trans_done, msecs_to_jiffies(timeout));
+ timeleft = wait_for_completion_interruptible_timeout(&trans_done,
+ msecs_to_jiffies(timeout));
if (timeleft <= 0) {
dev_dbg(rtsx_dev(chip), "Timeout (%s %d)\n",
__func__, __LINE__);
@@ -445,7 +446,7 @@ static int rtsx_transfer_sglist_adma_partial(struct rtsx_chip *chip, u8 card,
init_completion(&trans_done);
spin_unlock_irq(&rtsx->reg_lock);
timeleft = wait_for_completion_interruptible_timeout(
- &trans_done, msecs_to_jiffies(timeout));
+ &trans_done, msecs_to_jiffies(timeout));
if (timeleft <= 0) {
dev_dbg(rtsx_dev(chip), "Timeout (%s %d)\n",
__func__, __LINE__);
@@ -542,7 +543,8 @@ static int rtsx_transfer_sglist_adma(struct rtsx_chip *chip, u8 card,
(unsigned int)addr, len);
if (j == (sg_cnt - 1))
- option = RTSX_SG_VALID | RTSX_SG_END | RTSX_SG_TRANS_DATA;
+ option = RTSX_SG_VALID | RTSX_SG_END |
+ RTSX_SG_TRANS_DATA;
else
option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
@@ -566,7 +568,7 @@ static int rtsx_transfer_sglist_adma(struct rtsx_chip *chip, u8 card,
spin_unlock_irq(&rtsx->reg_lock);
timeleft = wait_for_completion_interruptible_timeout(
- &trans_done, msecs_to_jiffies(timeout));
+ &trans_done, msecs_to_jiffies(timeout));
if (timeleft <= 0) {
dev_dbg(rtsx_dev(chip), "Timeout (%s %d)\n",
__func__, __LINE__);
@@ -593,7 +595,7 @@ static int rtsx_transfer_sglist_adma(struct rtsx_chip *chip, u8 card,
init_completion(&trans_done);
spin_unlock_irq(&rtsx->reg_lock);
timeleft = wait_for_completion_interruptible_timeout(
- &trans_done, msecs_to_jiffies(timeout));
+ &trans_done, msecs_to_jiffies(timeout));
if (timeleft <= 0) {
dev_dbg(rtsx_dev(chip), "Timeout (%s %d)\n",
__func__, __LINE__);
@@ -679,8 +681,8 @@ static int rtsx_transfer_buf(struct rtsx_chip *chip, u8 card, void *buf,
spin_unlock_irq(&rtsx->reg_lock);
/* Wait for TRANS_OK_INT */
- timeleft = wait_for_completion_interruptible_timeout(
- &trans_done, msecs_to_jiffies(timeout));
+ timeleft = wait_for_completion_interruptible_timeout(&trans_done,
+ msecs_to_jiffies(timeout));
if (timeleft <= 0) {
dev_dbg(rtsx_dev(chip), "Timeout (%s %d)\n",
__func__, __LINE__);
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: rts5208: Shortened lines > 80 chars and aligned function args
2018-10-25 17:29 [PATCH] Staging: rts5208: Shortened lines > 80 chars and aligned function args Kim Bradley
@ 2018-10-30 9:32 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2018-10-30 9:32 UTC (permalink / raw)
To: Kim Bradley; +Cc: outreachy-kernel
On Thu, Oct 25, 2018 at 06:29:52PM +0100, Kim Bradley wrote:
> Reducing lines to < 80 characters and align function arguments
> wherever possible. Most of these issues appear due to the long
> function name 'wait_for_completion_interruptible_timeout' for
> which a TODO is noted.
>
> Signed-off-by: Kim Bradley <kim.jamie.bradley@gmail.com>
> ---
> drivers/staging/rts5208/TODO | 5 ++++-
> drivers/staging/rts5208/rtsx_transport.c | 28 +++++++++++++-----------
> 2 files changed, 19 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/staging/rts5208/TODO b/drivers/staging/rts5208/TODO
> index 57bcf5834c0c..67f0c8372d96 100644
> --- a/drivers/staging/rts5208/TODO
> +++ b/drivers/staging/rts5208/TODO
> @@ -1,7 +1,10 @@
> TODO:
> - use kernel coding style
> - checkpatch.pl fixes
> + --> Consider renaming 'wait_for_completion_interruptible_timeout'
> + function in rtsx_transport as it causes many lines to
> + overflow past 80 characters and/or alignment issues
This is a core kernel function, you can't fix that up within a single
staging driver, the whole kernel would have to be have the function
renamed.
So I can't take this patch because this isn't a valid TODO item, sorry,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-30 9:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-25 17:29 [PATCH] Staging: rts5208: Shortened lines > 80 chars and aligned function args Kim Bradley
2018-10-30 9:32 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.