Re: [PATCH] perf/core: clean up inconsisent indentation

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf/core: clean up inconsisent indentation
Date: Tue, 30 Oct 2018 14:44:44 +0000	[thread overview]
Message-ID: <20181030144444.GB23310@kernel.org> (raw)
In-Reply-To: <20181029233211.21475-1-colin.king@canonical.com>

Em Mon, Oct 29, 2018 at 11:32:11PM +0000, Colin King escreveu:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Replace a bunch of spaces with tab, cleans up indentation

I think we can live with the spaces as the 'git blame' information is
more valuable, i.e. who was that touched that line last?

Thanks,

- Arnaldo
 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  kernel/events/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 8c490130c4fb..84530ab358c3 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -750,7 +750,7 @@ static inline void update_cgrp_time_from_event(struct perf_event *event)
>  	/*
>  	 * Do not update time when cgroup is not active
>  	 */
> -       if (cgroup_is_descendant(cgrp->css.cgroup, event->cgrp->css.cgroup))
> +	if (cgroup_is_descendant(cgrp->css.cgroup, event->cgrp->css.cgroup))
>  		__update_cgrp_time(event->cgrp);
>  }
>  
> -- 
> 2.19.1

WARNING: multiple messages have this Message-ID (diff)

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf/core: clean up inconsisent indentation
Date: Tue, 30 Oct 2018 11:44:44 -0300	[thread overview]
Message-ID: <20181030144444.GB23310@kernel.org> (raw)
In-Reply-To: <20181029233211.21475-1-colin.king@canonical.com>

Em Mon, Oct 29, 2018 at 11:32:11PM +0000, Colin King escreveu:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Replace a bunch of spaces with tab, cleans up indentation

I think we can live with the spaces as the 'git blame' information is
more valuable, i.e. who was that touched that line last?

Thanks,

- Arnaldo
 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  kernel/events/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 8c490130c4fb..84530ab358c3 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -750,7 +750,7 @@ static inline void update_cgrp_time_from_event(struct perf_event *event)
>  	/*
>  	 * Do not update time when cgroup is not active
>  	 */
> -       if (cgroup_is_descendant(cgrp->css.cgroup, event->cgrp->css.cgroup))
> +	if (cgroup_is_descendant(cgrp->css.cgroup, event->cgrp->css.cgroup))
>  		__update_cgrp_time(event->cgrp);
>  }
>  
> -- 
> 2.19.1

next prev parent reply	other threads:[~2018-10-30 14:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-29 23:32 [PATCH] perf/core: clean up inconsisent indentation Colin King
2018-10-30  9:00 ` [tip:perf/urgent] perf/core: Clean " tip-bot for Colin Ian King
2018-10-30 14:44 ` Arnaldo Carvalho de Melo [this message]
2018-10-30 14:44   ` [PATCH] perf/core: clean " Arnaldo Carvalho de Melo
2018-10-30 19:25   ` Dan Carpenter
2018-10-30 19:25     ` Dan Carpenter
2018-10-30 19:34     ` Arnaldo Carvalho de Melo
2018-10-30 19:34       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181030144444.GB23310@kernel.org \
    --to=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=colin.king@canonical.com \
    --cc=jolsa@redhat.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.