From: thomas.petazzoni@bootlin.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [BUG] MVPP2 driver exploding in presence of a tap interface
Date: Tue, 30 Oct 2018 16:10:07 +0100 [thread overview]
Message-ID: <20181030161007.360d5a53@windsurf> (raw)
In-Reply-To: <6bf82e04-5463-aa7d-bbac-f09519ff9815@arm.com>
Hello,
On Tue, 30 Oct 2018 14:55:01 +0000, Marc Zyngier wrote:
> > I.e, isn't the firmware fix papering over a bug that should be fixed in
> > Linux mvpp2 driver anyway ?
>
> Absolutely. Leaving this unpatched in the kernel, with a 100% chance of
> memory corruption is just mad.
>
> I'm pretty sure there should be a way to sanely reset the interface
> before it starts repainting the memory.
I agree here. Do you still have an image of that old firmware version,
so that we can try to reproduce, and see if we can come up with a way
to reset the BM on boot up that would avoid this issue ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Marcin Wojtas <mw@semihalf.com>,
Antoine Tenart <antoine.tenart@bootlin.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
netdev <netdev@vger.kernel.org>,
Grzegorz Jaszczyk <jaz@semihalf.com>,
Tomasz Nowicki <tn@semihalf.com>
Subject: Re: [BUG] MVPP2 driver exploding in presence of a tap interface
Date: Tue, 30 Oct 2018 16:10:07 +0100 [thread overview]
Message-ID: <20181030161007.360d5a53@windsurf> (raw)
In-Reply-To: <6bf82e04-5463-aa7d-bbac-f09519ff9815@arm.com>
Hello,
On Tue, 30 Oct 2018 14:55:01 +0000, Marc Zyngier wrote:
> > I.e, isn't the firmware fix papering over a bug that should be fixed in
> > Linux mvpp2 driver anyway ?
>
> Absolutely. Leaving this unpatched in the kernel, with a 100% chance of
> memory corruption is just mad.
>
> I'm pretty sure there should be a way to sanely reset the interface
> before it starts repainting the memory.
I agree here. Do you still have an image of that old firmware version,
so that we can try to reproduce, and see if we can come up with a way
to reset the BM on boot up that would avoid this issue ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-10-30 15:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 15:05 [BUG] MVPP2 driver exploding in presence of a tap interface Marc Zyngier
2018-10-30 10:50 ` Antoine Tenart
2018-10-30 10:50 ` Antoine Tenart
2018-10-30 12:16 ` Marc Zyngier
2018-10-30 12:16 ` Marc Zyngier
2018-10-30 12:37 ` Marcin Wojtas
2018-10-30 12:37 ` Marcin Wojtas
2018-10-30 12:59 ` Marc Zyngier
2018-10-30 12:59 ` Marc Zyngier
2018-10-30 13:00 ` Thomas Petazzoni
2018-10-30 13:00 ` Thomas Petazzoni
2018-10-30 14:55 ` Marc Zyngier
2018-10-30 14:55 ` Marc Zyngier
2018-10-30 15:10 ` Thomas Petazzoni [this message]
2018-10-30 15:10 ` Thomas Petazzoni
2018-10-30 15:22 ` Marc Zyngier
2018-10-30 15:22 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030161007.360d5a53@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.