[Qemu-devel] [PULL 0/2] Misc next patches

[Qemu-devel] [PULL 0/2] Misc next patches

[Daniel P. Berrangé]

The following changes since commit a2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd:

  Merge remote-tracking branch 'remotes/vivier2/tags/qemu-trivial-for-3.1-pull-request' into staging (2018-10-30 15:49:55 +0000)

are available in the Git repository at:

  https://github.com/berrange/qemu tags/misc-next-pull-request

for you to fetch changes up to f5177798d899a2ee2a2d0babd3f5399d0f786333:

  scripts: report on author emails that are mangled by the mailing list (2018-10-31 11:31:08 +0000)

----------------------------------------------------------------
Merge misc fixes

----------------------------------------------------------------

Daniel P. Berrangé (2):
  block: drop moderated sheepdog mailing list from MAINTAINERS file
  scripts: report on author emails that are mangled by the mailing list

 MAINTAINERS           | 1 -
 scripts/checkpatch.pl | 4 ++++
 2 files changed, 4 insertions(+), 1 deletion(-)

-- 
2.19.1

[Qemu-devel] [PULL 1/2] block: drop moderated sheepdog mailing list from MAINTAINERS file

[Daniel P. Berrangé]

The sheepdog mailing list is setup to stop and queue messages from
non-subscribers, pending moderator approval. Unfortunately it seems
that the moderation queue is not actively deadlt with. Even when messages
are approved, the sender is never added to the whitelist, so every
future mail the same sender continues to get stopped for moderation.

MAINTAINERS entries should be responsive and not uneccessarily block
mails from QEMU contributors, so drop the sheepdog mailing list.

Reviewed-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index d794bd7a66..39f00d058b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2028,7 +2028,6 @@ Sheepdog
 M: Liu Yuan <namei.unix@gmail.com>
 M: Jeff Cody <jcody@redhat.com>
 L: qemu-block@nongnu.org
-L: sheepdog@lists.wpkg.org
 S: Supported
 F: block/sheepdog.c
 T: git git://github.com/codyprime/qemu-kvm-jtc.git block
-- 
2.19.1

[Qemu-devel] [PULL 2/2] scripts: report on author emails that are mangled by the mailing list

[Daniel P. Berrangé]

In some cases the Author: email address in patches submitted to the
list gets mangled such that it says

    John Doe via Qemu-devel <qemu-devel@nongnu.org>

This change is a result of workarounds for DMARC policies.

Subsystem maintainers accepting patches need to catch these and fix
them before sending pull requests, so a checkpatch.pl test is highly
desirable.

Reviewed-by: Eric Blake <eblake@redhat.com>
Acked-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 scripts/checkpatch.pl | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3765b0e35e..06ec14e7f7 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1402,6 +1402,10 @@ sub process {
 			$is_patch = 1;
 		}
 
+		if ($line =~ /^Author: .*via Qemu-devel.*<qemu-devel\@nongnu.org>/) {
+		    ERROR("Author email address is mangled by the mailing list\n" . $herecurr);
+		}
+
 #check the patch for a signoff:
 		if ($line =~ /^\s*signed-off-by:/i) {
 			# This is a signoff, if ugly, so do not double report.
-- 
2.19.1

Re: [Qemu-devel] [PULL 0/2] Misc next patches

[Peter Maydell]

On 31 October 2018 at 11:36, Daniel P. Berrangé <berrange@redhat.com> wrote:
> The following changes since commit a2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd:
>
>   Merge remote-tracking branch 'remotes/vivier2/tags/qemu-trivial-for-3.1-pull-request' into staging (2018-10-30 15:49:55 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/berrange/qemu tags/misc-next-pull-request
>
> for you to fetch changes up to f5177798d899a2ee2a2d0babd3f5399d0f786333:
>
>   scripts: report on author emails that are mangled by the mailing list (2018-10-31 11:31:08 +0000)
>
> ----------------------------------------------------------------
> Merge misc fixes
>
> ----------------------------------------------------------------
>
> Daniel P. Berrangé (2):
>   block: drop moderated sheepdog mailing list from MAINTAINERS file
>   scripts: report on author emails that are mangled by the mailing list
>
>  MAINTAINERS           | 1 -
>  scripts/checkpatch.pl | 4 ++++
>  2 files changed, 4 insertions(+), 1 deletion(-)

Applied, thanks.

-- PMM

Re: [Qemu-devel] [PULL 0/2] Misc next patches

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20181031113651.32430-1-berrange@redhat.com
Subject: [Qemu-devel] [PULL 0/2] Misc next patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
4ba8b05f47 Merge remote-tracking branch 'remotes/berrange/tags/misc-next-pull-request' into staging
79c328c135 scripts: report on author emails that are mangled by the mailing list
790a9af84d block: drop moderated sheepdog mailing list from MAINTAINERS file

=== OUTPUT BEGIN ===
Checking PATCH 1/3: block: drop moderated sheepdog mailing list from MAINTAINERS file...
Checking PATCH 2/3: scripts: report on author emails that are mangled by the mailing list...
WARNING: line over 80 characters
#36: FILE: scripts/checkpatch.pl:1405:
+		if ($line =~ /^Author: .*via Qemu-devel.*<qemu-devel\@nongnu.org>/) {

ERROR: line over 90 characters
#37: FILE: scripts/checkpatch.pl:1406:
+		    ERROR("Author email address is mangled by the mailing list\n" . $herecurr);

total: 1 errors, 1 warnings, 10 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/3: Merge remote-tracking branch 'remotes/berrange/tags/misc-next-pull-request' into staging...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com