From: Aleksa Sarai <cyphar@cyphar.com>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Masami Hiramatsu <mhiramat@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Shuah Khan <shuah@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: Aleksa Sarai <cyphar@cyphar.com>, Aleksa Sarai <asarai@suse.de>,
Christian Brauner <christian@brauner.io>,
Brendan Gregg <bgregg@netflix.com>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: [PATCH v3 2/2] trace: remove kretprobed checks
Date: Thu, 1 Nov 2018 19:35:51 +1100 [thread overview]
Message-ID: <20181101083551.3805-3-cyphar@cyphar.com> (raw)
In-Reply-To: <20181101083551.3805-1-cyphar@cyphar.com>
This is effectively a reversion of commit 76094a2cf46e ("ftrace:
distinguish kretprobe'd functions in trace logs"), as the checking of
kretprobe_trampoline *for tracing* is no longer necessary with the new
kretprobe stack trace changes.
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
---
kernel/trace/trace_output.c | 34 ++++------------------------------
1 file changed, 4 insertions(+), 30 deletions(-)
diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
index 6e6cc64faa38..951de16bd4fd 100644
--- a/kernel/trace/trace_output.c
+++ b/kernel/trace/trace_output.c
@@ -321,36 +321,14 @@ int trace_output_call(struct trace_iterator *iter, char *name, char *fmt, ...)
}
EXPORT_SYMBOL_GPL(trace_output_call);
-#ifdef CONFIG_KRETPROBES
-static inline const char *kretprobed(const char *name)
-{
- static const char tramp_name[] = "kretprobe_trampoline";
- int size = sizeof(tramp_name);
-
- if (strncmp(tramp_name, name, size) == 0)
- return "[unknown/kretprobe'd]";
- return name;
-}
-#else
-static inline const char *kretprobed(const char *name)
-{
- return name;
-}
-#endif /* CONFIG_KRETPROBES */
-
static void
seq_print_sym_short(struct trace_seq *s, const char *fmt, unsigned long address)
{
char str[KSYM_SYMBOL_LEN];
#ifdef CONFIG_KALLSYMS
- const char *name;
-
kallsyms_lookup(address, NULL, NULL, NULL, str);
-
- name = kretprobed(str);
-
- if (name && strlen(name)) {
- trace_seq_printf(s, fmt, name);
+ if (strlen(str)) {
+ trace_seq_printf(s, fmt, str);
return;
}
#endif
@@ -364,13 +342,9 @@ seq_print_sym_offset(struct trace_seq *s, const char *fmt,
{
char str[KSYM_SYMBOL_LEN];
#ifdef CONFIG_KALLSYMS
- const char *name;
-
sprint_symbol(str, address);
- name = kretprobed(str);
-
- if (name && strlen(name)) {
- trace_seq_printf(s, fmt, name);
+ if (strlen(str)) {
+ trace_seq_printf(s, fmt, str);
return;
}
#endif
--
2.19.1
WARNING: multiple messages have this Message-ID (diff)
From: cyphar at cyphar.com (Aleksa Sarai)
Subject: [PATCH v3 2/2] trace: remove kretprobed checks
Date: Thu, 1 Nov 2018 19:35:51 +1100 [thread overview]
Message-ID: <20181101083551.3805-3-cyphar@cyphar.com> (raw)
In-Reply-To: <20181101083551.3805-1-cyphar@cyphar.com>
This is effectively a reversion of commit 76094a2cf46e ("ftrace:
distinguish kretprobe'd functions in trace logs"), as the checking of
kretprobe_trampoline *for tracing* is no longer necessary with the new
kretprobe stack trace changes.
Signed-off-by: Aleksa Sarai <cyphar at cyphar.com>
---
kernel/trace/trace_output.c | 34 ++++------------------------------
1 file changed, 4 insertions(+), 30 deletions(-)
diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
index 6e6cc64faa38..951de16bd4fd 100644
--- a/kernel/trace/trace_output.c
+++ b/kernel/trace/trace_output.c
@@ -321,36 +321,14 @@ int trace_output_call(struct trace_iterator *iter, char *name, char *fmt, ...)
}
EXPORT_SYMBOL_GPL(trace_output_call);
-#ifdef CONFIG_KRETPROBES
-static inline const char *kretprobed(const char *name)
-{
- static const char tramp_name[] = "kretprobe_trampoline";
- int size = sizeof(tramp_name);
-
- if (strncmp(tramp_name, name, size) == 0)
- return "[unknown/kretprobe'd]";
- return name;
-}
-#else
-static inline const char *kretprobed(const char *name)
-{
- return name;
-}
-#endif /* CONFIG_KRETPROBES */
-
static void
seq_print_sym_short(struct trace_seq *s, const char *fmt, unsigned long address)
{
char str[KSYM_SYMBOL_LEN];
#ifdef CONFIG_KALLSYMS
- const char *name;
-
kallsyms_lookup(address, NULL, NULL, NULL, str);
-
- name = kretprobed(str);
-
- if (name && strlen(name)) {
- trace_seq_printf(s, fmt, name);
+ if (strlen(str)) {
+ trace_seq_printf(s, fmt, str);
return;
}
#endif
@@ -364,13 +342,9 @@ seq_print_sym_offset(struct trace_seq *s, const char *fmt,
{
char str[KSYM_SYMBOL_LEN];
#ifdef CONFIG_KALLSYMS
- const char *name;
-
sprint_symbol(str, address);
- name = kretprobed(str);
-
- if (name && strlen(name)) {
- trace_seq_printf(s, fmt, name);
+ if (strlen(str)) {
+ trace_seq_printf(s, fmt, str);
return;
}
#endif
--
2.19.1
WARNING: multiple messages have this Message-ID (diff)
From: cyphar@cyphar.com (Aleksa Sarai)
Subject: [PATCH v3 2/2] trace: remove kretprobed checks
Date: Thu, 1 Nov 2018 19:35:51 +1100 [thread overview]
Message-ID: <20181101083551.3805-3-cyphar@cyphar.com> (raw)
Message-ID: <20181101083551.P4sfYWdeLMe65LPLueY6OywVH33dZv8yTPk7bTW_0CI@z> (raw)
In-Reply-To: <20181101083551.3805-1-cyphar@cyphar.com>
This is effectively a reversion of commit 76094a2cf46e ("ftrace:
distinguish kretprobe'd functions in trace logs"), as the checking of
kretprobe_trampoline *for tracing* is no longer necessary with the new
kretprobe stack trace changes.
Signed-off-by: Aleksa Sarai <cyphar at cyphar.com>
---
kernel/trace/trace_output.c | 34 ++++------------------------------
1 file changed, 4 insertions(+), 30 deletions(-)
diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
index 6e6cc64faa38..951de16bd4fd 100644
--- a/kernel/trace/trace_output.c
+++ b/kernel/trace/trace_output.c
@@ -321,36 +321,14 @@ int trace_output_call(struct trace_iterator *iter, char *name, char *fmt, ...)
}
EXPORT_SYMBOL_GPL(trace_output_call);
-#ifdef CONFIG_KRETPROBES
-static inline const char *kretprobed(const char *name)
-{
- static const char tramp_name[] = "kretprobe_trampoline";
- int size = sizeof(tramp_name);
-
- if (strncmp(tramp_name, name, size) == 0)
- return "[unknown/kretprobe'd]";
- return name;
-}
-#else
-static inline const char *kretprobed(const char *name)
-{
- return name;
-}
-#endif /* CONFIG_KRETPROBES */
-
static void
seq_print_sym_short(struct trace_seq *s, const char *fmt, unsigned long address)
{
char str[KSYM_SYMBOL_LEN];
#ifdef CONFIG_KALLSYMS
- const char *name;
-
kallsyms_lookup(address, NULL, NULL, NULL, str);
-
- name = kretprobed(str);
-
- if (name && strlen(name)) {
- trace_seq_printf(s, fmt, name);
+ if (strlen(str)) {
+ trace_seq_printf(s, fmt, str);
return;
}
#endif
@@ -364,13 +342,9 @@ seq_print_sym_offset(struct trace_seq *s, const char *fmt,
{
char str[KSYM_SYMBOL_LEN];
#ifdef CONFIG_KALLSYMS
- const char *name;
-
sprint_symbol(str, address);
- name = kretprobed(str);
-
- if (name && strlen(name)) {
- trace_seq_printf(s, fmt, name);
+ if (strlen(str)) {
+ trace_seq_printf(s, fmt, str);
return;
}
#endif
--
2.19.1
next prev parent reply other threads:[~2018-11-01 8:36 UTC|newest]
Thread overview: 137+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 8:35 [PATCH v3 0/2] kretprobe: produce sane stack traces Aleksa Sarai
2018-11-01 8:35 ` Aleksa Sarai
2018-11-01 8:35 ` cyphar
2018-11-01 8:35 ` [PATCH v3 1/2] " Aleksa Sarai
2018-11-01 8:35 ` Aleksa Sarai
2018-11-01 8:35 ` cyphar
2018-11-01 15:20 ` Masami Hiramatsu
2018-11-01 15:20 ` Masami Hiramatsu
2018-11-01 15:20 ` Masami Hiramatsu
2018-11-01 15:20 ` mhiramat
2018-11-01 21:13 ` Aleksa Sarai
2018-11-01 21:13 ` Aleksa Sarai
2018-11-01 21:13 ` Aleksa Sarai
2018-11-01 21:13 ` cyphar
2018-11-02 3:04 ` Masami Hiramatsu
2018-11-02 3:04 ` Masami Hiramatsu
2018-11-02 3:04 ` Masami Hiramatsu
2018-11-02 3:04 ` mhiramat
2018-11-02 4:37 ` Aleksa Sarai
2018-11-02 4:37 ` Aleksa Sarai
2018-11-02 4:37 ` Aleksa Sarai
2018-11-02 4:37 ` cyphar
2018-11-03 12:47 ` Masami Hiramatsu
2018-11-03 12:47 ` Masami Hiramatsu
2018-11-03 12:47 ` Masami Hiramatsu
2018-11-03 12:47 ` mhiramat
2018-11-02 0:47 ` Steven Rostedt
2018-11-02 0:47 ` Steven Rostedt
2018-11-02 0:47 ` Steven Rostedt
2018-11-02 0:47 ` rostedt
2018-11-02 5:05 ` Aleksa Sarai
2018-11-02 5:05 ` Aleksa Sarai
2018-11-02 5:05 ` Aleksa Sarai
2018-11-02 5:05 ` cyphar
2018-11-02 6:59 ` Aleksa Sarai
2018-11-02 6:59 ` Aleksa Sarai
2018-11-02 6:59 ` Aleksa Sarai
2018-11-02 6:59 ` cyphar
2018-11-02 13:16 ` Steven Rostedt
2018-11-02 13:16 ` Steven Rostedt
2018-11-02 13:16 ` Steven Rostedt
2018-11-02 13:16 ` rostedt
2018-11-02 15:43 ` Josh Poimboeuf
2018-11-02 15:43 ` Josh Poimboeuf
2018-11-02 15:43 ` Josh Poimboeuf
2018-11-02 15:43 ` jpoimboe
2018-11-02 16:13 ` Steven Rostedt
2018-11-02 16:13 ` Steven Rostedt
2018-11-02 16:13 ` Steven Rostedt
2018-11-02 16:13 ` rostedt
2018-11-03 13:00 ` Masami Hiramatsu
2018-11-03 13:00 ` Masami Hiramatsu
2018-11-03 13:00 ` Masami Hiramatsu
2018-11-03 13:00 ` mhiramat
2018-11-03 13:13 ` Steven Rostedt
2018-11-03 13:13 ` Steven Rostedt
2018-11-03 13:13 ` Steven Rostedt
2018-11-03 13:13 ` rostedt
2018-11-03 16:34 ` Masami Hiramatsu
2018-11-03 16:34 ` Masami Hiramatsu
2018-11-03 16:34 ` Masami Hiramatsu
2018-11-03 16:34 ` mhiramat
2018-11-03 17:30 ` Steven Rostedt
2018-11-03 17:30 ` Steven Rostedt
2018-11-03 17:30 ` Steven Rostedt
2018-11-03 17:30 ` rostedt
2018-11-03 17:33 ` Steven Rostedt
2018-11-03 17:33 ` Steven Rostedt
2018-11-03 17:33 ` Steven Rostedt
2018-11-03 17:33 ` rostedt
2018-11-04 2:25 ` Masami Hiramatsu
2018-11-04 2:25 ` Masami Hiramatsu
2018-11-04 2:25 ` Masami Hiramatsu
2018-11-04 2:25 ` mhiramat
2018-11-03 7:02 ` Aleksa Sarai
2018-11-03 7:02 ` Aleksa Sarai
2018-11-03 7:02 ` Aleksa Sarai
2018-11-03 7:02 ` cyphar
2018-11-04 11:59 ` Aleksa Sarai
2018-11-04 11:59 ` Aleksa Sarai
2018-11-04 11:59 ` Aleksa Sarai
2018-11-04 11:59 ` cyphar
2018-11-06 22:15 ` Steven Rostedt
2018-11-06 22:15 ` Steven Rostedt
2018-11-06 22:15 ` Steven Rostedt
2018-11-06 22:15 ` rostedt
2018-11-08 7:46 ` Aleksa Sarai
2018-11-08 7:46 ` Aleksa Sarai
2018-11-08 7:46 ` Aleksa Sarai
2018-11-08 7:46 ` cyphar
2018-11-08 8:04 ` Aleksa Sarai
2018-11-08 8:04 ` Aleksa Sarai
2018-11-08 8:04 ` Aleksa Sarai
2018-11-08 8:04 ` cyphar
2018-11-08 14:44 ` Josh Poimboeuf
2018-11-08 14:44 ` Josh Poimboeuf
2018-11-08 14:44 ` Josh Poimboeuf
2018-11-08 14:44 ` jpoimboe
2018-11-09 7:26 ` Masami Hiramatsu
2018-11-09 7:26 ` Masami Hiramatsu
2018-11-09 7:26 ` Masami Hiramatsu
2018-11-09 7:26 ` mhiramat
2018-11-09 15:10 ` Aleksa Sarai
2018-11-09 15:10 ` Aleksa Sarai
2018-11-09 15:10 ` Aleksa Sarai
2018-11-09 15:10 ` asarai
2018-11-09 7:15 ` Masami Hiramatsu
2018-11-09 7:15 ` Masami Hiramatsu
2018-11-09 7:15 ` Masami Hiramatsu
2018-11-09 7:15 ` mhiramat
2018-11-09 15:06 ` Aleksa Sarai
2018-11-09 15:06 ` Aleksa Sarai
2018-11-09 15:06 ` Aleksa Sarai
2018-11-09 15:06 ` asarai
2018-11-10 15:31 ` Masami Hiramatsu
2018-11-10 15:31 ` Masami Hiramatsu
2018-11-10 15:31 ` Masami Hiramatsu
2018-11-10 15:31 ` mhiramat
2018-11-12 10:38 ` Aleksa Sarai
2018-11-12 10:38 ` Aleksa Sarai
2018-11-12 10:38 ` Aleksa Sarai
2018-11-12 10:38 ` asarai
2018-11-03 13:23 ` Masami Hiramatsu
2018-11-03 13:23 ` Masami Hiramatsu
2018-11-03 13:23 ` Masami Hiramatsu
2018-11-03 13:23 ` mhiramat
2018-11-02 7:58 ` Aleksa Sarai
2018-11-02 7:58 ` Aleksa Sarai
2018-11-02 7:58 ` Aleksa Sarai
2018-11-02 7:58 ` cyphar
2018-11-02 4:01 ` kbuild test robot
2018-11-02 4:01 ` kbuild test robot
2018-11-02 4:01 ` kbuild test robot
2018-11-02 4:01 ` lkp
2018-11-01 8:35 ` Aleksa Sarai [this message]
2018-11-01 8:35 ` [PATCH v3 2/2] trace: remove kretprobed checks Aleksa Sarai
2018-11-01 8:35 ` cyphar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101083551.3805-3-cyphar@cyphar.com \
--to=cyphar@cyphar.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=asarai@suse.de \
--cc=ast@kernel.org \
--cc=bgregg@netflix.com \
--cc=christian@brauner.io \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jolsa@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.