* Re: [PATCH] mmc: tmio: delete wait in tuning process
2018-10-31 23:00 [PATCH] mmc: tmio: delete wait in tuning process Niklas Söderlund
@ 2018-11-01 19:00 ` Wolfram Sang
2018-11-01 19:34 ` Wolfram Sang
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2018-11-01 19:00 UTC (permalink / raw)
To: Niklas Söderlund
Cc: Wolfram Sang, Masahiro Yamada, Ulf Hansson, linux-mmc,
linux-renesas-soc, Masaharu Hayakawa, Takeshi Saito,
Niklas Söderlund
[-- Attachment #1: Type: text/plain, Size: 702 bytes --]
On Thu, Nov 01, 2018 at 12:00:43AM +0100, Niklas Söderlund wrote:
> From: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com>
>
> The manual does not contain information that a wait is needed in the
> tuning process, this might be a leftover from early development.
> Removing the wait don't have any effect on operation so delete the wait
> to shorten the initialization time.
>
> Signed-off-by: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com>
> Signed-off-by: Takeshi Saito <takeshi.saito.xv@renesas.com>
> [Niklas: fixup commit message]
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mmc: tmio: delete wait in tuning process
2018-10-31 23:00 [PATCH] mmc: tmio: delete wait in tuning process Niklas Söderlund
2018-11-01 19:00 ` Wolfram Sang
@ 2018-11-01 19:34 ` Wolfram Sang
2018-11-02 11:55 ` Simon Horman
2018-11-19 12:07 ` Ulf Hansson
3 siblings, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2018-11-01 19:34 UTC (permalink / raw)
To: Niklas Söderlund
Cc: Wolfram Sang, Masahiro Yamada, Ulf Hansson, linux-mmc,
linux-renesas-soc, Masaharu Hayakawa, Takeshi Saito,
Niklas Söderlund
[-- Attachment #1: Type: text/plain, Size: 700 bytes --]
On Thu, Nov 01, 2018 at 12:00:43AM +0100, Niklas Söderlund wrote:
> From: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com>
>
> The manual does not contain information that a wait is needed in the
> tuning process, this might be a leftover from early development.
> Removing the wait don't have any effect on operation so delete the wait
> to shorten the initialization time.
>
> Signed-off-by: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com>
> Signed-off-by: Takeshi Saito <takeshi.saito.xv@renesas.com>
> [Niklas: fixup commit message]
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: tmio: delete wait in tuning process
2018-10-31 23:00 [PATCH] mmc: tmio: delete wait in tuning process Niklas Söderlund
2018-11-01 19:00 ` Wolfram Sang
2018-11-01 19:34 ` Wolfram Sang
@ 2018-11-02 11:55 ` Simon Horman
2018-11-19 12:07 ` Ulf Hansson
3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2018-11-02 11:55 UTC (permalink / raw)
To: Niklas Söderlund
Cc: Wolfram Sang, Masahiro Yamada, Ulf Hansson, linux-mmc,
linux-renesas-soc, Masaharu Hayakawa, Takeshi Saito,
Niklas Söderlund
On Thu, Nov 01, 2018 at 12:00:43AM +0100, Niklas Söderlund wrote:
> From: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com>
>
> The manual does not contain information that a wait is needed in the
> tuning process, this might be a leftover from early development.
> Removing the wait don't have any effect on operation so delete the wait
> to shorten the initialization time.
>
> Signed-off-by: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com>
> Signed-off-by: Takeshi Saito <takeshi.saito.xv@renesas.com>
> [Niklas: fixup commit message]
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: tmio: delete wait in tuning process
2018-10-31 23:00 [PATCH] mmc: tmio: delete wait in tuning process Niklas Söderlund
` (2 preceding siblings ...)
2018-11-02 11:55 ` Simon Horman
@ 2018-11-19 12:07 ` Ulf Hansson
3 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2018-11-19 12:07 UTC (permalink / raw)
To: Niklas Söderlund
Cc: Wolfram Sang, Masahiro Yamada, linux-mmc@vger.kernel.org,
Linux-Renesas, Masaharu Hayakawa, Takeshi Saito,
Niklas Söderlund
On 1 November 2018 at 00:00, Niklas Söderlund
<niklas.soderlund@ragnatech.se> wrote:
> From: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com>
>
> The manual does not contain information that a wait is needed in the
> tuning process, this might be a leftover from early development.
> Removing the wait don't have any effect on operation so delete the wait
> to shorten the initialization time.
>
> Signed-off-by: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com>
> Signed-off-by: Takeshi Saito <takeshi.saito.xv@renesas.com>
> [Niklas: fixup commit message]
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/tmio_mmc_core.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c
> index 8d64f6196f33e882..a8f917f744fb9f63 100644
> --- a/drivers/mmc/host/tmio_mmc_core.c
> +++ b/drivers/mmc/host/tmio_mmc_core.c
> @@ -734,8 +734,6 @@ static int tmio_mmc_execute_tuning(struct mmc_host *mmc, u32 opcode)
> ret = mmc_send_tuning(mmc, opcode, NULL);
> if (ret == 0)
> set_bit(i, host->taps);
> -
> - usleep_range(1000, 1200);
> }
>
> ret = host->select_tuning(host);
> --
> 2.19.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread