[PATCH] staging:dm365_ipipe:Add SPDX License Identifier

[PATCH] staging:dm365_ipipe:Add SPDX License Identifier

[Irenge Jules Bashizi]

Add SPDX license Identifier to fix checkpatch malformed license warning

Remove old style text describing the License

Signed-off-by: Irenge Jules Bashizi <jbi.octave@gmail.com>
---
 .../staging/media/davinci_vpfe/dm365_ipipe.c  | 31 ++++++-------------
 1 file changed, 9 insertions(+), 22 deletions(-)

diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
index dcfeac818451..20bd6d652931 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
@@ -1,29 +1,16 @@
+// SPDX-License-Identifier: GPL-2.0
+
 /*
- * Copyright (C) 2012 Texas Instruments Inc
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation version 2.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
- *
- * Contributors:
- *      Manjunath Hadli <manjunath.hadli@ti.com>
- *      Prabhakar Lad <prabhakar.lad@ti.com>
  *
  *
- * IPIPE allows fine tuning of the input image using different
- * tuning modules in IPIPE. Some examples :- Noise filter, Defect
- * pixel correction etc. It essentially operate on Bayer Raw data
- * or YUV raw data. To do image tuning, application call,
+ *	IPIPE allows fine tuning of the input image using different
+ *	tuning modules in IPIPE. Some examples :- Noise filter, Defect
+ *	pixel correction etc. It essentially operate on Bayer Raw data
+ *	or YUV raw data. To do image tuning, application call,
  *
+ *	Contributors:
+ *		Manjunath Hadli <manjunath.hadli@ti.com>
+ *		Prabhakar Lad <prabhakar.lad@ti.com>
  */
 
 #include <linux/slab.h>
-- 
2.17.2

Re: [Outreachy kernel] [PATCH] staging:dm365_ipipe:Add SPDX License Identifier

[Julia Lawall]

The subject line is still nto good.  If you look at git log --oneline on
this file, you will see eg:

106eb4d5f5be staging: media: davinci_vpfe: Use __func__ instead of function name

Actually, there are a lot of different examples for this file, but they
all have in common that there is a space are the :, which is not found in
your subject line.  As you can see in the example, it is also not necssary
to capitalize everything.

julia

On Sat, 3 Nov 2018, Irenge Jules Bashizi wrote:

> Add SPDX license Identifier to fix checkpatch malformed license warning
>
> Remove old style text describing the License
>
> Signed-off-by: Irenge Jules Bashizi <jbi.octave@gmail.com>
> ---
>  .../staging/media/davinci_vpfe/dm365_ipipe.c  | 31 ++++++-------------
>  1 file changed, 9 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> index dcfeac818451..20bd6d652931 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> @@ -1,29 +1,16 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
>  /*
> - * Copyright (C) 2012 Texas Instruments Inc
> - *
> - * This program is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License as
> - * published by the Free Software Foundation version 2.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
> - *
> - * Contributors:
> - *      Manjunath Hadli <manjunath.hadli@ti.com>
> - *      Prabhakar Lad <prabhakar.lad@ti.com>
>   *
>   *
> - * IPIPE allows fine tuning of the input image using different
> - * tuning modules in IPIPE. Some examples :- Noise filter, Defect
> - * pixel correction etc. It essentially operate on Bayer Raw data
> - * or YUV raw data. To do image tuning, application call,
> + *	IPIPE allows fine tuning of the input image using different
> + *	tuning modules in IPIPE. Some examples :- Noise filter, Defect
> + *	pixel correction etc. It essentially operate on Bayer Raw data
> + *	or YUV raw data. To do image tuning, application call,
>   *
> + *	Contributors:
> + *		Manjunath Hadli <manjunath.hadli@ti.com>
> + *		Prabhakar Lad <prabhakar.lad@ti.com>
>   */
>
>  #include <linux/slab.h>
> --
> 2.17.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181103120109.780-1-jbi.octave%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH] staging:dm365_ipipe:Add SPDX License Identifier

[Julia Lawall]

On Sat, 3 Nov 2018, Irenge Jules Bashizi wrote:

> Add SPDX license Identifier to fix checkpatch malformed license warning
>
> Remove old style text describing the License
>
> Signed-off-by: Irenge Jules Bashizi <jbi.octave@gmail.com>
> ---
>  .../staging/media/davinci_vpfe/dm365_ipipe.c  | 31 ++++++-------------
>  1 file changed, 9 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> index dcfeac818451..20bd6d652931 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> @@ -1,29 +1,16 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
>  /*
> - * Copyright (C) 2012 Texas Instruments Inc

Is it correct to remove this?

> - *
> - * This program is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License as
> - * published by the Free Software Foundation version 2.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
> - *
> - * Contributors:
> - *      Manjunath Hadli <manjunath.hadli@ti.com>
> - *      Prabhakar Lad <prabhakar.lad@ti.com>
>   *
>   *
> - * IPIPE allows fine tuning of the input image using different
> - * tuning modules in IPIPE. Some examples :- Noise filter, Defect
> - * pixel correction etc. It essentially operate on Bayer Raw data
> - * or YUV raw data. To do image tuning, application call,
> + *	IPIPE allows fine tuning of the input image using different
> + *	tuning modules in IPIPE. Some examples :- Noise filter, Defect
> + *	pixel correction etc. It essentially operate on Bayer Raw data
> + *	or YUV raw data. To do image tuning, application call,

Is there a reason to indent this text?

julia

>   *
> + *	Contributors:
> + *		Manjunath Hadli <manjunath.hadli@ti.com>
> + *		Prabhakar Lad <prabhakar.lad@ti.com>
>   */
>
>  #include <linux/slab.h>
> --
> 2.17.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181103120109.780-1-jbi.octave%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH] staging:dm365_ipipe:Add SPDX License Identifier

[Greg KH]

On Sat, Nov 03, 2018 at 03:16:39PM +0100, Julia Lawall wrote:
> 
> 
> On Sat, 3 Nov 2018, Irenge Jules Bashizi wrote:
> 
> > Add SPDX license Identifier to fix checkpatch malformed license warning
> >
> > Remove old style text describing the License
> >
> > Signed-off-by: Irenge Jules Bashizi <jbi.octave@gmail.com>
> > ---
> >  .../staging/media/davinci_vpfe/dm365_ipipe.c  | 31 ++++++-------------
> >  1 file changed, 9 insertions(+), 22 deletions(-)
> >
> > diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> > index dcfeac818451..20bd6d652931 100644
> > --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> > +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> > @@ -1,29 +1,16 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +
> >  /*
> > - * Copyright (C) 2012 Texas Instruments Inc
> 
> Is it correct to remove this?

Not at all, this should never be removed.

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH] staging:dm365_ipipe:Add SPDX License Identifier

[Jules Octave]

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

Thanks all for your kind advise . really appreciate it.

*Jules*
*..*
Positive action combined with positive thinking results in success - Shiv
Khera


On Sat, 3 Nov 2018 at 15:06, Greg KH <gregkh@linuxfoundation.org> wrote:

> On Sat, Nov 03, 2018 at 03:16:39PM +0100, Julia Lawall wrote:
> >
> >
> > On Sat, 3 Nov 2018, Irenge Jules Bashizi wrote:
> >
> > > Add SPDX license Identifier to fix checkpatch malformed license warning
> > >
> > > Remove old style text describing the License
> > >
> > > Signed-off-by: Irenge Jules Bashizi <jbi.octave@gmail.com>
> > > ---
> > >  .../staging/media/davinci_vpfe/dm365_ipipe.c  | 31 ++++++-------------
> > >  1 file changed, 9 insertions(+), 22 deletions(-)
> > >
> > > diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> > > index dcfeac818451..20bd6d652931 100644
> > > --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> > > +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> > > @@ -1,29 +1,16 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +
> > >  /*
> > > - * Copyright (C) 2012 Texas Instruments Inc
> >
> > Is it correct to remove this?
>
> Not at all, this should never be removed.
>
> thanks,
>
> greg k-h
>

[-- Attachment #2: Type: text/html, Size: 2543 bytes --]