From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] arm64: dts: Add support for NXP LS1028A SoC
Date: Sun, 4 Nov 2018 12:19:34 +0800 [thread overview]
Message-ID: <20181104041931.GB6093@tiger> (raw)
In-Reply-To: <AM6PR04MB4407CDF0EC1DE0442CF205508CCF0@AM6PR04MB4407.eurprd04.prod.outlook.com>
On Fri, Nov 02, 2018 at 09:51:49AM +0000, Bhaskar Upadhaya wrote:
>
>
> >-----Original Message-----
> >From: Shawn Guo <shawnguo@kernel.org>
> >Sent: Wednesday, October 31, 2018 12:44 PM
> >To: Bhaskar Upadhaya <bhaskar.upadhaya@nxp.com>
> >Cc: devicetree at vger.kernel.org; Harninder Rai <harninder.rai@nxp.com>;
> >Sudhanshu Gupta <sudhanshu.gupta@nxp.com>; Rajesh Bhagat
> ><rajesh.bhagat@nxp.com>; linux-arm-kernel at lists.infradead.org; Leo Li
> ><leoyang.li@nxp.com>
> >Subject: Re: [PATCH v2 1/2] arm64: dts: Add support for NXP LS1028A SoC
> >> + compatible = "fsl,ls1028a";
> >> + interrupt-parent = <&gic>;
> >> + #address-cells = <2>;
> >> + #size-cells = <2>;
> >> +
> >> + cpus {
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> +
> >> + cpu0: cpu at 0 {
> >> + device_type = "cpu";
> >> + compatible = "arm,cortex-a72";
> >> + reg = <0x0>;
> >> + enable-method = "psci";
> >> + clocks = <&clockgen 1 0>;
> >> + next-level-cache = <&l2>;
> >> + cpu-idle-states = <&CPU_PH20>;
> >> + };
> >> +
> >> + cpu1: cpu at 1 {
> >> + device_type = "cpu";
> >> + compatible = "arm,cortex-a72";
> >> + reg = <0x1>;
> >> + enable-method = "psci";
> >> + clocks = <&clockgen 1 0>;
> >> + next-level-cache = <&l2>;
> >> + cpu-idle-states = <&CPU_PH20>;
> >> + };
> >> +
> >> + l2: l2-cache {
> >> + compatible = "cache";
> >> + };
> >
> >Not sure what's the point of this node without any properties.
>
> Shawn, I looked into the NXP and non-NXP platforms, but all are creating cache nodes with "compatible" being the only property.
Okay, just noticed that the node is referred by next-level-cache
property of cpu node. So I guess this 'dummy' cache node is there only
for architectural integrity/sanity check or something.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Bhaskar Upadhaya <bhaskar.upadhaya@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Sudhanshu Gupta <sudhanshu.gupta@nxp.com>,
Harninder Rai <harninder.rai@nxp.com>,
Rajesh Bhagat <rajesh.bhagat@nxp.com>,
Leo Li <leoyang.li@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] arm64: dts: Add support for NXP LS1028A SoC
Date: Sun, 4 Nov 2018 12:19:34 +0800 [thread overview]
Message-ID: <20181104041931.GB6093@tiger> (raw)
In-Reply-To: <AM6PR04MB4407CDF0EC1DE0442CF205508CCF0@AM6PR04MB4407.eurprd04.prod.outlook.com>
On Fri, Nov 02, 2018 at 09:51:49AM +0000, Bhaskar Upadhaya wrote:
>
>
> >-----Original Message-----
> >From: Shawn Guo <shawnguo@kernel.org>
> >Sent: Wednesday, October 31, 2018 12:44 PM
> >To: Bhaskar Upadhaya <bhaskar.upadhaya@nxp.com>
> >Cc: devicetree@vger.kernel.org; Harninder Rai <harninder.rai@nxp.com>;
> >Sudhanshu Gupta <sudhanshu.gupta@nxp.com>; Rajesh Bhagat
> ><rajesh.bhagat@nxp.com>; linux-arm-kernel@lists.infradead.org; Leo Li
> ><leoyang.li@nxp.com>
> >Subject: Re: [PATCH v2 1/2] arm64: dts: Add support for NXP LS1028A SoC
> >> + compatible = "fsl,ls1028a";
> >> + interrupt-parent = <&gic>;
> >> + #address-cells = <2>;
> >> + #size-cells = <2>;
> >> +
> >> + cpus {
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> +
> >> + cpu0: cpu@0 {
> >> + device_type = "cpu";
> >> + compatible = "arm,cortex-a72";
> >> + reg = <0x0>;
> >> + enable-method = "psci";
> >> + clocks = <&clockgen 1 0>;
> >> + next-level-cache = <&l2>;
> >> + cpu-idle-states = <&CPU_PH20>;
> >> + };
> >> +
> >> + cpu1: cpu@1 {
> >> + device_type = "cpu";
> >> + compatible = "arm,cortex-a72";
> >> + reg = <0x1>;
> >> + enable-method = "psci";
> >> + clocks = <&clockgen 1 0>;
> >> + next-level-cache = <&l2>;
> >> + cpu-idle-states = <&CPU_PH20>;
> >> + };
> >> +
> >> + l2: l2-cache {
> >> + compatible = "cache";
> >> + };
> >
> >Not sure what's the point of this node without any properties.
>
> Shawn, I looked into the NXP and non-NXP platforms, but all are creating cache nodes with "compatible" being the only property.
Okay, just noticed that the node is referred by next-level-cache
property of cpu node. So I guess this 'dummy' cache node is there only
for architectural integrity/sanity check or something.
Shawn
next prev parent reply other threads:[~2018-11-04 4:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 11:49 [PATCH v2 1/2] arm64: dts: Add support for NXP LS1028A SoC Bhaskar Upadhaya
2018-10-17 11:49 ` Bhaskar Upadhaya
2018-10-17 11:49 ` [PATCH v2 2/2] dt-bindings: Add compatible string for LS1028A-QDS Bhaskar Upadhaya
2018-10-17 11:49 ` Bhaskar Upadhaya
2018-10-31 6:58 ` Shawn Guo
2018-10-31 6:58 ` Shawn Guo
2018-10-31 7:14 ` [PATCH v2 1/2] arm64: dts: Add support for NXP LS1028A SoC Shawn Guo
2018-10-31 7:14 ` Shawn Guo
2018-11-02 9:51 ` Bhaskar Upadhaya
2018-11-02 9:51 ` Bhaskar Upadhaya
2018-11-04 4:19 ` Shawn Guo [this message]
2018-11-04 4:19 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181104041931.GB6093@tiger \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.