From: Mel Gorman <mgorman@techsingularity.net>
To: Aaron Lu <aaron.lu@intel.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>,
=?utf-8:iso-8859-1?B?UGF3ZcWC?= Staszewski
<pstaszewski@itcare.pl>,
"Jesper Dangaard Brouer" <brouer@redhat.com>,
"Eric Dumazet" <eric.dumazet@gmail.com>,
"Tariq Toukan" <tariqt@mellanox.com>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Yoel Caspersen" <yoel@kviknet.dk>,
"Saeed Mahameed" <saeedm@mellanox.com>,
"Michal Hocko" <mhocko@suse.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Dave Hansen" <dave.hansen@linux.intel.com>
Subject: Re: [PATCH 1/2] mm/page_alloc: free order-0 pages through PCP in page_frag_free()
Date: Mon, 5 Nov 2018 09:26:42 +0000 [thread overview]
Message-ID: <20181105092642.GF23537@techsingularity.net> (raw)
In-Reply-To: <20181105085820.6341-1-aaron.lu@intel.com>
On Mon, Nov 05, 2018 at 04:58:19PM +0800, Aaron Lu wrote:
> page_frag_free() calls __free_pages_ok() to free the page back to
> Buddy. This is OK for high order page, but for order-0 pages, it
> misses the optimization opportunity of using Per-Cpu-Pages and can
> cause zone lock contention when called frequently.
>
> [1]: https://www.spinics.net/lists/netdev/msg531362.html
> [2]: https://www.spinics.net/lists/netdev/msg531421.html
> [3]: https://www.spinics.net/lists/netdev/msg531556.html
> Reported-by: PaweA? Staszewski <pstaszewski@itcare.pl>
> Analysed-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
Well spotted,
Acked-by: Mel Gorman <mgorman@techsingularity.net>
--
Mel Gorman
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@techsingularity.net>
To: Aaron Lu <aaron.lu@intel.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>,
=?utf-8:iso-8859-1?B?UGF3ZcWC?= Staszewski
<pstaszewski@itcare.pl>,
"Jesper Dangaard Brouer" <brouer@redhat.com>,
"Eric Dumazet" <eric.dumazet@gmail.com>,
"Tariq Toukan" <tariqt@mellanox.com>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Yoel Caspersen" <yoel@kviknet.dk>,
"Saeed Mahameed" <saeedm@mellanox.com>,
"Michal Hocko" <mhocko@suse.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Dave Hansen" <dave.hansen@linux.intel.com>
Subject: Re: [PATCH 1/2] mm/page_alloc: free order-0 pages through PCP in page_frag_free()
Date: Mon, 5 Nov 2018 09:26:42 +0000 [thread overview]
Message-ID: <20181105092642.GF23537@techsingularity.net> (raw)
In-Reply-To: <20181105085820.6341-1-aaron.lu@intel.com>
On Mon, Nov 05, 2018 at 04:58:19PM +0800, Aaron Lu wrote:
> page_frag_free() calls __free_pages_ok() to free the page back to
> Buddy. This is OK for high order page, but for order-0 pages, it
> misses the optimization opportunity of using Per-Cpu-Pages and can
> cause zone lock contention when called frequently.
>
> [1]: https://www.spinics.net/lists/netdev/msg531362.html
> [2]: https://www.spinics.net/lists/netdev/msg531421.html
> [3]: https://www.spinics.net/lists/netdev/msg531556.html
> Reported-by: Paweł Staszewski <pstaszewski@itcare.pl>
> Analysed-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
Well spotted,
Acked-by: Mel Gorman <mgorman@techsingularity.net>
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2018-11-05 9:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 8:58 [PATCH 1/2] mm/page_alloc: free order-0 pages through PCP in page_frag_free() Aaron Lu
2018-11-05 8:58 ` Aaron Lu
2018-11-05 8:58 ` [PATCH 2/2] mm/page_alloc: use a single function to free page Aaron Lu
2018-11-05 16:39 ` Dave Hansen
2018-11-06 5:30 ` [PATCH v2 " Aaron Lu
2018-11-06 8:16 ` Vlastimil Babka
2018-11-06 8:47 ` Aaron Lu
2018-11-06 9:32 ` Vlastimil Babka
2018-11-06 11:20 ` Aaron Lu
2018-11-06 11:31 ` [PATCH v3 " Aaron Lu
2018-11-06 12:06 ` Vlastimil Babka
2018-11-05 9:26 ` [PATCH 1/2] mm/page_alloc: free order-0 pages through PCP in page_frag_free() Vlastimil Babka
2018-11-05 9:26 ` Vlastimil Babka
2018-11-05 9:26 ` Mel Gorman [this message]
2018-11-05 9:26 ` Mel Gorman
2018-11-05 9:55 ` Jesper Dangaard Brouer
2018-11-05 10:46 ` Ilias Apalodimas
2018-11-05 10:46 ` Ilias Apalodimas
2018-11-05 15:44 ` Alexander Duyck
2018-11-10 23:54 ` Paweł Staszewski
2018-11-10 23:54 ` Paweł Staszewski
2018-11-11 23:05 ` Alexander Duyck
2018-11-12 0:39 ` Paweł Staszewski
2018-11-12 0:39 ` Paweł Staszewski
2018-11-12 15:30 ` Alexander Duyck
2018-11-12 15:44 ` Eric Dumazet
2018-11-12 17:06 ` Paweł Staszewski
2018-11-12 17:06 ` Paweł Staszewski
2018-11-12 17:01 ` Paweł Staszewski
2018-11-12 17:01 ` Paweł Staszewski
2018-11-05 16:37 ` Dave Hansen
2018-11-06 5:28 ` [PATCH v2 " Aaron Lu
2018-11-06 5:28 ` Aaron Lu
2018-11-07 9:59 ` Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105092642.GF23537@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=aaron.lu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=brouer@redhat.com \
--cc=dave.hansen@linux.intel.com \
--cc=eric.dumazet@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=netdev@vger.kernel.org \
--cc=pstaszewski@itcare.pl \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
--cc=vbabka@suse.cz \
--cc=yoel@kviknet.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.