From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
Subject: [PATCH v3 2/2] staging: erofs: Modify conditional checks
Date: Mon, 5 Nov 2018 15:03:06 +0100 [thread overview]
Message-ID: <20181105140306.GA20228@kroah.com> (raw)
In-Reply-To: <b36253c9dacce060a90e84f3e8d854749800d720.1541421259.git.digholebhagyashri@gmail.com>
On Mon, Nov 05, 2018@12:35:03PM +0000, Bhagyashri P. Dighole wrote:
> Fix coding style alignment issues detected by checkpatch.pl
> Use ! for NULL test rather than explicitly comparing to NULL.
>
> Signed-off-by: Bhagyashri P. Dighole <digholebhagyashri at gmail.com>
> ---
> drivers/staging/erofs/data.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Why did you send this patch twice?
And what changed in it from v1 and v2? Always put that information
below the --- line.
Please fix this up and resend the whole series with that information.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Bhagyashri P. Dighole" <digholebhagyashri@gmail.com>
Cc: Gao Xiang <gaoxiang25@huawei.com>, Chao Yu <yuchao0@huawei.com>,
Sasha Levin <sashal@kernel.org>,
Outreachy <outreachy-kernel@googlegroups.com>,
linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH v3 2/2] staging: erofs: Modify conditional checks
Date: Mon, 5 Nov 2018 15:03:06 +0100 [thread overview]
Message-ID: <20181105140306.GA20228@kroah.com> (raw)
In-Reply-To: <b36253c9dacce060a90e84f3e8d854749800d720.1541421259.git.digholebhagyashri@gmail.com>
On Mon, Nov 05, 2018 at 12:35:03PM +0000, Bhagyashri P. Dighole wrote:
> Fix coding style alignment issues detected by checkpatch.pl
> Use ! for NULL test rather than explicitly comparing to NULL.
>
> Signed-off-by: Bhagyashri P. Dighole <digholebhagyashri@gmail.com>
> ---
> drivers/staging/erofs/data.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Why did you send this patch twice?
And what changed in it from v1 and v2? Always put that information
below the --- line.
Please fix this up and resend the whole series with that information.
thanks,
greg k-h
next prev parent reply other threads:[~2018-11-05 14:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 14:49 [PATCH v3 1/2] staging: erofs: Modify coding style alignments Bhagyashri P. Dighole
2018-11-05 14:49 ` Bhagyashri P. Dighole
2018-11-05 12:35 ` [PATCH v3 2/2] staging: erofs: Modify conditional checks Bhagyashri P. Dighole
2018-11-05 14:50 ` Bhagyashri P. Dighole
2018-11-05 12:35 ` Bhagyashri P. Dighole
2018-11-05 14:03 ` Greg Kroah-Hartman [this message]
2018-11-05 14:03 ` Greg Kroah-Hartman
2018-11-05 15:43 ` Gao Xiang
2018-11-05 15:43 ` Gao Xiang
2018-11-05 15:50 ` [Outreachy kernel] " Julia Lawall
2018-11-05 15:50 ` Julia Lawall
2018-11-05 18:07 ` Bhagyashri Dighole
2018-11-05 18:07 ` Bhagyashri Dighole
2018-11-05 18:22 ` Gao Xiang
2018-11-05 18:22 ` Gao Xiang
2018-11-05 19:08 ` Himanshu Jha
2018-11-05 19:08 ` Himanshu Jha
2018-11-05 15:37 ` [PATCH v3 1/2] staging: erofs: Modify coding style alignments Gao Xiang
2018-11-05 15:37 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105140306.GA20228@kroah.com \
--to=gregkh@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.