All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Laís Pessine do Carmo" <laispc19@gmail.com>
To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
	gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	lkcamp@lists.libreplanetbr.org
Subject: [PATCH] staging: sm750fb: Add spaces around '+'
Date: Wed, 07 Nov 2018 00:28:04 +0000	[thread overview]
Message-ID: <20181107002804.25345-1-laispc19@gmail.com> (raw)

Add spaces around '+' to correct the following checkpath.pl warnings:

WARNING: line over 80 characters
+                       write_dpPort(accel, *(unsigned int *)(pSrcbuf +
(j * 4)));

WARNING: line over 80 characters
+                       memcpy(ajRemain, pSrcbuf+ul4BytesPerScan,
ulBytesRemain);

Signed-off-by: Laís Pessine do Carmo <laispc19@gmail.com>

---

Hi, I am new to Linux community and I am sending this patch to learn
about the kernel development.
Please, let me know if there is anything I can improve.
Thank you!
---
 drivers/staging/sm750fb/sm750_accel.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
index 1035e91e7cd3..eed840b251da 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c
@@ -383,7 +383,8 @@ int sm750_hw_imageblit(struct lynx_accel *accel,
 			write_dpPort(accel, *(unsigned int *)(pSrcbuf + (j * 4)));
 
 		if (ulBytesRemain) {
-			memcpy(ajRemain, pSrcbuf+ul4BytesPerScan, ulBytesRemain);
+			memcpy(ajRemain, pSrcbuf + ul4BytesPerScan,
+			       ulBytesRemain);
 			write_dpPort(accel, *(unsigned int *)ajRemain);
 		}
 
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: "Laís Pessine do Carmo" <laispc19@gmail.com>
To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
	gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	lkcamp@lists.libreplanetbr.org
Subject: [PATCH] staging: sm750fb: Add spaces around '+'
Date: Tue,  6 Nov 2018 22:28:04 -0200	[thread overview]
Message-ID: <20181107002804.25345-1-laispc19@gmail.com> (raw)

Add spaces around '+' to correct the following checkpath.pl warnings:

WARNING: line over 80 characters
+                       write_dpPort(accel, *(unsigned int *)(pSrcbuf +
(j * 4)));

WARNING: line over 80 characters
+                       memcpy(ajRemain, pSrcbuf+ul4BytesPerScan,
ulBytesRemain);

Signed-off-by: Laís Pessine do Carmo <laispc19@gmail.com>

---

Hi, I am new to Linux community and I am sending this patch to learn
about the kernel development.
Please, let me know if there is anything I can improve.
Thank you!
---
 drivers/staging/sm750fb/sm750_accel.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
index 1035e91e7cd3..eed840b251da 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c
@@ -383,7 +383,8 @@ int sm750_hw_imageblit(struct lynx_accel *accel,
 			write_dpPort(accel, *(unsigned int *)(pSrcbuf + (j * 4)));
 
 		if (ulBytesRemain) {
-			memcpy(ajRemain, pSrcbuf+ul4BytesPerScan, ulBytesRemain);
+			memcpy(ajRemain, pSrcbuf + ul4BytesPerScan,
+			       ulBytesRemain);
 			write_dpPort(accel, *(unsigned int *)ajRemain);
 		}
 
-- 
2.11.0


             reply	other threads:[~2018-11-07  0:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-07  0:28 Laís Pessine do Carmo [this message]
2018-11-07  0:28 ` [PATCH] staging: sm750fb: Add spaces around '+' Laís Pessine do Carmo
2018-11-07 11:33 ` Greg KH
2018-11-07 11:33   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181107002804.25345-1-laispc19@gmail.com \
    --to=laispc19@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkcamp@lists.libreplanetbr.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.