From: Brian Norris <briannorris@chromium.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: devicetree@vger.kernel.org, Govind Singh <govinds@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-wireless@vger.kernel.org,
ath10k@lists.infradead.org, robh+dt@kernel.org,
andy.gross@linaro.org, linux-soc@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt: bindings: add missing dt properties for WCN3990 wifi node
Date: Tue, 6 Nov 2018 18:58:36 -0800 [thread overview]
Message-ID: <20181107025834.GA43723@google.com> (raw)
In-Reply-To: <20181107000655.GA53622@google.com>
On Tue, Nov 06, 2018 at 04:07:01PM -0800, Brian Norris wrote:
> On Mon, Nov 05, 2018 at 08:33:02AM -0800, Stephen Boyd wrote:
> > And yes, from what you've told me here it would make sense to make the
> > WCN chip a subnode of this SoC node instead of a phandle connecting the
> > two.
>
> I could begrudgingly agree with that.
...
>
> wifi: wifi@18800000 {
> compatible = "qcom,sdm845-wifi";
> reg = <...>
> clocks = <...>
> vdd-0.8-cx-mx-supply = <...>
> ... interrupts, etc. ...
>
> rf { // I don't know what to call this node. Suggestions
> // welcome.
> compatible = "qcom,wcn3990-wifi";
> vdd-1.8-xo-supply = <...>;
> vdd-1.3-rfa-supply = <...>;
> vdd-3.3-ch0-supply = <...>;
> };
> };
By the way...I realize one reason why I've been "begrudging" on this:
the single-node binding was already reviewed and merged upstream as of
v4.18:
ae316c4cbba2 dt: bindings: add bindings for wcn3990 wifi block
It seems like a lot of needless churn to rewrite the entire binding,
only to
* make the usage of these regulators a little clearer and
* possibly help distinguish different variants of WCN3990 usage (e.g.,
on different SoCs) -- I don't even know how different "WCN3990" looks
when used on something non-SDM845.
Even if the second bullet point is important, we could fix this by a
more judicious use of 'compatible', rather than inventing whole new
nodes.
Regards,
Brian
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
To: Stephen Boyd <sboyd-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Govind Singh <govinds-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
ath10k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH v3 1/3] dt: bindings: add missing dt properties for WCN3990 wifi node
Date: Tue, 6 Nov 2018 18:58:36 -0800 [thread overview]
Message-ID: <20181107025834.GA43723@google.com> (raw)
In-Reply-To: <20181107000655.GA53622-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
On Tue, Nov 06, 2018 at 04:07:01PM -0800, Brian Norris wrote:
> On Mon, Nov 05, 2018 at 08:33:02AM -0800, Stephen Boyd wrote:
> > And yes, from what you've told me here it would make sense to make the
> > WCN chip a subnode of this SoC node instead of a phandle connecting the
> > two.
>
> I could begrudgingly agree with that.
...
>
> wifi: wifi@18800000 {
> compatible = "qcom,sdm845-wifi";
> reg = <...>
> clocks = <...>
> vdd-0.8-cx-mx-supply = <...>
> ... interrupts, etc. ...
>
> rf { // I don't know what to call this node. Suggestions
> // welcome.
> compatible = "qcom,wcn3990-wifi";
> vdd-1.8-xo-supply = <...>;
> vdd-1.3-rfa-supply = <...>;
> vdd-3.3-ch0-supply = <...>;
> };
> };
By the way...I realize one reason why I've been "begrudging" on this:
the single-node binding was already reviewed and merged upstream as of
v4.18:
ae316c4cbba2 dt: bindings: add bindings for wcn3990 wifi block
It seems like a lot of needless churn to rewrite the entire binding,
only to
* make the usage of these regulators a little clearer and
* possibly help distinguish different variants of WCN3990 usage (e.g.,
on different SoCs) -- I don't even know how different "WCN3990" looks
when used on something non-SDM845.
Even if the second bullet point is important, we could fix this by a
more judicious use of 'compatible', rather than inventing whole new
nodes.
Regards,
Brian
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris@chromium.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Govind Singh <govinds@codeaurora.org>,
andy.gross@linaro.org, ath10k@lists.infradead.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org, linux-wireless@vger.kernel.org,
robh+dt@kernel.org
Subject: Re: [PATCH v3 1/3] dt: bindings: add missing dt properties for WCN3990 wifi node
Date: Tue, 6 Nov 2018 18:58:36 -0800 [thread overview]
Message-ID: <20181107025834.GA43723@google.com> (raw)
In-Reply-To: <20181107000655.GA53622@google.com>
On Tue, Nov 06, 2018 at 04:07:01PM -0800, Brian Norris wrote:
> On Mon, Nov 05, 2018 at 08:33:02AM -0800, Stephen Boyd wrote:
> > And yes, from what you've told me here it would make sense to make the
> > WCN chip a subnode of this SoC node instead of a phandle connecting the
> > two.
>
> I could begrudgingly agree with that.
...
>
> wifi: wifi@18800000 {
> compatible = "qcom,sdm845-wifi";
> reg = <...>
> clocks = <...>
> vdd-0.8-cx-mx-supply = <...>
> ... interrupts, etc. ...
>
> rf { // I don't know what to call this node. Suggestions
> // welcome.
> compatible = "qcom,wcn3990-wifi";
> vdd-1.8-xo-supply = <...>;
> vdd-1.3-rfa-supply = <...>;
> vdd-3.3-ch0-supply = <...>;
> };
> };
By the way...I realize one reason why I've been "begrudging" on this:
the single-node binding was already reviewed and merged upstream as of
v4.18:
ae316c4cbba2 dt: bindings: add bindings for wcn3990 wifi block
It seems like a lot of needless churn to rewrite the entire binding,
only to
* make the usage of these regulators a little clearer and
* possibly help distinguish different variants of WCN3990 usage (e.g.,
on different SoCs) -- I don't even know how different "WCN3990" looks
when used on something non-SDM845.
Even if the second bullet point is important, we could fix this by a
more judicious use of 'compatible', rather than inventing whole new
nodes.
Regards,
Brian
next prev parent reply other threads:[~2018-11-07 2:58 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 11:52 [PATCH v3 0/3] Enable ath10k wcn3990 wifi driver support on sdm845 Govind Singh
2018-10-10 11:52 ` Govind Singh
2018-10-10 11:52 ` Govind Singh
2018-10-10 11:52 ` [PATCH v3 1/3] dt: bindings: add missing dt properties for WCN3990 wifi node Govind Singh
2018-10-10 11:52 ` Govind Singh
2018-10-10 11:52 ` Govind Singh
2018-10-12 16:18 ` Rob Herring
2018-10-12 16:18 ` Rob Herring
2018-10-12 16:18 ` Rob Herring
2018-10-16 22:53 ` Doug Anderson
2018-10-16 22:53 ` Doug Anderson
2018-10-16 22:53 ` Doug Anderson
2018-10-30 12:40 ` Govind Singh
2018-10-30 12:40 ` Govind Singh
2018-10-30 12:40 ` Govind Singh
2018-10-17 7:41 ` Stephen Boyd
2018-10-17 7:41 ` Stephen Boyd
2018-10-17 7:41 ` Stephen Boyd
2018-11-02 18:43 ` Brian Norris
2018-11-02 18:43 ` Brian Norris
2018-11-02 18:43 ` Brian Norris
2018-11-05 16:33 ` Stephen Boyd
2018-11-05 16:33 ` Stephen Boyd
2018-11-05 16:33 ` Stephen Boyd
2018-11-07 0:07 ` Brian Norris
2018-11-07 0:07 ` Brian Norris
2018-11-07 0:07 ` Brian Norris
2018-11-07 2:58 ` Brian Norris [this message]
2018-11-07 2:58 ` Brian Norris
2018-11-07 2:58 ` Brian Norris
2018-10-10 11:52 ` [PATCH v3 2/3] dts: arm64/sdm845: Add WCN3990 WLAN module device node Govind Singh
2018-10-10 11:52 ` Govind Singh
2018-10-10 11:52 ` Govind Singh
2018-10-16 21:45 ` Doug Anderson
2018-10-16 21:45 ` Doug Anderson
2018-10-16 21:45 ` Doug Anderson
2018-10-17 7:33 ` Stephen Boyd
2018-10-17 7:33 ` Stephen Boyd
2018-10-17 7:33 ` Stephen Boyd
2018-10-10 11:52 ` [PATCH v3 3/3] dt: bindings: add bindings for wifi iommu node Govind Singh
2018-10-10 11:52 ` Govind Singh
2018-10-10 11:52 ` Govind Singh
2018-10-12 16:19 ` Rob Herring
2018-10-12 16:19 ` Rob Herring
2018-10-12 16:19 ` Rob Herring
2018-10-12 23:02 ` [PATCH v3 0/3] Enable ath10k wcn3990 wifi driver support on sdm845 Brian Norris
2018-10-12 23:02 ` Brian Norris
2018-10-12 23:02 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107025834.GA43723@google.com \
--to=briannorris@chromium.org \
--cc=andy.gross@linaro.org \
--cc=ath10k@lists.infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=govinds@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.