From: Oleg Nesterov <oleg@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Elvira Khabirova <lineprinter@altlinux.org>,
rostedt@goodmis.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, ldv@altlinux.org, esyr@redhat.com,
luto@kernel.org, strace-devel@lists.strace.io
Subject: Re: [RFC PATCH] ptrace: add PTRACE_GET_SYSCALL_INFO request
Date: Thu, 8 Nov 2018 15:33:43 +0100 [thread overview]
Message-ID: <20181108143342.GC9939@redhat.com> (raw)
In-Reply-To: <35B601B0-4D56-4706-B7A1-C9A522AB2D6F@amacapital.net>
On 11/07, Andy Lutomirski wrote:
>
> > On Nov 7, 2018, at 8:44 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > Not sure I understand you... I do not like "compat" too, but this patch uses
> > is_compat/etc and I agree with any naming.
>
> My point is: returning a value to user code that is:
>
> 0 if the kernel and tracee are 32-bit
> 0 if the kernel and tracer are 64-but
> 1 if the kernel is 64-bit and the tracer is 32-bit
> ? If the tracer is arm64 ILP32
>
> Is not a good design. And 32-bit builds of strace will not appreciate it.
Sure, I agree.
> While oddly named, audit_arch fits the bill nicely, and we already
> require it to have the right semantics for seccomp support.
Again, I agree, and I even mentioned PTRACE_EVENT_SECCOMP.
This reminds me about in_ia32_syscall/TS_COMPAT problems... The 1st one is
get_nr_restart_syscall, I'll try to re-send the fix tomorrow.
Another problem is in_compat_syscall() in get_unmapped_area() paths, it can
return the addr > TASK_SIZE for uprobed 32-bit task.
There was something else but I forgot...
Oleg.
next prev parent reply other threads:[~2018-11-08 14:33 UTC|newest]
Thread overview: 214+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 3:27 [RFC PATCH] ptrace: add PTRACE_GET_SYSCALL_INFO request Elvira Khabirova
2018-11-07 11:21 ` Oleg Nesterov
2018-11-07 14:06 ` Andy Lutomirski
2018-11-07 16:44 ` Oleg Nesterov
2018-11-07 20:02 ` Elvira Khabirova
2018-11-08 9:16 ` Oleg Nesterov
2018-11-07 20:20 ` Andy Lutomirski
2018-11-08 14:33 ` Oleg Nesterov [this message]
2018-11-07 16:12 ` Dmitry V. Levin
2018-11-07 15:50 ` Dmitry V. Levin
2018-11-07 20:44 ` Andy Lutomirski
2018-11-09 3:13 ` [PATCH 00/13] Prepare for PTRACE_GET_SYSCALL_INFO Dmitry V. Levin
2018-11-09 3:13 ` Dmitry V. Levin
2018-11-09 3:13 ` Dmitry V. Levin
2018-11-09 3:13 ` Dmitry V. Levin
2018-11-09 3:13 ` Dmitry V. Levin
2018-11-09 3:15 ` [PATCH 01/13] Move EM_HEXAGON to uapi/linux/elf-em.h Dmitry V. Levin
2018-11-09 3:15 ` [PATCH 02/13] elf-em.h: add EM_ARC Dmitry V. Levin
2018-11-09 3:15 ` Dmitry V. Levin
2018-11-09 14:20 ` Alexey Brodkin
2018-11-09 14:20 ` Alexey Brodkin
2018-11-09 16:41 ` Vineet Gupta
2018-11-09 16:41 ` Vineet Gupta
2018-11-09 21:44 ` Dmitry V. Levin
2018-11-09 21:44 ` Dmitry V. Levin
2018-11-09 23:33 ` [PATCH 02/13 v2] Move EM_ARCOMPACT and EM_ARCV2 to uapi/linux/elf-em.h Dmitry V. Levin
2018-11-09 23:33 ` Dmitry V. Levin
2018-11-09 23:42 ` Vineet Gupta
2018-11-09 23:42 ` Vineet Gupta
2018-11-09 3:15 ` [PATCH 03/13] elf-em.h: add EM_NDS32 Dmitry V. Levin
2018-11-09 3:15 ` [PATCH 04/13] elf-em.h: add EM_XTENSA Dmitry V. Levin
2018-11-09 6:45 ` Max Filippov
2018-11-09 3:15 ` [PATCH 05/13] m68k: define syscall_get_arch() Dmitry V. Levin
2018-11-09 3:16 ` [PATCH 06/13] arc: " Dmitry V. Levin
2018-11-09 3:16 ` Dmitry V. Levin
2018-11-09 14:22 ` Alexey Brodkin
2018-11-09 14:22 ` Alexey Brodkin
2018-11-09 15:17 ` Andy Lutomirski
2018-11-09 15:17 ` Andy Lutomirski
2018-11-09 15:27 ` Alexey Brodkin
2018-11-09 15:27 ` Alexey Brodkin
2018-11-09 15:56 ` Andy Lutomirski
2018-11-09 15:56 ` Andy Lutomirski
2018-11-09 16:11 ` Alexey Brodkin
2018-11-09 16:11 ` Alexey Brodkin
2018-11-09 16:35 ` Andy Lutomirski
2018-11-09 16:35 ` Andy Lutomirski
2018-11-09 23:33 ` [PATCH 06/13 v2] " Dmitry V. Levin
2018-11-09 23:33 ` Dmitry V. Levin
2018-11-09 23:39 ` Vineet Gupta
2018-11-09 23:39 ` Vineet Gupta
2018-11-09 23:54 ` [PATCH 06/13 v3] " Dmitry V. Levin
2018-11-09 23:54 ` Dmitry V. Levin
2018-11-10 0:06 ` Vineet Gupta
2018-11-10 0:06 ` Vineet Gupta
2018-11-09 16:50 ` [PATCH 06/13] " Vineet Gupta
2018-11-09 16:50 ` Vineet Gupta
2018-11-09 19:03 ` Andy Lutomirski
2018-11-09 19:03 ` Andy Lutomirski
2018-11-09 19:13 ` Vineet Gupta
2018-11-09 19:13 ` Vineet Gupta
2018-11-09 3:16 ` [PATCH 07/13] c6x: " Dmitry V. Levin
2018-11-10 2:01 ` [PATCH 07/13 v2] " Dmitry V. Levin
2018-11-09 3:16 ` [PATCH 08/13] h8300: " Dmitry V. Levin
2018-11-09 3:16 ` [PATCH 09/13] hexagon: " Dmitry V. Levin
2018-11-09 3:16 ` [PATCH 10/13] nds32: " Dmitry V. Levin
2018-11-10 2:01 ` [PATCH 10/13 v2] " Dmitry V. Levin
2018-11-09 3:17 ` [PATCH 11/13] nios2: " Dmitry V. Levin
2018-11-09 3:17 ` [PATCH 12/13] riscv: " Dmitry V. Levin
2018-11-09 3:17 ` Dmitry V. Levin
2018-11-09 3:17 ` Dmitry V. Levin
2018-11-09 6:59 ` David Abdurachmanov
2018-11-09 6:59 ` David Abdurachmanov
2018-11-09 6:59 ` David Abdurachmanov
2018-11-09 22:28 ` Dmitry V. Levin
2018-11-09 22:28 ` Dmitry V. Levin
2018-11-09 22:28 ` Dmitry V. Levin
2018-11-10 5:12 ` David Abdurachmanov
2018-11-10 5:12 ` David Abdurachmanov
2018-11-10 5:12 ` David Abdurachmanov
2018-11-10 9:27 ` Andreas Schwab
2018-11-10 9:27 ` Andreas Schwab
2018-11-10 9:27 ` Andreas Schwab
2018-11-10 9:27 ` Andreas Schwab
2018-11-09 18:45 ` Palmer Dabbelt
2018-11-09 18:45 ` Palmer Dabbelt
2018-11-09 18:45 ` Palmer Dabbelt
2018-11-09 21:31 ` Dmitry V. Levin
2018-11-09 21:31 ` Dmitry V. Levin
2018-11-09 21:31 ` Dmitry V. Levin
2018-11-09 22:48 ` [PATCH 12/13 v2] " Dmitry V. Levin
2018-11-09 22:48 ` Dmitry V. Levin
2018-11-09 22:48 ` Dmitry V. Levin
2018-11-11 21:21 ` Palmer Dabbelt
2018-11-11 21:21 ` Palmer Dabbelt
2018-11-11 21:21 ` Palmer Dabbelt
2018-11-09 3:17 ` [PATCH 13/13] xtensa: " Dmitry V. Levin
2018-11-09 6:48 ` Max Filippov
2018-11-09 6:06 ` [PATCH 00/13] Prepare for PTRACE_GET_SYSCALL_INFO Andy Lutomirski
2018-11-09 6:06 ` Andy Lutomirski
2018-11-09 6:06 ` Andy Lutomirski
2018-11-09 6:06 ` Andy Lutomirski
2018-11-09 6:06 ` Andy Lutomirski
2018-11-10 14:09 ` [PATCH 14/13] Move EM_UNICORE to uapi/linux/elf-em.h Dmitry V. Levin
2018-11-10 14:10 ` [PATCH 15/13] unicore32: define syscall_get_arch() Dmitry V. Levin
2018-11-13 3:38 ` [RFC PATCH] ptrace: add PTRACE_GET_SYSCALL_INFO request Dmitry V. Levin
2018-11-20 0:11 ` [PATCH v2 00/15] Prepare for PTRACE_GET_SYSCALL_INFO Dmitry V. Levin
2018-11-20 0:11 ` Dmitry V. Levin
2018-11-20 0:11 ` Dmitry V. Levin
2018-11-20 0:11 ` Dmitry V. Levin
2018-11-20 0:11 ` Dmitry V. Levin
2018-11-20 0:14 ` [PATCH v2 01/15] Move EM_HEXAGON to uapi/linux/elf-em.h Dmitry V. Levin
2018-11-20 0:14 ` [PATCH v2 02/15] Move EM_ARCOMPACT and EM_ARCV2 " Dmitry V. Levin
2018-11-20 0:14 ` Dmitry V. Levin
2018-11-20 0:14 ` [PATCH v2 03/15] Move EM_UNICORE " Dmitry V. Levin
2018-11-20 0:15 ` [PATCH v2 04/15] elf-em.h: add EM_NDS32 Dmitry V. Levin
2018-11-20 0:15 ` [PATCH v2 05/15] elf-em.h: add EM_XTENSA Dmitry V. Levin
2018-11-20 0:15 ` [PATCH v2 06/15] m68k: define syscall_get_arch() Dmitry V. Levin
2018-12-02 10:29 ` Geert Uytterhoeven
2018-12-03 0:24 ` Dmitry V. Levin
2018-12-03 7:36 ` Geert Uytterhoeven
2018-11-20 0:15 ` [PATCH v2 07/15] arc: " Dmitry V. Levin
2018-11-20 0:15 ` Dmitry V. Levin
2018-11-20 0:15 ` [PATCH v2 08/15] c6x: " Dmitry V. Levin
2018-11-20 0:16 ` [PATCH v2 09/15] h8300: " Dmitry V. Levin
2018-11-20 0:16 ` [PATCH v2 10/15] hexagon: " Dmitry V. Levin
2018-11-20 0:16 ` [PATCH v2 11/15] nds32: " Dmitry V. Levin
2018-11-20 0:16 ` [PATCH v2 12/15] nios2: " Dmitry V. Levin
2018-11-20 0:16 ` [PATCH v2 13/15] riscv: " Dmitry V. Levin
2018-11-20 0:16 ` Dmitry V. Levin
2018-11-20 0:16 ` Dmitry V. Levin
2018-11-20 0:16 ` [PATCH v2 14/15] unicore32: " Dmitry V. Levin
2018-11-20 0:17 ` [PATCH v2 15/15] xtensa: " Dmitry V. Levin
2018-11-20 20:26 ` [PATCH v2 00/15] Prepare for PTRACE_GET_SYSCALL_INFO Paul Moore
2018-11-20 20:26 ` Paul Moore
2018-11-20 20:26 ` Paul Moore
2018-11-20 20:26 ` Paul Moore
2018-11-21 0:44 ` [PATCH v2 16/15] syscall_get_arch: add "struct task_struct *" argument Dmitry V. Levin
2018-11-21 0:44 ` Dmitry V. Levin
2018-11-21 0:44 ` [OpenRISC] " Dmitry V. Levin
2018-11-21 0:44 ` Dmitry V. Levin
2018-11-21 0:44 ` Dmitry V. Levin
2018-11-21 0:44 ` Dmitry V. Levin
2018-11-21 0:44 ` Dmitry V. Levin
2018-11-21 0:44 ` Dmitry V. Levin
2018-11-21 15:15 ` Andy Lutomirski
2018-11-21 15:15 ` Andy Lutomirski
2018-11-21 15:15 ` Andy Lutomirski
2018-11-21 15:15 ` [OpenRISC] " Andy Lutomirski
2018-11-21 15:15 ` Andy Lutomirski
2018-11-21 15:15 ` Andy Lutomirski
2018-11-21 15:15 ` Andy Lutomirski
2018-11-21 15:15 ` Andy Lutomirski
2018-11-21 15:15 ` Andy Lutomirski
2018-11-21 15:15 ` Andy Lutomirski
2018-11-21 15:15 ` Andy Lutomirski
2018-11-21 15:47 ` Palmer Dabbelt
2018-11-21 15:47 ` Palmer Dabbelt
2018-11-21 15:47 ` [OpenRISC] " Palmer Dabbelt
2018-11-21 15:47 ` Palmer Dabbelt
2018-11-21 15:47 ` Palmer Dabbelt
2018-11-21 15:47 ` Palmer Dabbelt
2018-11-21 15:47 ` Palmer Dabbelt
2018-11-21 15:47 ` Palmer Dabbelt
2018-11-21 15:47 ` Palmer Dabbelt
2018-11-21 18:40 ` Paul Burton
2018-11-21 18:40 ` Paul Burton
2018-11-21 18:40 ` Paul Burton
2018-11-21 18:40 ` [OpenRISC] " Paul Burton
2018-11-21 18:40 ` Paul Burton
2018-11-21 18:40 ` Paul Burton
2018-11-21 18:40 ` Paul Burton
2018-11-21 18:40 ` Paul Burton
2018-11-21 18:40 ` Paul Burton
2018-11-21 19:00 ` Dmitry V. Levin
2018-11-21 19:00 ` Dmitry V. Levin
2018-11-21 19:00 ` Dmitry V. Levin
2018-11-21 19:00 ` [OpenRISC] " Dmitry V. Levin
2018-11-21 19:00 ` Dmitry V. Levin
2018-11-21 19:00 ` Dmitry V. Levin
2018-11-21 19:00 ` Dmitry V. Levin
2018-11-21 19:00 ` Dmitry V. Levin
2018-11-21 19:00 ` Dmitry V. Levin
2018-11-21 19:00 ` Dmitry V. Levin
2018-11-21 19:14 ` [PATCH] mips: fix mips_get_syscall_arg o32 check Dmitry V. Levin
2018-11-21 19:23 ` Paul Burton
2018-11-21 19:23 ` Paul Burton
2018-11-21 19:35 ` [PATCH v2 16/15 v2] syscall_get_arch: add "struct task_struct *" argument Dmitry V. Levin
2018-11-21 19:35 ` Dmitry V. Levin
2018-11-21 19:35 ` Dmitry V. Levin
2018-11-21 19:35 ` [OpenRISC] " Dmitry V. Levin
2018-11-21 19:35 ` Dmitry V. Levin
2018-11-21 19:35 ` Dmitry V. Levin
2018-11-21 19:35 ` Dmitry V. Levin
2018-11-21 19:35 ` Dmitry V. Levin
2018-11-21 19:35 ` Dmitry V. Levin
2018-11-21 19:35 ` Dmitry V. Levin
2018-11-21 19:45 ` Paul Burton
2018-11-21 19:45 ` Paul Burton
2018-11-21 19:45 ` Paul Burton
2018-11-21 19:45 ` [OpenRISC] " Paul Burton
2018-11-21 19:45 ` Paul Burton
2018-11-21 19:45 ` Paul Burton
2018-11-21 19:45 ` Paul Burton
2018-11-21 19:45 ` Paul Burton
2018-11-21 19:45 ` Paul Burton
2018-11-27 10:34 ` [PATCH v2 16/15] " Michael Ellerman
2018-11-27 10:34 ` Michael Ellerman
2018-11-27 10:34 ` [OpenRISC] " Michael Ellerman
2018-11-27 10:34 ` Michael Ellerman
2018-11-27 10:34 ` Michael Ellerman
2018-11-27 10:34 ` Michael Ellerman
2018-11-27 10:34 ` Michael Ellerman
2018-11-27 10:34 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108143342.GC9939@redhat.com \
--to=oleg@redhat.com \
--cc=esyr@redhat.com \
--cc=ldv@altlinux.org \
--cc=lineprinter@altlinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=strace-devel@lists.strace.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.